[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365807809 @reddycharan I'd like to clarify this PR is the first change for BP-27, it just tries to setup the skeleton and port only 3 commands. more changes are coming if we agree on the skeleton. also this change is a new CLI, it doesn't change existing behavior of old bookie shell and break any BC. This PR doesn't target on replacing everything of BookieShell. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365798669 @reddycharan I have addressed your comments. please take a look again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365788909 @reddycharan I updated this PR to make listbookies to list all bookies if no args is provided or both args are provided. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365788948 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365781973 @reddycharan okay I will update headlines like "readwrite bookies" and "readonly bookies". does that make sense? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365779270 @reddycharan yes. I fixed that after your first comment. your second comment was asking for printing bookies when "one and only one flag is set". so does it make sense for me to revert that? then the behavior will be: - "-rw" prints read/write bookies - "-ro" prints readonly bookies - no args prints both - "-rw" and "-ro" print both can we agree on this is the expected behavior? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365772210 > Is there any command to list all bookies and their state? For example, by default, we list all bookies running in the cluster and their running mode if no args is given. If we specify -ro, we only list read only bookies? Good point! I think the original change I made supports listing all bookies by default. I reverted it to limit to use either "-ro" or "-rw" only as the old CLI does per @reddycharan 's suggestion. @reddycharan do you think we should remove this limitation on new bookkeeper CLI to support "list all bookies" if no arg is provided or both args are provided. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365694176 @reddycharan I have addressed your comments. please review it again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-364985545 ping @reddycharan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-363816947 @reddycharan I think I addressed all your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-362783315 @jvrao @reddycharan: since you guys contributed a lot of shell commands, it would be great that you guys can spend some time on reviewing this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-362783195 This change is ready to review now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
