[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-366283372 IGNORE CI This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-366282111 IGNORE CI (All CI passed except "Integration Tests". This change is purely on changing tests. So it doesn't need "Integration Tests" to verify it) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-365681168 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-362389035 @reddycharan yes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-362368268 @jvrao @reddycharan can you guys take the change here? I think the decommission test was contributed by you guys. It would be good if you guys can check to ensure my change doesn't change the testing purpose. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-362214679 An example jenkins job on how long each test takes. Most of the tests run more than 1 minutes. https://builds.apache.org/job/bookkeeper_precommit_pullrequest_java8/239/org.apache.bookkeeper$bookkeeper-server/testReport/org.apache.bookkeeper.client/BookKeeperAdminTest/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services