[GitHub] sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12
sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-365688896 @merlimat yeah. this PR is good for 4.6.2. so if you can fix the checkstyle here, I can merge it to 4.7.0 and 4.6.2. and #1441 can come later in master for 4.7.0. How does that sound? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12
sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-365680586 @merlimat do you need any help to fix the checkstyle problem, so we can move forward with merging this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12
sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-362512879 marked this for both 4.6.2 and 4.7.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
