[GitHub] sijie commented on issue #1133: Integration smoke test
sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-365695215 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1133: Integration smoke test
sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364964063 > Wrapping all calls in FutureUtils.result is ugly as hell well. I think "ugly" is just a developer preference, the sync methods anyway need to use "get" or "result(...)". at twitter, we only expose async method and provide a util class `Await` to wait synchronously. so the question here is more about whether we want to expose sync method for every method we are adding, or just providing a util class or let the application use CompletableFuture.get to wait synchronously. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1133: Integration smoke test
sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364958541 > You have to put .get() at the end of all calls, and can't directly catch specific exceptions. you can use `FutureUtils.result(...)` which already unwrap the exception from ExecutionException, so you can catch specific exceptions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1133: Integration smoke test
sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364611365 > regarding the api, I'd like to see some issues resolved with it before I start using it in tests. what are the issues blocking using it in tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1133: Integration smoke test
sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364611287 > it makes sense to use the new API once is will be considered stable or 'beta' I think it is the reverse, we should make tests to use API before considering it as stable or beta. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
