[GitHub] sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

2018-03-16 Thread GitBox
sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value URL: https://github.com/apache/bookkeeper/pull/1252#issuecomment-373891639 retest this please This is an automated message from t

[GitHub] sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

2018-03-16 Thread GitBox
sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value URL: https://github.com/apache/bookkeeper/pull/1252#issuecomment-373801729 retest this please This is an automated message from t

[GitHub] sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

2018-03-15 Thread GitBox
sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value URL: https://github.com/apache/bookkeeper/pull/1252#issuecomment-373488516 @dlg99 can you take a look at this change? I think the logic of 'digest type autodetection' has some problems. since yo

[GitHub] sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

2018-03-14 Thread GitBox
sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value URL: https://github.com/apache/bookkeeper/pull/1252#issuecomment-373113946 retest this please This is an automated message from t

[GitHub] sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

2018-03-13 Thread GitBox
sijie commented on issue #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value URL: https://github.com/apache/bookkeeper/pull/1252#issuecomment-372575452 > may this change break existing tests, or at least change the meaning of what is tested ? CI will tell.