[GitHub] sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says

2018-05-17 Thread GitBox
sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says URL: https://github.com/apache/bookkeeper/issues/1411#issuecomment-390042148 @ivankelly I see. but that's more about consistency between metadata and the information in entries. I don't know a dir

[GitHub] sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says

2018-05-17 Thread GitBox
sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says URL: https://github.com/apache/bookkeeper/issues/1411#issuecomment-389951450 let's submit a BP and fix the new API and deprecate the method in the old API. ---

[GitHub] sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says

2018-05-17 Thread GitBox
sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says URL: https://github.com/apache/bookkeeper/issues/1411#issuecomment-389951279 > I seem to remember it being very broken at some point in any case, and noone complained. why? it is not broken

[GitHub] sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says

2018-05-17 Thread GitBox
sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says URL: https://github.com/apache/bookkeeper/issues/1411#issuecomment-389925757 @ivankelly okay you are talking about the new API. for new API it is fine. I was talking about the old API. http://boo

[GitHub] sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says

2018-05-17 Thread GitBox
sijie commented on issue #1411: LedgerEntry#getLength does not do what the documentation says URL: https://github.com/apache/bookkeeper/issues/1411#issuecomment-389916787 for BC consideration, we can fix the documentation first. We can consider deprecating `getLength` later, introdu