sijie opened a new pull request #1116: Cleanup registration client interface
URL: https://github.com/apache/bookkeeper/pull/1116
 
 
   Descriptions of the changes in this PR:
   
   This change is mainly to remove `zookeeper` reference from metadata 
interface. The existence of `Optional<ZooKeeper>` is to allow passing an 
external zookeeper client to bookkeeper, so bookkeeper can reuse that client 
instance. That is useful for services like pulsar broker, which they can only 
instantiate a zookeeper client and pass the zookeeper client around to 
construct bookkeeper client. However, this pollutes the registration client 
interface, change the method to `Optional<Object>` as an optional context 
object and let the implementation interpret it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to