[GitHub] yzang commented on issue #1256: Issue 1255: Bookie should not advance the journal marker before creating the index file

2018-03-14 Thread GitBox 
yzang commented on issue #1256: Issue 1255: Bookie should not advance the 
journal marker before creating the index file
URL: https://github.com/apache/bookkeeper/pull/1256#issuecomment-373026517
 
 
   @sijie Yeah, we'll cherry pick the change and try a deploy to see if problem 
is fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yzang commented on issue #1256: Issue 1255: Bookie should not advance the journal marker before creating the index file

2018-03-13 Thread GitBox 
yzang commented on issue #1256: Issue 1255: Bookie should not advance the 
journal marker before creating the index file
URL: https://github.com/apache/bookkeeper/pull/1256#issuecomment-372885030
 
 
   This issue is keep happening at Twitter, the error we keep getting is:
   
   > Exception while replaying journals, shutting down
   > java.io.IOException: Missing ledger signature
   >at org.apache.bookkeeper.bookie.FileInfo.readHeader(FileInfo.java:153)
   >at org.apache.bookkeeper.bookie.FileInfo.checkOpen(FileInfo.java:205)
   >at org.apache.bookkeeper.bookie.FileInfo.checkOpen(FileInfo.java:176)
   >at org.apache.bookkeeper.bookie.FileInfo.getMasterKey(FileInfo.java:428)
   >at 
org.apache.bookkeeper.bookie.IndexPersistenceMgr.readMasterKey(IndexPersistenceMgr.java:387)
   >at 
org.apache.bookkeeper.bookie.LedgerCacheImpl.readMasterKey(LedgerCacheImpl.java:154)
   >at 
org.apache.bookkeeper.bookie.InterleavedLedgerStorage.readMasterKey(InterleavedLedgerStorage.java:174)
   >at 
org.apache.bookkeeper.bookie.SortedLedgerStorage.readMasterKey(SortedLedgerStorage.java:38)
   >at org.apache.bookkeeper.bookie.Bookie$3.process(Bookie.java:663)
   >at org.apache.bookkeeper.bookie.Journal.scanJournal(Journal.java:677)
   >at org.apache.bookkeeper.bookie.Journal.replay(Journal.java:721)
   >at org.apache.bookkeeper.bookie.Bookie.readJournal(Bookie.java:628)
   >at org.apache.bookkeeper.bookie.Bookie.start(Bookie.java:747)
   >at org.apache.bookkeeper.proto.BookieServer.start(BookieServer.java:114)
   >at org.apache.bookkeeper.proto.BookieServer.main(BookieServer.java:369)
   
   Really nice to have this bug to be fixed!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services