[jira] [Comment Edited] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match SEMI/ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933093#comment-16933093 ] jin xing edited comment on CALCITE-3363 at 9/19/19 6:25 AM: Check my PR

[jira] [Commented] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match SEMI/ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933093#comment-16933093 ] jin xing commented on CALCITE-3363: --- Check my PR please; For sql like below: select r1.sal from emp

[jira] [Updated] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3363: -- Summary: JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join (was:

[jira] [Updated] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3363: -- Description: JoinUnionTransposeRule works by pull up union from below to top of join. Thus it should

[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933197#comment-16933197 ] Danny Chan commented on CALCITE-3349: - [~walterddr], there is no reason, it is just not implemented

[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933213#comment-16933213 ] Danny Chan commented on CALCITE-3349: - Personally, i'm okey with this change, but i have no strong

[jira] [Commented] (CALCITE-3354) RelToSqlConverter does not support LogicalTableFunctionScan

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933211#comment-16933211 ] Danny Chan commented on CALCITE-3354: - Thanks for reporting [~anha], and welcome to contribute ~ >

[jira] [Commented] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join

2019-09-19 Thread Wang Yanlin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933107#comment-16933107 ] Wang Yanlin commented on CALCITE-3363: -- OK, I see. for *A anti join (B union C)* is not equals to

[jira] [Commented] (CALCITE-1178) Allow SqlBetweenOperator to compare DATE and TIMESTAMP

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933207#comment-16933207 ] Danny Chan commented on CALCITE-1178: - [~jacobroldan], yeah, you are right, 1.21 supports implicit

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933090#comment-16933090 ] jin xing commented on CALCITE-3353: --- [~danny0405] It sometime comes to me that it might make sense

[jira] [Commented] (CALCITE-3329) Implement osquery for OS adapter

2019-09-19 Thread Forward Xu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933287#comment-16933287 ] Forward Xu commented on CALCITE-3329: - hi [~julianhyde]  thank you very much, is there any doubt

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Kirill Kozlov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933589#comment-16933589 ] Kirill Kozlov commented on CALCITE-3355: [~Chunwei Lei], thanks for volunteering to tackle

[jira] [Updated] (CALCITE-3323) Handle arbitrary/unknown functions that have ordinary syntax

2019-09-19 Thread Ryan Fu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Fu updated CALCITE-3323: - Description: Add a strategy where if a function has ordinary function syntax and we don't recognize

[jira] [Commented] (CALCITE-3340) Make TUMBLE be accepted as an operand for "FROM TABLE()" in validator

2019-09-19 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933642#comment-16933642 ] Rui Wang commented on CALCITE-3340: --- [~julianhyde] Regarding to one point you mentioned before:

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934044#comment-16934044 ] Feng Zhu commented on CALCITE-3224: --- [~jinxing6...@126.com]Yeah, it is used to mark whether the value

[jira] [Resolved] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3360. - Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933971#comment-16933971 ] Chunwei Lei commented on CALCITE-3360: -- Just a little confused. What does {{NEP}} mean? Or it is

[jira] [Updated] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3360: Summary: SqlValidator throws NPE for unregistered function without implicit type coercion

[jira] [Commented] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934033#comment-16934033 ] Danny Chan commented on CALCITE-3360: - Oh, thanks for correct, [~Chunwei Lei] ! > SqlValidator

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934061#comment-16934061 ] Danny Chan commented on CALCITE-3353: - Maybe we should give out a list of the rules that should not

[jira] [Commented] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934067#comment-16934067 ] Danny Chan commented on CALCITE-3352: - Indeed, but the ProjectToWindowRule can match physical

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1691#comment-1691 ] jin xing commented on CALCITE-3224: --- When you san – – "For each RexNode, the visitor will generally

[jira] [Commented] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan commented on CALCITE-3350: - Personally i'm curious about why the original `STRING`

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: -- Personally

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: -- Personally

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: -- Personally

[jira] [Assigned] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3355: Assignee: Chunwei Lei > Deduce whether CASE and COALESCE may produce NULL values >

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933972#comment-16933972 ] Chunwei Lei commented on CALCITE-3355: -- Thanks, [~kirillkozlov]. I can assign this issue to

[jira] [Comment Edited] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933953#comment-16933953 ] Danny Chan edited comment on CALCITE-3360 at 9/20/19 4:18 AM: -- Fixed in

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933854#comment-16933854 ] Haisheng Yuan commented on CALCITE-3353: [~jinxing6...@126.com] I agree with you. >

[jira] [Comment Edited] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933863#comment-16933863 ] Haisheng Yuan edited comment on CALCITE-3352 at 9/19/19 11:55 PM: -- You

[jira] [Commented] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933863#comment-16933863 ] Haisheng Yuan commented on CALCITE-3352: You mixing physical properties with logical operators.