[jira] [Commented] (CALCITE-2967) New rule to remove SemiJoin

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807684#comment-16807684 ] Danny Chan commented on CALCITE-2967: - What i'm curious about is after decorrelation, an in clause

[jira] [Assigned] (CALCITE-2967) New rule to remove SemiJoin

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2967: --- Assignee: Ruben Quesada Lopez (was: Danny Chan) > New rule to remove SemiJoin >

[jira] [Assigned] (CALCITE-2967) New rule to remove SemiJoin

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2967: --- Assignee: Danny Chan (was: Ruben Quesada Lopez) > New rule to remove SemiJoin >

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807720#comment-16807720 ] Danny Chan commented on CALCITE-2966: - [~julian.feinauer] Can you please give your complete code

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for subquery

2019-03-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806335#comment-16806335 ] Danny Chan commented on CALCITE-2948: - [~julianhyde] [~hyuan] [~vgarg] The value generator for the

[jira] [Created] (CALCITE-2966) Problem with Code Generation

2019-03-31 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-2966: --- Summary: Problem with Code Generation Key: CALCITE-2966 URL: https://issues.apache.org/jira/browse/CALCITE-2966 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-2914) Improve how LatticeSuggester deduces foreign keys

2019-03-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806348#comment-16806348 ] Danny Chan commented on CALCITE-2914: - [~julianhyde] Reviewing now. > Improve how LatticeSuggester

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808289#comment-16808289 ] Danny Chan commented on CALCITE-2966: - The commit is not that complete, i only see 2 files changed

[jira] [Commented] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797760#comment-16797760 ] Danny Chan commented on CALCITE-2928: - [~julianhyde] Yes, thx for your rely. I think there are 2

[jira] [Assigned] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for subquery

2019-03-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2948: --- Assignee: Danny Chan > SqlToRelConverter generates complicated logical plan for subquery

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for subquery

2019-03-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801282#comment-16801282 ] Danny Chan commented on CALCITE-2948: - [~hyuan] Hi, may i take this issue, i will take it if you

[jira] [Assigned] (CALCITE-2208) MaterializedViewTable.MATERIALIZATION_CONNECTION breaks lex and case sensitivity for end user

2019-03-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2208: --- Assignee: Danny Chan > MaterializedViewTable.MATERIALIZATION_CONNECTION breaks lex and

[jira] [Commented] (CALCITE-2208) MaterializedViewTable.MATERIALIZATION_CONNECTION breaks lex and case sensitivity for end user

2019-03-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801626#comment-16801626 ] Danny Chan commented on CALCITE-2208: - [~julianhyde] I have fixed this in

[jira] [Commented] (CALCITE-481) Add "Spool" operator, to allow re-use of relational expressions

2019-03-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801636#comment-16801636 ] Danny Chan commented on CALCITE-481: Cool topic, just found it first time, i would like to

[jira] [Commented] (CALCITE-2936) Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800380#comment-16800380 ] Danny Chan commented on CALCITE-2936: - So the MinRowCount and MaxRowCount are all estimated but

[jira] [Assigned] (CALCITE-2978) sorting not applied in subqueries

2019-04-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2978: --- Assignee: Danny Chan > sorting not applied in subqueries >

[jira] [Assigned] (CALCITE-2980) Implement the FORMAT clause of the CAST operator (added in SQL:2016)

2019-04-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2980: --- Assignee: Danny Chan > Implement the FORMAT clause of the CAST operator (added in

[jira] [Commented] (CALCITE-2980) Implement the FORMAT clause of the CAST operator (added in SQL:2016)

2019-04-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810460#comment-16810460 ] Danny Chan commented on CALCITE-2980: - [~julianhyde] I would like to take this issue. > Implement

[jira] [Updated] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Fix Version/s: 1.20.0 > Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join

[jira] [Assigned] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2744: --- Assignee: Danny Chan > Throws RuntimeException in RelDecorrelator when optimizing a

[jira] [Commented] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804543#comment-16804543 ] Danny Chan commented on CALCITE-2744: - It seems that it is an edge case that an agg function can

[jira] [Updated] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Fix Version/s: (was: 1.20.0) > Throws RuntimeException in RelDecorrelator when optimizing a

[jira] [Closed] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan closed CALCITE-2744. --- Resolution: Won't Fix > Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804559#comment-16804559 ] Danny Chan commented on CALCITE-2960: - [~hhlai1990] I didn't found any method in calcite named 

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804578#comment-16804578 ] Danny Chan commented on CALCITE-2960: - Got your idea, it's weird that Calcite itself never use 

[jira] [Commented] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan commented on CALCITE-2928: - [~julianhyde] i have fire a

[jira] [Comment Edited] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan edited comment on CALCITE-2928 at 3/28/19 6:09 AM: --

[jira] [Comment Edited] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan edited comment on CALCITE-2928 at 3/28/19 6:08 AM: --

[jira] [Comment Edited] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan edited comment on CALCITE-2928 at 3/28/19 6:11 AM: --

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803618#comment-16803618 ] Danny Chan commented on CALCITE-2960: - I think it is part of issue 2928, and i have add link for

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803624#comment-16803624 ] Danny Chan commented on CALCITE-2960: - BTW, i never saw any case that Calcite use

[jira] [Assigned] (CALCITE-2969) Improve design of join-like relational expressions

2019-04-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2969: --- Assignee: Danny Chan > Improve design of join-like relational expressions >

[jira] [Assigned] (CALCITE-2981) Syntax error with simple nested select query

2019-04-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2981: --- Assignee: Danny Chan > Syntax error with simple nested select query >

[jira] [Commented] (CALCITE-2981) Syntax error with simple nested select query

2019-04-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812426#comment-16812426 ] Danny Chan commented on CALCITE-2981: - [~vamshi.v.kris...@gmail.com] Seems should not happen, i

[jira] [Commented] (CALCITE-2888) Enhance RexImplicationChecker to better handle filters with CAST

2019-03-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782279#comment-16782279 ] Danny Chan commented on CALCITE-2888: - Broadly, i am a little confused why you need to modify the

[jira] [Commented] (CALCITE-2900) RewriteRexShuttle generates wring type for structured type when visitInputRef

2019-03-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786310#comment-16786310 ] Danny Chan commented on CALCITE-2900: - What do you mean by structured columns, Calcite will parse

[jira] [Created] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-17 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-2928: --- Summary: Make UDF lookup default to case insensitive Key: CALCITE-2928 URL: https://issues.apache.org/jira/browse/CALCITE-2928 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-2927) The javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794666#comment-16794666 ] Danny Chan commented on CALCITE-2927: - It is not Sum{computeImportanceOfChild()} it is sum of its

[jira] [Comment Edited] (CALCITE-2927) The javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794666#comment-16794666 ] Danny Chan edited comment on CALCITE-2927 at 3/18/19 3:02 AM: -- It is not

[jira] [Closed] (CALCITE-2927) The javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan closed CALCITE-2927. --- Resolution: Not A Bug > The javadoc and implement of RuleQueue.computeImportance() is inconsistent

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794716#comment-16794716 ] Danny Chan commented on CALCITE-2904: - [~hyuan] Yeah, for calcite it throws error "Column 's2' not

[jira] [Commented] (CALCITE-2906) Record DOT extension does not distinguish between simple and compound identifiers

2019-03-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794651#comment-16794651 ] Danny Chan commented on CALCITE-2906: - [~walterddr] I tried to add the DOT.member_func grammar,but

[jira] [Assigned] (CALCITE-2913) add a KafkaAdapter for Stream

2019-03-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2913: --- Assignee: James Xu > add a KafkaAdapter for Stream > - > >

[jira] [Assigned] (CALCITE-2906) Record DOT extension does not distinguish between simple and compound identifiers

2019-03-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2906: --- Assignee: Danny Chan > Record DOT extension does not distinguish between simple and

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-03-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790307#comment-16790307 ] Danny Chan commented on CALCITE-2302: - Hi [~julianhyde] is there any possibility that this patch

[jira] [Commented] (CALCITE-2913) add a KafkaAdapter for Stream

2019-03-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790304#comment-16790304 ] Danny Chan commented on CALCITE-2913: - [~xumingming] Assign to you, good luck! > add a

[jira] [Assigned] (CALCITE-2302) Implicit type cast support

2019-03-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2302: --- Assignee: Danny Chan > Implicit type cast support > -- > >

[jira] [Assigned] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2904: --- Assignee: Danny Chan > Column not found in table when query contain duplicate table

[jira] [Commented] (CALCITE-2906) Record DOT extension does not distinguish between simple and compound identifiers

2019-03-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789112#comment-16789112 ] Danny Chan commented on CALCITE-2906: - Hi, [~walterddr], i would take this issue if you agree. >

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791490#comment-16791490 ] Danny Chan commented on CALCITE-2904: - I tried to fix but the whole resolve logic seems only

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791487#comment-16791487 ] Danny Chan commented on CALCITE-2904: - Hi [~julianhyde] [~hyuan], i debug and check the reason, it

[jira] [Commented] (CALCITE-2907) AggregateExpandDistinctAggregatesRule produces a wrong relational algebra

2019-03-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789340#comment-16789340 ] Danny Chan commented on CALCITE-2907: - I would take this issue ASAP, hope to help you. >

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796912#comment-16796912 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] It seems that the error does not has any

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796923#comment-16796923 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] Sorry, my fault, all my test cases throw

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797138#comment-16797138 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] I have found the reason, it is because in

[jira] [Created] (CALCITE-2938) Druid adapter do wrong behavior for casts from timestamp type to date type

2019-03-20 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-2938: --- Summary: Druid adapter do wrong behavior for casts from timestamp type to date type Key: CALCITE-2938 URL: https://issues.apache.org/jira/browse/CALCITE-2938 Project:

[jira] [Commented] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795601#comment-16795601 ] Danny Chan commented on CALCITE-2928: - [~julianhyde] I found these docs: 1. MYSQL [1] 2.

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795766#comment-16795766 ] Danny Chan commented on CALCITE-2929: - [~kgyrtkirk] Now Calcite does not support implicit type

[jira] [Commented] (CALCITE-2906) Record DOT extension does not distinguish between simple and compound identifiers

2019-03-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795759#comment-16795759 ] Danny Chan commented on CALCITE-2906: - [~walterddr] Yeah, my understanding is same with you, we

[jira] [Assigned] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2933: --- Assignee: Danny Chan > In Druid adapter, expression like "cast(cast(\"timestamp\" as

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795777#comment-16795777 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] May i take this issue, i would fix this if

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796059#comment-16796059 ] Danny Chan commented on CALCITE-2929: - [~kgyrtkirk] I definitely agree that {code:java} select

[jira] [Commented] (CALCITE-2924) build calcite error

2019-03-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794082#comment-16794082 ] Danny Chan commented on CALCITE-2924: - The log says `The forked VM terminated without properly

[jira] [Commented] (CALCITE-2921) nullif(null,y) throws exception in verification

2019-03-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794114#comment-16794114 ] Danny Chan commented on CALCITE-2921: - [~julianhyde] I have tried NULLIF(CAST(NULL AS INTEGER), y)

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794115#comment-16794115 ] Danny Chan commented on CALCITE-2904: - [~julianhyde] Sorry, i didn't find any sql standard for the

[jira] [Commented] (CALCITE-2923) MAX_DATETIME_PRECISION limitation

2019-03-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794100#comment-16794100 ] Danny Chan commented on CALCITE-2923: - In SqlAbstractTimeFunction, you can see the usage of

[jira] [Assigned] (CALCITE-2923) MAX_DATETIME_PRECISION limitation

2019-03-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2923: --- Assignee: Danny Chan > MAX_DATETIME_PRECISION limitation >

[jira] [Commented] (CALCITE-2914) Improve how LatticeSuggester deduces foreign keys

2019-03-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794116#comment-16794116 ] Danny Chan commented on CALCITE-2914: - [~julianhyde] , may i take this issue ? > Improve how

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788829#comment-16788829 ] Danny Chan commented on CALCITE-2904: - [~hyuan] Seems a bug, i will fix this and apply a patch if

[jira] [Commented] (CALCITE-2004) The TableFunction left outer join was improperly translated

2019-03-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788827#comment-16788827 ] Danny Chan commented on CALCITE-2004: - [~hyuan] I will review this patch for you. > The

[jira] [Commented] (CALCITE-2939) NPE Array Type serialToJdbc in TypedValue when executeBatch

2019-03-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798176#comment-16798176 ] Danny Chan commented on CALCITE-2939: - [~shining] Hi, i would like to take this issue if you agree,

[jira] [Assigned] (CALCITE-2939) NPE Array Type serialToJdbc in TypedValue when executeBatch

2019-03-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2939: --- Assignee: Danny Chan > NPE Array Type serialToJdbc in TypedValue when executeBatch >

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816077#comment-16816077 ] Danny Chan commented on CALCITE-2992: - I don't think it's a good idea to coerce type int (long) to

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816096#comment-16816096 ] Danny Chan commented on CALCITE-2986: - [~vgarg] Agree with you that the semi join should not only

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816069#comment-16816069 ] Danny Chan commented on CALCITE-2973: - Hi, [~hhlai1990], i think this issue has strong association

[jira] [Commented] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2019-04-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817500#comment-16817500 ] Danny Chan commented on CALCITE-2997: - So in what scene you must rely on the logical plan exactly ?

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817510#comment-16817510 ] Danny Chan commented on CALCITE-2966: - [~julian.feinauer] I have got the reason, for PREV($UP.x,

[jira] [Comment Edited] (CALCITE-2966) Problem with Code Generation

2019-04-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817510#comment-16817510 ] Danny Chan edited comment on CALCITE-2966 at 4/15/19 2:48 AM: --

[jira] [Commented] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817806#comment-16817806 ] Danny Chan commented on CALCITE-2999: - I'm not that sure until i'm fixing, but the plan is wrong

[jira] [Assigned] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2999: --- Assignee: Danny Chan > Can't get the right column value in LogicalSort >

[jira] [Commented] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817655#comment-16817655 ] Danny Chan commented on CALCITE-2999: - I checked sql-standard 2011 and the sort specification list

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816213#comment-16816213 ] Danny Chan commented on CALCITE-2966: - [~julian.feinauer] I would check this soon, i'm so sorry

[jira] [Commented] (CALCITE-3002) Case statement fails with: SqlValidatorException: Cannot apply '=' to arguments of type ' = '.

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818600#comment-16818600 ] Danny Chan commented on CALCITE-3002: - It's true that now Calcite does not support implicit type

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820661#comment-16820661 ] Danny Chan commented on CALCITE-2948: - [~vvysotskyi] The aggregate group set keys are already added

[jira] [Commented] (CALCITE-1624) Inefficient plan for NOT IN correlated subqueries

2019-04-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820788#comment-16820788 ] Danny Chan commented on CALCITE-1624: - [~vgarg] may i take this issue ? i would take it if you

[jira] [Updated] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2948: Summary: SqlToRelConverter generates complicated logical plan for in subquery with non-equi

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821049#comment-16821049 ] Danny Chan commented on CALCITE-2282: - [~zhztheplayer] The parser has a hard code SqlStdOperator

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819916#comment-16819916 ] Danny Chan commented on CALCITE-2948: - Hi [~hyuan] [~zabetak] [~julianhyde] [~vgarg]  I have

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817165#comment-16817165 ] Danny Chan edited comment on CALCITE-2986 at 4/14/19 2:22 AM: -- {quote}I am

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817165#comment-16817165 ] Danny Chan commented on CALCITE-2986: - >I am not sure how this will work. Can you provide few

[jira] [Commented] (CALCITE-2204) Volcano Planner may not choose the cheapest cost plan

2019-04-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817167#comment-16817167 ] Danny Chan commented on CALCITE-2204: - There are many problems that are addressed in CALCITE-2018,

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816820#comment-16816820 ] Danny Chan commented on CALCITE-2969: - [~hyuan] I also think so, so for the first PR, i almost

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816817#comment-16816817 ] Danny Chan edited comment on CALCITE-2986 at 4/13/19 3:34 AM: -- {quote}IN

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816817#comment-16816817 ] Danny Chan edited comment on CALCITE-2986 at 4/13/19 3:34 AM: --   {quote}IN

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816827#comment-16816827 ] Danny Chan commented on CALCITE-2966: - Sorry, i don't think there is any bug for the code snippet

[jira] [Comment Edited] (CALCITE-2966) Problem with Code Generation

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816827#comment-16816827 ] Danny Chan edited comment on CALCITE-2966 at 4/13/19 4:16 AM: -- Sorry, i

[jira] [Commented] (CALCITE-2974) Timestamp conversion performance can be improved

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816836#comment-16816836 ] Danny Chan commented on CALCITE-2974: - Well, i also think the code consistent is very important

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816817#comment-16816817 ] Danny Chan commented on CALCITE-2986: - >  IN corresponds to = and is rewritten using LEFT OUTER

[jira] [Commented] (CALCITE-2994) Least restrictive type among structs does not consider nullability

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816837#comment-16816837 ] Danny Chan commented on CALCITE-2994: - The current code already consider structured type [1], so

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841856#comment-16841856 ] Danny Chan commented on CALCITE-3065: - [~Aron.tao] I don't know where your plan comes from, but for

  1   2   3   4   5   6   >