[jira] [Commented] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2019-04-15 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817584#comment-16817584 ] jin xing commented on CALCITE-2997: --- THX a lot for comments ~Chunwei and ~Danny, Our internal

[jira] [Created] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2019-04-14 Thread jin xing (JIRA)
jin xing created CALCITE-2997: - Summary: Avoid pushing down join condition in SqlToRelConverter Key: CALCITE-2997 URL: https://issues.apache.org/jira/browse/CALCITE-2997 Project: Calcite Issue

[jira] [Updated] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2019-04-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-2997: -- Description: In current code, *SqlToRelConverter:createJoin* is calling

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-03 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877833#comment-16877833 ] jin xing commented on CALCITE-3167: --- Thanks a lot for reply [~julianhyde] # I also think it's a good

[jira] [Comment Edited] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-03 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877833#comment-16877833 ] jin xing edited comment on CALCITE-3167 at 7/3/19 1:28 PM: --- Thanks a lot for

[jira] [Updated] (CALCITE-3197) Convert data of Timestamp/Time/Date as original form when enumerating from ArrayTable

2019-07-13 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3197: -- Description: In current implementation ColumnLoader, data of

[jira] [Created] (CALCITE-3197) Convert data of Timestamp/Time/Date as original form when enumerating from ArrayTable

2019-07-13 Thread jin xing (JIRA)
jin xing created CALCITE-3197: - Summary: Convert data of Timestamp/Time/Date as original form when enumerating from ArrayTable Key: CALCITE-3197 URL: https://issues.apache.org/jira/browse/CALCITE-3197

[jira] [Comment Edited] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-09 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880958#comment-16880958 ] jin xing edited comment on CALCITE-3113 at 7/9/19 6:11 AM: --- In SQLs below,

[jira] [Commented] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-09 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880958#comment-16880958 ] jin xing commented on CALCITE-3113: --- In SQLs below, Aggregations operator in both materialization and

[jira] [Comment Edited] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-09 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881286#comment-16881286 ] jin xing edited comment on CALCITE-3113 at 7/9/19 3:02 PM: --- I made a PR

[jira] [Commented] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-09 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881286#comment-16881286 ] jin xing commented on CALCITE-3113: --- I made a PR to illustrate my idea, I'm not sure it's as your

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-03 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878284#comment-16878284 ] jin xing commented on CALCITE-3167: --- [~amargoor]  Gentle ping~ It's great if you can share some

[jira] [Created] (CALCITE-3167) Remove redundant overriding methods of equals in EnumerableTableScan.java

2019-07-02 Thread jin xing (JIRA)
jin xing created CALCITE-3167: - Summary: Remove redundant overriding methods of equals in EnumerableTableScan.java Key: CALCITE-3167 URL: https://issues.apache.org/jira/browse/CALCITE-3167 Project:

[jira] [Updated] (CALCITE-3167) Remove redundant overriding methods of equals in EnumerableTableScan.java

2019-07-02 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3167: -- Description: In current code of EnumerableTableScan.java, methods of equals are overrided for

[jira] [Assigned] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-13 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3167: - Assignee: jin xing > Remove overriding equals and hashCode methods in EnumerableTableScan >

[jira] [Assigned] (CALCITE-3203) When matching materializations, match Project with child of Aggregate

2019-08-13 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3203: - Assignee: jin xing > When matching materializations, match Project with child of Aggregate >

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-13 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906823#comment-16906823 ] jin xing commented on CALCITE-3167: --- [~julianhyde] Gentle ping ~ In current change, I made

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906923#comment-16906923 ] jin xing commented on CALCITE-3167: --- [~julianhyde] Thanks a lot for approve. I updated the patch

[jira] [Updated] (CALCITE-3249) Substitution#getRexShuttle does not consider RexLiteral

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3249: -- Description: Current {{Substitution#getRexShuttle}} does not take {{RexLiteral}} into

[jira] [Updated] (CALCITE-3249) Substitution#getRexShuttle does not consider RexLiteral

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3249: -- Description: Current {{Substitution#getRexShuttle}} does not take {{RexLiteral}} into

[jira] [Created] (CALCITE-3249) Substitution#getRexShuttle does not consider RexLiteral

2019-08-14 Thread jin xing (JIRA)
jin xing created CALCITE-3249: - Summary: Substitution#getRexShuttle does not consider RexLiteral Key: CALCITE-3249 URL: https://issues.apache.org/jira/browse/CALCITE-3249 Project: Calcite Issue

[jira] [Commented] (CALCITE-3211) List of MutableRel may fail to be identified by SubstitutionVisitor during matching

2019-07-29 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895748#comment-16895748 ] jin xing commented on CALCITE-3211: --- Thanks a lot [~julianhyde] "People should not call

[jira] [Updated] (CALCITE-3211) MutableRel returned from MutableRels::toMutables may fail to be identified by SubstitutionVisitor during matching

2019-07-29 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3211: -- Issue Type: Improvement (was: Bug) > MutableRel returned from MutableRels::toMutables may fail to

[jira] [Updated] (CALCITE-3211) List of MutableRel may fail to be identified by SubstitutionVisitor during matching

2019-07-29 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3211: -- Summary: List of MutableRel may fail to be identified by SubstitutionVisitor during matching (was:

[jira] [Updated] (CALCITE-3211) MutableRel returned from MutableRels::toMutables may fail to be identified by SubstitutionVisitor during matching

2019-07-29 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3211: -- Issue Type: Bug (was: Improvement) > MutableRel returned from MutableRels::toMutables may fail to

[jira] [Comment Edited] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899594#comment-16899594 ] jin xing edited comment on CALCITE-3228 at 8/4/19 9:33 AM: ---

[jira] [Updated] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3228: -- Attachment: CALCITE-3228.patch > Error while applying rule ProjectScanRule: interpreter >

[jira] [Comment Edited] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899594#comment-16899594 ] jin xing edited comment on CALCITE-3228 at 8/4/19 9:28 AM: ---

[jira] [Commented] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899594#comment-16899594 ] jin xing commented on CALCITE-3228: --- [^CALCITE-3228.patch] Hi [~Chunwei Lei] I try to dig and learn

[jira] [Created] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-16 Thread jin xing (JIRA)
jin xing created CALCITE-3256: - Summary: Add ProjectOnProjectToProjectUnifyRule for materialization matching. Key: CALCITE-3256 URL: https://issues.apache.org/jira/browse/CALCITE-3256 Project: Calcite

[jira] [Assigned] (CALCITE-3251) BinaryExpression evaluate method support Long type.

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3251: - Assignee: jin xing > BinaryExpression evaluate method support Long type. >

[jira] [Assigned] (CALCITE-3251) BinaryExpression evaluate method support Long type.

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3251: - Assignee: (was: jin xing) > BinaryExpression evaluate method support Long type. >

[jira] [Updated] (CALCITE-3251) BinaryExpression evaluate method support Long type.

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3251: -- Issue Type: Bug (was: Wish) > BinaryExpression evaluate method support Long type. >

[jira] [Created] (CALCITE-3262) Refine doc of SubstitutionVisitor.java

2019-08-18 Thread jin xing (JIRA)
jin xing created CALCITE-3262: - Summary: Refine doc of SubstitutionVisitor.java Key: CALCITE-3262 URL: https://issues.apache.org/jira/browse/CALCITE-3262 Project: Calcite Issue Type: Improvement

[jira] [Updated] (CALCITE-3262) Refine doc of SubstitutionVisitor.java

2019-08-18 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3262: -- Description: Current doc of {{SubstitutionVisitor.java}} says the supported core relational

[jira] [Assigned] (CALCITE-3223) Non-RexInputRef may fails the matching of FilterToProjectUnifyRule during 'invert' by mistake.

2019-08-12 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3223: - Assignee: jin xing > Non-RexInputRef may fails the matching of FilterToProjectUnifyRule

[jira] [Assigned] (CALCITE-3214) Add UnionToUnionRule for materialization matching

2019-08-12 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3214: - Assignee: jin xing > Add UnionToUnionRule for materialization matching >

[jira] [Created] (CALCITE-3239) Calc#accept(RexShuttle shuttle) does not update rowType

2019-08-11 Thread jin xing (JIRA)
jin xing created CALCITE-3239: - Summary: Calc#accept(RexShuttle shuttle) does not update rowType Key: CALCITE-3239 URL: https://issues.apache.org/jira/browse/CALCITE-3239 Project: Calcite Issue

[jira] [Assigned] (CALCITE-3239) Calc#accept(RexShuttle shuttle) does not update rowType

2019-08-11 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3239: - Assignee: jin xing > Calc#accept(RexShuttle shuttle) does not update rowType >

[jira] [Comment Edited] (CALCITE-3226) RelBuilder doesn't keep the alias when scan from an expanded view

2019-08-16 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909567#comment-16909567 ] jin xing edited comment on CALCITE-3226 at 8/17/19 4:06 AM: Thanks a lot

[jira] [Commented] (CALCITE-3226) RelBuilder doesn't keep the alias when scan from an expanded view

2019-08-16 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909567#comment-16909567 ] jin xing commented on CALCITE-3226: --- Thanks a lot for clarify [~rubenql] I think [~julianhyde]

[jira] [Assigned] (CALCITE-3226) RelBuilder doesn't keep the alias when scan from an expanded view

2019-08-16 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3226: - Assignee: jin xing > RelBuilder doesn't keep the alias when scan from an expanded view >

[jira] [Updated] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3256: -- Description: This issue proposes to add a rule to match a project {code:java} MV: select deptno,

[jira] [Updated] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3256: -- Parent: CALCITE-3273 Issue Type: Sub-task (was: Improvement) > Add

[jira] [Created] (CALCITE-3276) Add MV rules to match Join on compensating Project(s)

2019-08-21 Thread jin xing (Jira)
jin xing created CALCITE-3276: - Summary: Add MV rules to match Join on compensating Project(s) Key: CALCITE-3276 URL: https://issues.apache.org/jira/browse/CALCITE-3276 Project: Calcite Issue

[jira] [Resolved] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing resolved CALCITE-3167. --- Resolution: Fixed > Remove overriding equals and hashCode methods in EnumerableTableScan >

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911878#comment-16911878 ] jin xing commented on CALCITE-3167: --- Fixed in

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911877#comment-16911877 ] jin xing commented on CALCITE-3167: --- [~julianhyde] Thanks a lot for merging ! > Remove overriding

[jira] [Updated] (CALCITE-3273) Materialization matching rules that consider compensating MutableProject

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3273: -- Description: In current implementation of rules in SubstitutionVisitor.java &

[jira] [Updated] (CALCITE-3274) Add FilterOnProjectToFilterUnifyRule for materialization matching

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3274: -- Description: With current implementation of MV matching, below case fails {code:java} @Test

[jira] [Assigned] (CALCITE-3274) Add FilterOnProjectToFilterUnifyRule for materialization matching

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3274: - Assignee: jin xing > Add FilterOnProjectToFilterUnifyRule for materialization matching >

[jira] [Created] (CALCITE-3273) Materialization matching rules that consider compensating MutableProject

2019-08-20 Thread jin xing (Jira)
jin xing created CALCITE-3273: - Summary: Materialization matching rules that consider compensating MutableProject Key: CALCITE-3273 URL: https://issues.apache.org/jira/browse/CALCITE-3273 Project:

[jira] [Updated] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3256: -- Description: In current code, below matching fails: {code:java} MV: select deptno, sum(salary) + 2,

[jira] [Created] (CALCITE-3274) Add FilterOnProjectToFilterUnifyRule for materialization matching

2019-08-20 Thread jin xing (Jira)
jin xing created CALCITE-3274: - Summary: Add FilterOnProjectToFilterUnifyRule for materialization matching Key: CALCITE-3274 URL: https://issues.apache.org/jira/browse/CALCITE-3274 Project: Calcite

[jira] [Updated] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-21 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3256: -- Priority: Major (was: Minor) > Add ProjectOnProjectToProjectUnifyRule for materialization matching.

[jira] [Updated] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3256: -- Description: In current code, below matching fails: {code:java} MV: select deptno, sum(salary) + 2,

[jira] [Updated] (CALCITE-3256) Add ProjectOnProjectToProjectUnifyRule for materialization matching.

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3256: -- Description: In current code, below matching fails: {code:java} MV: select deptno, sum(salary) + 2,

[jira] [Commented] (CALCITE-3273) Materialization matching rules that consider compensating MutableProject

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911945#comment-16911945 ] jin xing commented on CALCITE-3273: --- As far as I know, {{AggregateOnProjectToAggregateUnifyRule}} is

[jira] [Updated] (CALCITE-3274) Add FilterOnProjectToFilterUnifyRule for materialization matching

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3274: -- Description: With current implementation of MV matching, below case fails {code:java} @Test

[jira] [Updated] (CALCITE-3276) Add MV rules to match Join on compensating Project(s)

2019-08-21 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3276: -- Description: This issue proposes to handle cases where query and target are {{MutableJoin}}s and

[jira] [Updated] (CALCITE-3276) Add MV rules to match Join on compensating Project(s)

2019-08-21 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3276: -- Description: This issue proposes to handle cases where query and target are {{MutableJoin}}s and

[jira] [Commented] (CALCITE-2592) EnumerableMergeJoin is never taken

2019-09-02 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921118#comment-16921118 ] jin xing commented on CALCITE-2592: --- [~vladimirsitnikov] I made a fix in 

[jira] [Commented] (CALCITE-3301) View test when it occur java.lang.AssertionError

2019-08-28 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917752#comment-16917752 ] jin xing commented on CALCITE-3301: --- Hi [~Water Cut Off] , Usually we talk about such issues on the

[jira] [Commented] (CALCITE-3292) SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting SqlUpdate.

2019-08-25 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915492#comment-16915492 ] jin xing commented on CALCITE-3292: --- If I understand correctly, there's no need to do

[jira] [Updated] (CALCITE-3292) SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting SqlUpdate.

2019-08-25 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3292: -- Description: Current code fails below test {code:java} // code placeholder @Test public void

[jira] [Created] (CALCITE-3292) SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting SqlUpdate.

2019-08-25 Thread jin xing (Jira)
jin xing created CALCITE-3292: - Summary: SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting SqlUpdate. Key: CALCITE-3292 URL: https://issues.apache.org/jira/browse/CALCITE-3292

[jira] [Updated] (CALCITE-3276) Add MV rules to match Join on compensating Project(s)

2019-08-21 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3276: -- Description: This issue proposes to handle cases where query and target are *Join*s and query has

[jira] [Assigned] (CALCITE-3276) Add MV rules to match Join on compensating Project(s)

2019-08-21 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing reassigned CALCITE-3276: - Assignee: jin xing > Add MV rules to match Join on compensating Project(s) >

[jira] [Commented] (CALCITE-3338) Error with executeBatch and preparedStatement.

2019-09-12 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928408#comment-16928408 ] jin xing commented on CALCITE-3338: --- Yes, the parameter values are not passed into

[jira] [Commented] (CALCITE-3338) Error with executeBatch and preparedStatement.

2019-09-12 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928416#comment-16928416 ] jin xing commented on CALCITE-3338: --- CodeGen as below: {code:java} // code placeholder

[jira] [Comment Edited] (CALCITE-3338) Error with executeBatch and preparedStatement.

2019-09-12 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928416#comment-16928416 ] jin xing edited comment on CALCITE-3338 at 9/12/19 9:55 AM: CodeGen as

[jira] [Commented] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-10 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926461#comment-16926461 ] jin xing commented on CALCITE-3332: --- Thanks ~ [~donnyzone] I left minor comments on the PR and

[jira] [Created] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
jin xing created CALCITE-3334: - Summary: Refinement for Substitution-Based MV Matching Key: CALCITE-3334 URL: https://issues.apache.org/jira/browse/CALCITE-3334 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925666#comment-16925666 ] jin xing commented on CALCITE-3334: --- I have a commit to illustrate the idea shown in the design doc:

[jira] [Comment Edited] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925666#comment-16925666 ] jin xing edited comment on CALCITE-3334 at 9/9/19 1:05 PM: --- I have a commit

[jira] [Updated] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3334: -- Description: The approach of substitution-based MV matching is an effective way for its simplicity

[jira] [Updated] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3334: -- Description: The approach of substitution is an effective way for its simplicity and extensibility. 

[jira] [Updated] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3334: -- Description: The approach of substitution is an effective way for its simplicity and extensibility. 

[jira] [Comment Edited] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-11 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925666#comment-16925666 ] jin xing edited comment on CALCITE-3334 at 9/11/19 9:46 AM: I have a commit

[jira] [Comment Edited] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925666#comment-16925666 ] jin xing edited comment on CALCITE-3334 at 9/9/19 1:30 PM: --- I have a commit

[jira] [Comment Edited] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925666#comment-16925666 ] jin xing edited comment on CALCITE-3334 at 9/9/19 1:30 PM: --- I have a commit

[jira] [Commented] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-09 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925686#comment-16925686 ] jin xing commented on CALCITE-3334: --- Really hope committers or any people who have interests to leave

[jira] [Updated] (CALCITE-3357) Trivial null checking in RelSet#addAbstractConverters

2019-09-17 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3357: -- Description: In current code of *RelSet#addAbstractConverters*, null checking of *curRelTrait*

[jira] [Updated] (CALCITE-3357) Trivial null checking in RelSet#addAbstractConverters

2019-09-17 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3357: -- Description: In current code of *RelSet#addAbstractConverters*, null checking of *curRelTrait*

[jira] [Created] (CALCITE-3357) Trivial null checking in RelSet#addAbstractConverters

2019-09-17 Thread jin xing (Jira)
jin xing created CALCITE-3357: - Summary: Trivial null checking in RelSet#addAbstractConverters Key: CALCITE-3357 URL: https://issues.apache.org/jira/browse/CALCITE-3357 Project: Calcite Issue

[jira] [Commented] (CALCITE-3334) Refinement for Substitution-Based MV Matching

2019-09-16 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930535#comment-16930535 ] jin xing commented on CALCITE-3334: --- Thanks for comment [~lishuming] I raised a PR as above and

[jira] [Comment Edited] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match SEMI/ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933093#comment-16933093 ] jin xing edited comment on CALCITE-3363 at 9/19/19 6:25 AM: Check my PR

[jira] [Commented] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match SEMI/ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933093#comment-16933093 ] jin xing commented on CALCITE-3363: --- Check my PR please; For sql like below: select r1.sal from emp

[jira] [Updated] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3363: -- Summary: JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join (was:

[jira] [Updated] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match ANTI Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3363: -- Description: JoinUnionTransposeRule works by pull up union from below to top of join. Thus it should

[jira] [Created] (CALCITE-3363) JoinUnionTransposeRule.RIGHT_UNION should not match SEMI/ANTI Join

2019-09-18 Thread jin xing (Jira)
jin xing created CALCITE-3363: - Summary: JoinUnionTransposeRule.RIGHT_UNION should not match SEMI/ANTI Join Key: CALCITE-3363 URL: https://issues.apache.org/jira/browse/CALCITE-3363 Project: Calcite

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933090#comment-16933090 ] jin xing commented on CALCITE-3353: --- [~danny0405] It sometime comes to me that it might make sense

[jira] [Updated] (CALCITE-3223) Non-RexInputRef may fails the matching of FilterToProjectUnifyRule during 'invert' by mistake.

2019-07-31 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3223: -- Description: In current code of

[jira] [Updated] (CALCITE-3223) Non-RexInputRef may fails the matching of FilterToProjectUnifyRule during 'invert' by mistake.

2019-07-31 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3223: -- Description: In current code of

[jira] [Created] (CALCITE-3223) Non-RexInputRef may fails the matching of FilterToProjectUnifyRule during 'invert' by mistake.

2019-07-31 Thread jin xing (JIRA)
jin xing created CALCITE-3223: - Summary: Non-RexInputRef may fails the matching of FilterToProjectUnifyRule during 'invert' by mistake. Key: CALCITE-3223 URL: https://issues.apache.org/jira/browse/CALCITE-3223

[jira] [Created] (CALCITE-3226) RelBuilder doesn't keep the alias when scan from an expanded view

2019-08-02 Thread jin xing (JIRA)
jin xing created CALCITE-3226: - Summary: RelBuilder doesn't keep the alias when scan from an expanded view Key: CALCITE-3226 URL: https://issues.apache.org/jira/browse/CALCITE-3226 Project: Calcite

[jira] [Updated] (CALCITE-3226) RelBuilder doesn't keep the alias when scan from an expanded view

2019-08-02 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jin xing updated CALCITE-3226: -- Description: In current implementation of {{RelBuilder::scan}}

[jira] [Comment Edited] (CALCITE-3211) MutableRel returned from MutableRels::toMutables may fail to be identified by SubstitutionVisitor during matching

2019-07-28 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893336#comment-16893336 ] jin xing edited comment on CALCITE-3211 at 7/29/19 2:33 AM: [~julianhyde]

[jira] [Commented] (CALCITE-3226) RelBuilder doesn't keep the alias when scan from an expanded view

2019-08-06 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900713#comment-16900713 ] jin xing commented on CALCITE-3226: --- Thanks a lot for looking into this and sorry for late reply

[jira] [Created] (CALCITE-3203) When matching materializations, match Project with child of Aggregate

2019-07-20 Thread jin xing (JIRA)
jin xing created CALCITE-3203: - Summary: When matching materializations, match Project with child of Aggregate Key: CALCITE-3203 URL: https://issues.apache.org/jira/browse/CALCITE-3203 Project: Calcite

  1   2   3   >