[jira] [Comment Edited] (CALCITE-3260) Add support of evaluate method with default Evaluator.
[ https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911351#comment-16911351 ] Wang Yanlin edited comment on CALCITE-3260 at 8/20/19 1:31 PM: --- Well, then can we make class *Evaluator* public, so that, we can also be able to evaluate Expression directly. [~julianhyde] was (Author: yanlin-lynn): Well, then can we make class *Evaluator* public, so that, we can also be able to evaluate Expression directly. > Add support of evaluate method with default Evaluator. > -- > > Key: CALCITE-3260 > URL: https://issues.apache.org/jira/browse/CALCITE-3260 > Project: Calcite > Issue Type: New Feature >Reporter: Wang Yanlin >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently, the public method *evaluate* of AbstractNode need a Evaluator > object as parameter, but Evaluator class has default access control. This > limit the access of *evaluate* method. So may be we can add an overload > *evaluate* method with default Evaluator, thus, allow to evaluate Expression > directly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (CALCITE-3260) Add support of evaluate method with default Evaluator.
[ https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910706#comment-16910706 ] Julian Hyde edited comment on CALCITE-3260 at 8/19/19 7:57 PM: --- I don't think this is a good idea. The existing code is concise enough. With the new method, people will forget to pass in an evaluator. was (Author: julianhyde): -1 The existing code is concise enough. With the new method, people will forget to pass in an evaluator. > Add support of evaluate method with default Evaluator. > -- > > Key: CALCITE-3260 > URL: https://issues.apache.org/jira/browse/CALCITE-3260 > Project: Calcite > Issue Type: New Feature >Reporter: Wang Yanlin >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently, the public method *evaluate* of AbstractNode need a Evaluator > object as parameter, but Evaluator class has default access control. This > limit the access of *evaluate* method. So may be we can add an overload > *evaluate* method with default Evaluator, thus, allow to evaluate Expression > directly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
