[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176737#comment-17176737
]
Chunwei Lei commented on CALCITE-1581:
--
I am not sure whether it should use {{LogicalCorrelate
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168550#comment-17168550
]
Chunwei Lei commented on CALCITE-1581:
--
Opened a new PR[1] with some fix-ups.
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040656#comment-17040656
]
Danny Chen commented on CALCITE-1581:
-
Remove the fix version tag because it seems impossible to be
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984934#comment-16984934
]
pengzhiwei commented on CALCITE-1581:
-
Hi [~Chunwei Lei], sorry late for the response. I have fixed
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984209#comment-16984209
]
Chunwei Lei commented on CALCITE-1581:
--
[~pzw2018], could you please address comments from other
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938354#comment-16938354
]
pengzhiwei commented on CALCITE-1581:
-
Hi [~julianhyde], can you take a look at this pr again? I
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917387#comment-16917387
]
pengzhiwei commented on CALCITE-1581:
-
Thank [~julianhyde] and [~zabetak], I have fix the choice
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916892#comment-16916892
]
Julian Hyde commented on CALCITE-1581:
--
I looked into the causes of this choice conflict. With
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916569#comment-16916569
]
Stamatis Zampetakis commented on CALCITE-1581:
--
I was ready to merge this to master but I
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911931#comment-16911931
]
Chunwei Lei commented on CALCITE-1581:
--
I am +1 on the patch, overall. Thanks for the effort!
>
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908665#comment-16908665
]
pengzhiwei commented on CALCITE-1581:
-
Thanks very much for you review [~Chunwei Lei], I will fix
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908641#comment-16908641
]
Chunwei Lei commented on CALCITE-1581:
--
Hi [~pzw2018], I left some comments. Would you please take
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907079#comment-16907079
]
Chunwei Lei commented on CALCITE-1581:
--
[~zabetak], Sorry for the delay. I will review it this
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906962#comment-16906962
]
Stamatis Zampetakis commented on CALCITE-1581:
--
Hi [~Chunwei Lei], did you have the chance
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891652#comment-16891652
]
Chunwei Lei commented on CALCITE-1581:
--
Let us try best to make it in 1.21.0. I will spend some
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891429#comment-16891429
]
Stamatis Zampetakis commented on CALCITE-1581:
--
[~Chunwei Lei][~julianhyde] is this going
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855663#comment-16855663
]
pengzhiwei commented on CALCITE-1581:
-
Hi [~julianhyde],Thanks for you constructive suggestion. I
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854376#comment-16854376
]
Julian Hyde commented on CALCITE-1581:
--
Also, there are some potential interactions with other SQL
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854364#comment-16854364
]
Julian Hyde commented on CALCITE-1581:
--
At a high level it gets things right, but the code still
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851832#comment-16851832
]
Michael Mior commented on CALCITE-1581:
---
[~julianhyde] The changes look good to me, but do you
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808689#comment-16808689
]
pengzhiwei commented on CALCITE-1581:
-
Hi [~julianhyde], I have done the syntax validation in
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807398#comment-16807398
]
pengzhiwei commented on CALCITE-1581:
-
[~julianhyde], I agree with you that we can modify the
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807387#comment-16807387
]
Julian Hyde commented on CALCITE-1581:
--
bq. However,It cannot pass the validation in
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807386#comment-16807386
]
Julian Hyde commented on CALCITE-1581:
--
{{testJoinUsingDynamicTable}} creates a new tester and
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807385#comment-16807385
]
pengzhiwei commented on CALCITE-1581:
-
Hi [~julianhyde],Thanks for you review.
??That's a lot of
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807377#comment-16807377
]
Julian Hyde commented on CALCITE-1581:
--
Reviewing:
* The parser changes seem OK. Please add tests
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804052#comment-16804052
]
pengzhiwei commented on CALCITE-1581:
-
Hi [~julianhyde], I have make a pr
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721037#comment-16721037
]
Lai Zhou commented on CALCITE-1581:
---
[~julianhyde] , I extended the native enummerable implemention
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087805#comment-16087805
]
Julian Hyde commented on CALCITE-1581:
--
That would be great. But don't make a new PR; just add
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086709#comment-16086709
]
Sihua Zhou commented on CALCITE-1581:
-
[~julianhyde]Thanks for you review, i will modify the code
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086196#comment-16086196
]
Julian Hyde commented on CALCITE-1581:
--
Reviewing
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068081#comment-16068081
]
Sihua Zhou commented on CALCITE-1581:
-
[~julianhyde], I will contribute this, can you assign this
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065215#comment-16065215
]
Sihua Zhou commented on CALCITE-1581:
-
Hi, Julian Hyde:
If it's just for Hive-compatible
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860627#comment-15860627
]
Jianchao He commented on CALCITE-1581:
--
Thank you for your link
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858481#comment-15858481
]
Julian Hyde commented on CALCITE-1581:
--
Yes, LATERAL TABLE is the way to do it. Another option is
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858085#comment-15858085
]
Jianchao He commented on CALCITE-1581:
--
Hi, Julian, in Xiaoyong's video_stream analyze scenario,
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828640#comment-15828640
]
Julian Hyde commented on CALCITE-1581:
--
Ah, I understand. It is the same as [LINQ's SelectMany
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827594#comment-15827594
]
Xiaoyong Deng commented on CALCITE-1581:
Thanks, Julian.
My request is a stream compute
[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827455#comment-15827455
]
Julian Hyde commented on CALCITE-1581:
--
Good idea.
Let's implement this as two orthogonal
39 matches
Mail list logo