[jira] [Commented] (CALCITE-2003) Avoid global synchronization around openConnection in JdbcMeta
[
https://issues.apache.org/jira/browse/CALCITE-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197209#comment-16197209
]
ASF GitHub Bot commented on CALCITE-2003:
-
Github user asfgit closed the pull request at:
https://github.com/apache/calcite-avatica/pull/17
> Avoid global synchronization around openConnection in JdbcMeta
> --
>
> Key: CALCITE-2003
> URL: https://issues.apache.org/jira/browse/CALCITE-2003
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.11.0
>
>
> Had a report from a user where opening new connections to Avatica were stuck.
> Upon investigation, there was a single thread which had grabbed the local on
> the JdbcMeta instance in {{JdbcMeta#openConnection(ConnectionHandle)}}, but
> was not returning out of the {{DriverManager.getConnection(...)}} call.
> Using the {{ConcurrentMap}} API over the Guava {{Cache}} API gives us enough
> flexibility that we can handle this safely without the total synchronization.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CALCITE-2003) Avoid global synchronization around openConnection in JdbcMeta
[
https://issues.apache.org/jira/browse/CALCITE-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197204#comment-16197204
]
ASF GitHub Bot commented on CALCITE-2003:
-
Github user joshelser commented on the issue:
https://github.com/apache/calcite-avatica/pull/17
Ok, that is unrelated. We only have the failsafe-plugin configured to do
parallel tests in Avatica, not surefire-plugin too. Thanks for the suggestion
though, Kevin!
As I understand it, doing the `sudo: required` just increases the amount of
time it takes for tests to start running (the things it actually provides
aren't needed for Avatica). Given the relative low-velocity of commits to
Avatica, I think that's a fine tradeoff for stable test reports.
> Avoid global synchronization around openConnection in JdbcMeta
> --
>
> Key: CALCITE-2003
> URL: https://issues.apache.org/jira/browse/CALCITE-2003
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.11.0
>
>
> Had a report from a user where opening new connections to Avatica were stuck.
> Upon investigation, there was a single thread which had grabbed the local on
> the JdbcMeta instance in {{JdbcMeta#openConnection(ConnectionHandle)}}, but
> was not returning out of the {{DriverManager.getConnection(...)}} call.
> Using the {{ConcurrentMap}} API over the Guava {{Cache}} API gives us enough
> flexibility that we can handle this safely without the total synchronization.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CALCITE-2003) Avoid global synchronization around openConnection in JdbcMeta
[
https://issues.apache.org/jira/browse/CALCITE-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197191#comment-16197191
]
ASF GitHub Bot commented on CALCITE-2003:
-
Github user joshelser commented on the issue:
https://github.com/apache/calcite-avatica/pull/17
@risdenk no, I did miss that one! Let me try that quick. Otherwise, I'll
just leave the privileged=true tweak on since that "worked"
> Avoid global synchronization around openConnection in JdbcMeta
> --
>
> Key: CALCITE-2003
> URL: https://issues.apache.org/jira/browse/CALCITE-2003
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.11.0
>
>
> Had a report from a user where opening new connections to Avatica were stuck.
> Upon investigation, there was a single thread which had grabbed the local on
> the JdbcMeta instance in {{JdbcMeta#openConnection(ConnectionHandle)}}, but
> was not returning out of the {{DriverManager.getConnection(...)}} call.
> Using the {{ConcurrentMap}} API over the Guava {{Cache}} API gives us enough
> flexibility that we can handle this safely without the total synchronization.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CALCITE-2003) Avoid global synchronization around openConnection in JdbcMeta
[
https://issues.apache.org/jira/browse/CALCITE-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195560#comment-16195560
]
ASF GitHub Bot commented on CALCITE-2003:
-
Github user risdenk commented on the issue:
https://github.com/apache/calcite-avatica/pull/17
@joshelser Did you see https://github.com/apache/calcite/pull/542? Any
chance it is a surefire issue?
> Avoid global synchronization around openConnection in JdbcMeta
> --
>
> Key: CALCITE-2003
> URL: https://issues.apache.org/jira/browse/CALCITE-2003
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.11.0
>
>
> Had a report from a user where opening new connections to Avatica were stuck.
> Upon investigation, there was a single thread which had grabbed the local on
> the JdbcMeta instance in {{JdbcMeta#openConnection(ConnectionHandle)}}, but
> was not returning out of the {{DriverManager.getConnection(...)}} call.
> Using the {{ConcurrentMap}} API over the Guava {{Cache}} API gives us enough
> flexibility that we can handle this safely without the total synchronization.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
