[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-22 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373702#comment-16373702 ] Julian Hyde commented on CALCITE-2165: -- That sounds reasonable, provided you are also able to

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353263#comment-16353263 ] Dian Fu commented on CALCITE-2165: -- Hi [~julianhyde], I reconsidered the issue and think that when 

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353252#comment-16353252 ] Dian Fu commented on CALCITE-2165: -- I see. Thanks a lot for your comments. I will update the PR. >

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353247#comment-16353247 ] Julian Hyde commented on CALCITE-2165: -- I don't know. Each method must implement its specification.

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353245#comment-16353245 ] Dian Fu commented on CALCITE-2165: -- Thanks a lot for the suggestion. Do you mean that we should update 

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353236#comment-16353236 ] Julian Hyde commented on CALCITE-2165: -- Thanks for the test case. The problem is that

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353203#comment-16353203 ] Dian Fu commented on CALCITE-2165: -- We encountered an exception and it can be reproduced with the

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352785#comment-16352785 ] Julian Hyde commented on CALCITE-2165: -- An AssertionError means that there is a bug in the code, so

[jira] [Commented] (CALCITE-2165) SqlCallingBinding.getOperandLiteralValue should ignore AssertionError

2018-02-05 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352200#comment-16352200 ] Dian Fu commented on CALCITE-2165: -- Hi [~julianhyde],  I have created a PR, please help to review.