[jira] [Commented] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810473#comment-16810473 ] Haisheng Yuan commented on CALCITE-2754: Pushed to master https://github.com/apache/calcite/commit/bb4a0638260b6103994b14e1071eb679ae4bb5c2, thanks for the PR, [~Sergey Nuyanzin] and [~Chunwei Lei]! > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Chunwei Lei >Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807421#comment-16807421 ] Chunwei Lei commented on CALCITE-2754: -- I opened [PR#1142|[https://github.com/apache/calcite/pull/1142]] addressing all comments. Please feel free to close it if you still work on it. > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807357#comment-16807357 ] Chunwei Lei commented on CALCITE-2754: -- [~Sergey Nuyanzin], Any progress on this? I would like to finish it if you don't mind. > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786811#comment-16786811 ] Kevin Risden commented on CALCITE-2754: --- PR has feedback on it that hasn't been addressed since Jan. Changing fix version to 1.20.0 > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: 1.19.0 > > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2754) LISTAGG support
[
https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729803#comment-16729803
]
Julian Hyde commented on CALCITE-2754:
--
SQL:2016 will never be "publicly available". They always charge money for the
final spec. Nevertheless, it's safe to assume that Oracle's implementation is
close enough.
Review comments:
* In the doc, change "Return a string of concatenated values that are delimited
by a configurable separator" to "Returns values concatenated into a string,
delimited by *separator* (default ',')
* Add a test for LISTAGG applied to non-string values. (Is this supposed to
succeed or fail?)
* Add a test for LISTAGG applied to expressions. (If the previous test fails,
people will at least need {{LISTAGG(CAST(...))}} to work.)
* I don't think that LISTAGG needs to be a keyword.
> LISTAGG support
> ---
>
> Key: CALCITE-2754
> URL: https://issues.apache.org/jira/browse/CALCITE-2754
> Project: Calcite
> Issue Type: New Feature
> Components: core
>Affects Versions: 1.18.0
>Reporter: Sergey Nuyanzin
>Assignee: Sergey Nuyanzin
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
>
> Inspired by CALCITE-2224.
> There is an implementation of LISTAGG mentioned in description of CALCITE-2224
> Unfortunately there is no info about LISTAGG in public available SQL:2016
> draft at [1] while there is some description about LISTAGG as feature T625
> e.g.at [2]
> [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf
> [2] https://modern-sql.com/feature/listagg
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729459#comment-16729459 ] Sergey Nuyanzin commented on CALCITE-2754: -- Yes, but based on article The New and Improved SQL:2016 Standard at https://sigmodrecord.org/2018/10/19/the-new-and-improved-sql2016-standard/ LISTAGG is a part of SQL 2016 Standard. Or does it make sense to make LISTAGG as Oracle specific until SQL 2016 becomes public available? > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729444#comment-16729444 ] Julian Hyde commented on CALCITE-2754: -- As I noted in the other case, LISTAGG is oracle-specific. It is not in the SQL standard. I would not be surprised if other DBs support it. I notice that google BigQuery supports STRING_AGG, which is similar. > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
