[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100431#comment-17100431
]
Xiening Dai commented on CALCITE-2970:
--
Also the RelBuilder is not immutable today. The stack can
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100427#comment-17100427
]
Xiening Dai commented on CALCITE-2970:
--
{quote}
It's not about the overhead of object creation.
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100255#comment-17100255
]
Julian Hyde commented on CALCITE-2970:
--
It's not about the overhead of object creation.
Adding a
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100223#comment-17100223
]
Xiening Dai commented on CALCITE-2970:
--
It would have been easier if Java supports "const T &"
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099960#comment-17099960
]
Julian Hyde commented on CALCITE-2970:
--
Use fromContext. Context is straightforward and
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099490#comment-17099490
]
Xiening Dai commented on CALCITE-2970:
--
Will create a new JIRA.
{quote}
Struct's constructor
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099483#comment-17099483
]
Julian Hyde commented on CALCITE-2970:
--
Can we have a new JIRA case focused just on PR 1884? The
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099402#comment-17099402
]
Xiening Dai commented on CALCITE-2970:
--
I don't think we would ever put it into Calcite - it's a
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099398#comment-17099398
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Thanks for bearing with me [~xndai] :)
I
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099395#comment-17099395
]
Xiening Dai commented on CALCITE-2970:
--
{quote}Out of curiosity can you explain at which point you
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099388#comment-17099388
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Out of curiosity can you explain at which
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099212#comment-17099212
]
Xiening Dai commented on CALCITE-2970:
--
{quote}
The example outlined by Xiening Dai previously
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099182#comment-17099182
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Before talking about code that is not
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098245#comment-17098245
]
Xiening Dai commented on CALCITE-2970:
--
hi [~zabetak], if I understand correctly, if we want to
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098106#comment-17098106
]
Haisheng Yuan commented on CALCITE-2970:
{quote}
I was thinking that even the RelBuilderFactory
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098104#comment-17098104
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Thanks [~xndai] and [~julianhyde] for the
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097745#comment-17097745
]
Haisheng Yuan commented on CALCITE-2970:
Make sense. I am good with current change. It has been
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097033#comment-17097033
]
Julian Hyde commented on CALCITE-2970:
--
I take some of that back. I see that {{RelBuilder}} has a
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096896#comment-17096896
]
Julian Hyde commented on CALCITE-2970:
--
The other reason, besides handling sub-classes of
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095895#comment-17095895
]
Xiening Dai commented on CALCITE-2970:
--
Yes, the #1 point I mentioned. If there's a sub-class
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095888#comment-17095888
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Haha indeed [~hyuan] :)
Seeing the code,
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095582#comment-17095582
]
Haisheng Yuan commented on CALCITE-2970:
LOL. [~zabetak], we had the same thought:
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095539#comment-17095539
]
Stamatis Zampetakis commented on CALCITE-2970:
--
{{RelBuilderFactory}} seems to exactly the
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094955#comment-17094955
]
Haisheng Yuan commented on CALCITE-2970:
I am good the current change. [~julianhyde] Can you
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094107#comment-17094107
]
Xiening Dai commented on CALCITE-2970:
--
[~hyuan] [~julianhyde] I've updated the PR based on
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093856#comment-17093856
]
Julian Hyde commented on CALCITE-2970:
--
bq. Do you mean getRelBuilderTransform() is a lambda
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093850#comment-17093850
]
Julian Hyde commented on CALCITE-2970:
--
bq. Also sub-classing RelBuilder may not be a good idea,
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089171#comment-17089171
]
Xiening Dai commented on CALCITE-2970:
--
Hi [~julianhyde], I am not sure I understand. Do you mean
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088048#comment-17088048
]
Xiening Dai commented on CALCITE-2970:
--
Thanks [~hyuan] [~julianhyde]. I am working on the
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086038#comment-17086038
]
Julian Hyde commented on CALCITE-2970:
--
Probably it will work.
Sub-classing RelBuilder is a bad
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085348#comment-17085348
]
Haisheng Yuan commented on CALCITE-2970:
[~julianhyde] Will {{UnaryOperator
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085312#comment-17085312
]
Julian Hyde commented on CALCITE-2970:
--
Rather than {{RelBuilder getRelBuilder(RelOptCluster)}}
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085296#comment-17085296
]
Haisheng Yuan commented on CALCITE-2970:
Getting back to the physical RelBuilder pull request.
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077671#comment-17077671
]
Haisheng Yuan commented on CALCITE-2970:
We are off topic too much. I am OK to have a physical
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077668#comment-17077668
]
Xiening Dai commented on CALCITE-2970:
--
I think whether or not the implementation should/can do
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077565#comment-17077565
]
Julian Hyde commented on CALCITE-2970:
--
I don't think we need to choose a winner. Both processes
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077504#comment-17077504
]
Haisheng Yuan commented on CALCITE-2970:
[~julianhyde]I got what you mean. But if the Foo
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077497#comment-17077497
]
Julian Hyde commented on CALCITE-2970:
--
[~hyuan], That logical transformation is not possible,
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077486#comment-17077486
]
Xiening Dai commented on CALCITE-2970:
--
{quote}
Note that you can create a physical RelBulder by
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077481#comment-17077481
]
Haisheng Yuan commented on CALCITE-2970:
The creator of Foo convention should have its own
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077470#comment-17077470
]
Julian Hyde commented on CALCITE-2970:
--
What if the {{Foo}} convention has an implementation of
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077451#comment-17077451
]
Haisheng Yuan commented on CALCITE-2970:
{quote}
But physical rules do more than convert
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077437#comment-17077437
]
Julian Hyde commented on CALCITE-2970:
--
This case has been open for a year, and discussion has
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077434#comment-17077434
]
Julian Hyde commented on CALCITE-2970:
--
[~danny0405], You wrote:
bq. Modify the RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077429#comment-17077429
]
Julian Hyde commented on CALCITE-2970:
--
bq. RelBuilder should be used for logical operators only
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076938#comment-17076938
]
Haisheng Yuan commented on CALCITE-2970:
RelBuilder should be used for logical operators only,
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076923#comment-17076923
]
Xiening Dai commented on CALCITE-2970:
--
[~hyuan] I have to admit that your proposal would simply
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076893#comment-17076893
]
Xiening Dai commented on CALCITE-2970:
--
Thanks [~danny0405] for the feedback. My comments inline -
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076835#comment-17076835
]
Chunwei Lei commented on CALCITE-2970:
--
Agree with [~hyuan] and [~danny0405].
> Performance issue
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076829#comment-17076829
]
Danny Chen commented on CALCITE-2970:
-
Thanks [~xndai] for driving this ~
Some thoughts from my
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076753#comment-17076753
]
Haisheng Yuan commented on CALCITE-2970:
The by-product benefit of doing this is keeping
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076751#comment-17076751
]
Haisheng Yuan commented on CALCITE-2970:
{{changeTraitsUsingConverters()}} doesn't know what
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076710#comment-17076710
]
Xiening Dai commented on CALCITE-2970:
--
By the way, I am not re-inventing RelBuilder. I just
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076709#comment-17076709
]
Xiening Dai commented on CALCITE-2970:
--
Such interface already exists - which is the
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076705#comment-17076705
]
Haisheng Yuan commented on CALCITE-2970:
Now I don't think it is the good direction, it is
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069128#comment-17069128
]
Xiening Dai commented on CALCITE-2970:
--
[~hyuan][~zabetak][~julianhyde] I create a pull request
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062341#comment-17062341
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Nice idea [~hyuan]!! I didn't thoroughly
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062143#comment-17062143
]
Haisheng Yuan commented on CALCITE-2970:
It turned out after CALCITE-3753 removing rule match
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062027#comment-17062027
]
Xiening Dai commented on CALCITE-2970:
--
I am working on #2, will have a proposal soon.
>
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062019#comment-17062019
]
Haisheng Yuan commented on CALCITE-2970:
There are 3 issues:
1. too many abstract converters
2.
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977209#comment-16977209
]
Stamatis Zampetakis commented on CALCITE-2970:
--
In my mind I was thinking that if you have
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973551#comment-16973551
]
Xiening Dai commented on CALCITE-2970:
--
"Currently if we have 3 conventions we already have
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973125#comment-16973125
]
Stamatis Zampetakis commented on CALCITE-2970:
--
{quote}For example, if we have 3
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971834#comment-16971834
]
Xiening Dai commented on CALCITE-2970:
--
Currently ExpandConversionRule uses
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971265#comment-16971265
]
Danny Chen commented on CALCITE-2970:
-
In Flink, we also have such a expand rule to auto adapter
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971169#comment-16971169
]
Stamatis Zampetakis commented on CALCITE-2970:
--
[~hyuan] I think we are more or less
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970925#comment-16970925
]
Haisheng Yuan commented on CALCITE-2970:
Here is what we have done in MaxCompute. We have a
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970751#comment-16970751
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Let me try to sketch a bit what I have in
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968768#comment-16968768
]
Haisheng Yuan commented on CALCITE-2970:
Ah, that is similar with Julian's {{RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968766#comment-16968766
]
Haisheng Yuan commented on CALCITE-2970:
I feel like {{convention.getRelBuilder()}} is more
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968756#comment-16968756
]
Xiening Dai commented on CALCITE-2970:
--
Yes, that's fair. And I didn't propose to change copy() in
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968749#comment-16968749
]
Haisheng Yuan commented on CALCITE-2970:
With copy, you don't need to worry about what
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968747#comment-16968747
]
Xiening Dai commented on CALCITE-2970:
--
Yes, I agree withConvention or push/popConvention is
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968643#comment-16968643
]
Julian Hyde commented on CALCITE-2970:
--
If we added a {{Convention}} argument to {{sortLimit}} we
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968111#comment-16968111
]
Xiening Dai commented on CALCITE-2970:
--
Thanks [~zabetak]
I am not sure I understand the concern
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963783#comment-16963783
]
Stamatis Zampetakis commented on CALCITE-2970:
--
Thanks for the analysis [~xndai],
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962538#comment-16962538
]
Julian Hyde commented on CALCITE-2970:
--
bq. In order to achieve that, the framework would need to
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962014#comment-16962014
]
jin xing commented on CALCITE-2970:
---
[~xndai]
Thanks a lot for your kind help ~
Your commit is
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962007#comment-16962007
]
jin xing commented on CALCITE-2970:
---
[~zabetak] [~hyuan] Thanks a lot for your shepherd and sorry for
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961995#comment-16961995
]
jin xing commented on CALCITE-2970:
---
I migrate my PR description from github as below:
Currently
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961619#comment-16961619
]
Xiening Dai commented on CALCITE-2970:
--
I spent some time debugging this issue. I think I know
81 matches
Mail list logo
