[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-10 Thread Wang Yanlin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949061#comment-16949061 ] Wang Yanlin commented on CALCITE-3379: -- Agree that we need to validate both DDL and expression of

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-10 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948301#comment-16948301 ] Danny Chen commented on CALCITE-3379: - Finally i decide not to support a pure string column

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-10 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948295#comment-16948295 ] Danny Chen commented on CALCITE-3379: - Okey, got your idea, personally, i'm inclined to validate

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-10 Thread Wang Yanlin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948284#comment-16948284 ] Wang Yanlin commented on CALCITE-3379: -- it's *trims* not *trim*. Trim is valid, but trims is

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-10 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948269#comment-16948269 ] Danny Chen commented on CALCITE-3379: - > And exception occurs when trying to query the table.

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-10 Thread Wang Yanlin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948237#comment-16948237 ] Wang Yanlin commented on CALCITE-3379: -- Currently, this test case in *ServerTest* run success,

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948187#comment-16948187 ] Danny Chen commented on CALCITE-3379: - Yes, column expression need to be validated, this is

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-08 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946519#comment-16946519 ] jin xing commented on CALCITE-3379: --- As Danny explained by the first point, I have one concern – Do

[jira] [Commented] (CALCITE-3379) Support expand STRING column expression in table during sql-to-rel conversion

2019-10-07 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946450#comment-16946450 ] Danny Chen commented on CALCITE-3379: - [~julianhyde] [~hyuan],yes, the linked PR is not relevant