[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-20 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978665#comment-16978665 ] Xiening Dai commented on CALCITE-3503: -- I explained this before. The reason to create a new MQ

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-20 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978249#comment-16978249 ] Danny Chen commented on CALCITE-3503: - Thanks [~xndai] for the update PR ! But i still have some

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-19 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978162#comment-16978162 ] Stamatis Zampetakis commented on CALCITE-3503: -- Thanks [~danny0405] and [~xndai] for being

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-19 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977955#comment-16977955 ] Xiening Dai commented on CALCITE-3503: -- {quote}I don't think it is meaningless to do `isValid()`

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-17 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976221#comment-16976221 ] Danny Chen commented on CALCITE-3503: - I don't think it is meaningless to do `isValid()` check if

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-17 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976087#comment-16976087 ] Xiening Dai commented on CALCITE-3503: -- As I've mentioned multiple times, it's meaningless to do

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-16 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975940#comment-16975940 ] Stamatis Zampetakis commented on CALCITE-3503: -- Thanks [~xndai] and [~hyuan] for your

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-14 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974447#comment-16974447 ] Xiening Dai commented on CALCITE-3503: -- I have a PR out -

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-13 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973992#comment-16973992 ] Xiening Dai commented on CALCITE-3503: -- Adding a quick check would just fix it - if (root ==

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

2019-11-13 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973963#comment-16973963 ] Stamatis Zampetakis commented on CALCITE-3503: -- Below is the analysis of [~vlsi]  from the