[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151075#comment-15151075
]
Julian Hyde commented on CALCITE-553:
-
[~vlsi], Long term, I agree. And it might be easier now Freemarker are in the
Incubator.
Short term, I agree with [~elserj]'s proposal to make the default a little
slower, and to add a property that can be used by speed-freaks.
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151069#comment-15151069
]
Josh Elser commented on CALCITE-553:
Just updated the linked [PR|https://github.com/apache/calcite/pull/196].
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151063#comment-15151063
]
Vladimir Sitnikov commented on CALCITE-553:
---
[~julianhyde], I'm inclined to agree that forcing "mvn clean" and "mvn install"
separate might be a bit too unexpected, thus we might want to kill that
"optimization", and push freemaker to support incremental compilation better
(as in "do not owerwrite file if the contents is the same")
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150928#comment-15150928
]
Julian Hyde commented on CALCITE-553:
-
OK, let me know when you have a PR to review. [~vlsi], you might like to review
also, since you pushed for efficient builds in the first place.
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150816#comment-15150816
]
Josh Elser commented on CALCITE-553:
bq. Is the ! part of the property name? Or is there a maven convention I'm not
aware of. Seems that it might fall afoul of some shells.
This is a Maven feature. "!" is treated as the absence of that property on the
command line. So, for a profile with an activation of {{!foo}},
the profile would not run if the user added {{-Dfoo}} to their mvn invocation.
bq. How about having a property called 'generate' or 'skipGenerate' that
controls both generations?
Easy enough.
bq. Can you add an example of its usage to howto.md.
You read my mind. Will update this.
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146790#comment-15146790
]
Josh Elser commented on CALCITE-553:
bq. My hunch is that this has to do with how activeByDefault works in Maven,
but I'll prod things some more and put up a branch instead of directly pushing
next time.
Yup. That was it. {{activeByDefault}} only activates when no profiles are
activated by the user. So, with the {{it}} profile, it turned off these others.
Simple fix to just make them activated by the lack of a property specified by
the user at build time. Will open up a PR so we can vet this more before I
merge it in.
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146705#comment-15146705
]
Julian Hyde commented on CALCITE-553:
-
I backed out these changes in the force-push that fixed CALCITE-1046. Let's
carry on trying to fix this issue, but let's do it on a branch that can be
reviewed first.
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144077#comment-15144077
]
Josh Elser commented on CALCITE-553:
{{mvn clean verify}}
{noformat}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 05:16 min
[INFO] Finished at: 2016-02-12T00:10:05-05:00
[INFO] Final Memory: 79M/623M
[INFO]
{noformat}
{{mvn verify -P'!generate-parser,!generate-version-properties'}}
{noformat}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 04:24 min
[INFO] Finished at: 2016-02-12T00:17:07-05:00
[INFO] Final Memory: 49M/627M
[INFO]
{noformat}
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144021#comment-15144021
]
Josh Elser commented on CALCITE-553:
Alright, I have what I view as a fix here. We move away from the current broken
approach (broken, in the sense of what is expected of Maven projects), and move
the profiles that are necessary to make the incremental compilation stuff
working active by default with the ability to disable them. As such, this
should let those whom this is very important to still use benefit from it.
The following profiles can be disable on the command line to avoid the
re-generation {{generate-parser}} {{generate-version-properties}}. Or, in
context, {{mvn package -P'!generate-parser,!generate-version-properties'}}
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Josh Elser
> Fix For: next
>
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141012#comment-15141012
]
Josh Elser commented on CALCITE-553:
Oh, I think this is actually a Maven bug. The documentation definitely says
that this should work, and upgrading to 3.3.9 does fix it.
I will find the necessary minimum version to get this working and add a maven
min-version enforcer statement for this.
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Vladimir Sitnikov
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl
[
https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140408#comment-15140408
]
Josh Elser commented on CALCITE-553:
I think this is ultimately boiling down to the profile activation check
happening before the clean phase runs. The profile isn't activated because
core/target/generated-sources/fmpp/javacc/Parser.jj exists, the clean destroys
all of target, fmpp doesn't get re-run, and then the javacc plugin also skips
itself because its source directory (the fmpp output) doesn't exist.
I can understand the worth in trying to get incremental compliation and faster
builds, but it really bothers me when it comes at the cost of breaking the
expected semantics of the build tool. I'll see if there's some kind of trick I
can find to work around this, but, if I can't figure something out, I'm going
to suggest we remove the activation block (and run it all the time).
> "mvn clean install" fails due to missing SqlParserImpl
> --
>
> Key: CALCITE-553
> URL: https://issues.apache.org/jira/browse/CALCITE-553
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Vladimir Sitnikov
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42]
> cannot find symbol
> symbol: class SqlParserImpl
> location: package org.apache.calcite.sql.parser.impl
> [ERROR]
> /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50]
> cannot find symbol
> symbol: variable SqlParserImpl
> location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated
> correctly if at the start of the mvn command (before clean) the parser
> already exists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
