[jira] [Commented] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API
[
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509494#comment-15509494
]
Nicola Ferraro commented on CAMEL-10250:
Yes, I have a fix but still didn't push it to avoid confusion with the BOM
issue (all xmls changed because of small changes). I can merge it now.
> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
> Issue Type: Task
> Components: tooling
>Reporter: Claus Ibsen
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library /
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API
[
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509356#comment-15509356
]
Claus Ibsen commented on CAMEL-10250:
-
Nicola is this still the case? Wonder if you have time to fix this too, or
should we move this to 2.19 release?
> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
> Issue Type: Task
> Components: tooling
>Reporter: Claus Ibsen
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library /
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API
[
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430236#comment-15430236
]
Claus Ibsen commented on CAMEL-10250:
-
Nicola, wonder if we could use some other API so we dont use this internal one.
This likely causes problems on Java 9, and there must be some XML library that
can output XML with indent.
> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
> Issue Type: Task
> Components: tooling
>Reporter: Claus Ibsen
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library /
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API
[
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424180#comment-15424180
]
Claus Ibsen commented on CAMEL-10250:
-
We have a xml writer that supports indent here
https://github.com/fabric8io/fabric8-forge/blob/master/addons/utils/src/main/java/io/fabric8/forge/addon/utils/JaxbNoNamespaceWriter.java
And maybe the regular Transformer can do indent, not sure if you can control if
its 2 or 4
https://github.com/fabric8io/fabric8-forge/blob/master/addons/utils/src/main/java/io/fabric8/forge/addon/utils/XmlHelper.java#L39
> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
> Issue Type: Task
> Components: tooling
>Reporter: Claus Ibsen
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library /
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
> OutputFormat is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> [WARNING]
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
> XMLSerializer is internal proprietary API and may be removed in a future
> release
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
