[jira] [Commented] (CAMEL-10387) JMS correlationIdAsBytes should return null and not byte array with zero values

2016-10-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575406#comment-15575406
 ] 

ASF GitHub Bot commented on CAMEL-10387:


Github user guillaumeterral closed the pull request at:

https://github.com/apache/camel/pull/1212


> JMS correlationIdAsBytes should return null and not byte array with zero 
> values
> ---
>
> Key: CAMEL-10387
> URL: https://issues.apache.org/jira/browse/CAMEL-10387
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-jms
>Affects Versions: 2.18.0
>Reporter: Terral Guillaume
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.17.4, 2.18.1, 2.19.0
>
>
> When a JMS broker send a null JMSCorrelationId and a byte array full of zero 
> for JMSCorrelationIdAsBytes it creates issues with the hawtio webconsole as 
> this byte array is dump in an XML that no one can parse.
> Therefore I think it could be usefull to return null when we receive a 
> bytearray full of 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10387) JMS correlationIdAsBytes should return null and not byte array with zero values

2016-10-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575098#comment-15575098
 ] 

ASF GitHub Bot commented on CAMEL-10387:


GitHub user guillaumeterral opened a pull request:

https://github.com/apache/camel/pull/1212

CAMEL-10387 - Return null if the byte array contains only 0x0 values



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/guillaumeterral/camel CAMEL-10387

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1212


commit a140889f693ac829376bcf5afb37fbfbae23963f
Author: Guillaume Terral 
Date:   2016-10-14T11:45:11Z

CAMEL-10387 - Return null if the byte array contains only 0x0 values




> JMS correlationIdAsBytes should return null and not byte array with zero 
> values
> ---
>
> Key: CAMEL-10387
> URL: https://issues.apache.org/jira/browse/CAMEL-10387
> Project: Camel
>  Issue Type: Bug
>  Components: camel-jms
>Affects Versions: 2.18.0
>Reporter: Terral Guillaume
>
> When a JMS broker send a null JMSCorrelationId and a byte array full of zero 
> for JMSCorrelationIdAsBytes it creates issues with the hawtio webconsole as 
> this byte array is dump in an XML that no one can parse.
> Therefore I think it could be usefull to return null when we receive a 
> bytearray full of 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)