[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097375#comment-16097375
 ] 

ASF GitHub Bot commented on CAMEL-11531:


Github user asfgit closed the pull request at:

https://github.com/apache/camel/pull/1836


> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Assignee: Önder Sezgin
>Priority: Minor
> Fix For: 2.19.2, 2.20.0
>
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095274#comment-16095274
 ] 

ASF GitHub Bot commented on CAMEL-11531:


GitHub user onders86 reopened a pull request:

https://github.com/apache/camel/pull/1836

CAMEL-11531 - set servlet dependency as provided



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/onders86/camel CAMEL-11531

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1836


commit 826da2c6445726ffe3d412ecc3719aa1fdd87c4d
Author: onders86 
Date:   2017-07-20T11:19:26Z

CAMEL-11531 - set servlet dependency as provided




> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Assignee: Önder Sezgin
>Priority: Minor
> Fix For: 2.19.2, 2.20.0
>
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094677#comment-16094677
 ] 

ASF GitHub Bot commented on CAMEL-11531:


Github user onders86 closed the pull request at:

https://github.com/apache/camel/pull/1836


> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Assignee: Önder Sezgin
>Priority: Minor
> Fix For: 2.19.2, 2.20.0
>
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094546#comment-16094546
 ] 

ASF GitHub Bot commented on CAMEL-11531:


GitHub user onders86 opened a pull request:

https://github.com/apache/camel/pull/1836

CAMEL-11531 - set servlet dependency as provided



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/onders86/camel CAMEL-11531

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1836


commit 826da2c6445726ffe3d412ecc3719aa1fdd87c4d
Author: onders86 
Date:   2017-07-20T11:19:26Z

CAMEL-11531 - set servlet dependency as provided




> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Priority: Minor
> Fix For: 2.19.2, 2.20.0
>
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092725#comment-16092725
 ] 

Claus Ibsen commented on CAMEL-11531:
-

Ah okay, do you want to contribute a fix for this? You can provide a github PR
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Priority: Minor
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[Harmen Renkema (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089533#comment-16089533
 ] 

Harmen Renkema commented on CAMEL-11531:


Unless it's excluded in camel-servlet it will propagate to dependent projects. 

The following pom will result in the dependency tree below.

{noformat}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>

4.0.0

org.example
dependency-propagation
0.0.1-SNAPSHOT
war



org.apache.camel
camel-servlet
2.19.0




{noformat}


{noformat}
dependency-propagation$ mvn dependency:tree
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building dependency-propagation 0.0.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ 
dependency-propagation ---
[INFO] org.example:dependency-propagation:war:0.0.1-SNAPSHOT
[INFO] \- org.apache.camel:camel-servlet:jar:2.19.0:compile
[INFO]+- org.apache.camel:camel-core:jar:2.19.0:compile
[INFO]|  \- org.slf4j:slf4j-api:jar:1.7.22:compile
[INFO]+- org.apache.camel:camel-http-common:jar:2.19.0:compile
[INFO]|  \- javax.servlet:javax.servlet-api:jar:3.1.0:compile
[INFO]+- com.sun.xml.bind:jaxb-core:jar:2.2.11:compile
[INFO]\- com.sun.xml.bind:jaxb-impl:jar:2.2.11:compile
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1.512 s
[INFO] Finished at: 2017-07-17T11:17:41+02:00
[INFO] Final Memory: 15M/304M
[INFO] 

{noformat}



> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Priority: Minor
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11531) camel-http-common; dependency servlet-api should be set to provided

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088529#comment-16088529
 ] 

Claus Ibsen commented on CAMEL-11531:
-

Its set as provided on camel-servlet, so I wonder why you have a problem?
https://github.com/apache/camel/blob/camel.2-19.x/components/camel-servlet/pom.xml#L74

> camel-http-common; dependency servlet-api should be set to provided
> ---
>
> Key: CAMEL-11531
> URL: https://issues.apache.org/jira/browse/CAMEL-11531
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-http-common, camel-servlet
>Affects Versions: 2.19.0
>Reporter: Harmen Renkema
>Priority: Minor
>
> When using camel-servlet in WAR apps, the dependency on camel-http-common 
> brings in the servlet-api as a dependency with scope compile. The scope of 
> this dependency should be set to provided as it will be provided by the 
> container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)