[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-23 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727831#comment-16727831
 ] 

Claus Ibsen commented on CAMEL-13025:
-

[~vgvineet4] yeah you are welcome to look at the ftp component also and create 
a new PR if they need changes too.

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-22 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727465#comment-16727465
 ] 

Claus Ibsen commented on CAMEL-13025:
-

The camel-ftp component may need a similar check in some of its read lock 
implementations

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-22 Thread VINEET GANDHI1 (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727472#comment-16727472
 ] 

VINEET GANDHI1 commented on CAMEL-13025:


Ok Should I go ahead and do that in ftp component also if that's fine

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-22 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727464#comment-16727464
 ] 

Claus Ibsen commented on CAMEL-13025:
-

Yeah we have added the same check to that file too

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-22 Thread VINEET GANDHI1 (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727399#comment-16727399
 ] 

VINEET GANDHI1 commented on CAMEL-13025:


FileLockExclusiveReadLockStrategy.java file also needs change I think.

 

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-21 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727039#comment-16727039
 ] 

Claus Ibsen commented on CAMEL-13025:
-

There is also another read lock which needed same improvement.

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-20 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726274#comment-16726274
 ] 

Claus Ibsen commented on CAMEL-13025:
-

Contributions is welcome

In the file FileChangedExclusiveReadLockStrategy we need to add check if the 
target file exists, in the while loop

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)