[jira] [Commented] (CAMEL-13094) Context MBean not unregistered on startup failure

2019-08-01 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897810#comment-16897810
 ] 

Claus Ibsen commented on CAMEL-13094:
-

Thanks for the test-case Thomas

> Context MBean not unregistered on startup failure
> -
>
> Key: CAMEL-13094
> URL: https://issues.apache.org/jira/browse/CAMEL-13094
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 3.0.0
>Reporter: Thomas Diesler
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 3.0.0.M5
>
>
> In Camel-2.23.x a failure to start the context would call 
> ServiceSupport.doStop(). This is no longer the case. Instead, a 
> CamelContextStartupFailureEvent is thrown and services that might previously 
> have been started are never stopped.
> As a result or (side effect) the context MBean may remain registered if the 
> startup failure occurred after its initial registration. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (CAMEL-13094) Context MBean not unregistered on startup failure

2019-01-22 Thread Thomas Diesler (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748519#comment-16748519
 ] 

Thomas Diesler commented on CAMEL-13094:


Here is a plain 
[SimpleManagementTest|https://github.com/tdiesler/wildfly-camel/blob/CAMEL-13094/itests/camel/src/test/java/org/wildfly/camel/test/plain/simple/SimpleManagementTest.java]
 that shows the issue.

> Context MBean not unregistered on startup failure
> -
>
> Key: CAMEL-13094
> URL: https://issues.apache.org/jira/browse/CAMEL-13094
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 3.0.0
>Reporter: Thomas Diesler
>Priority: Major
> Fix For: 3.0.0
>
>
> In Camel-2.23.x a failure to start the context would call 
> ServiceSupport.doStop(). This is no longer the case. Instead, a 
> CamelContextStartupFailureEvent is thrown and services that might previously 
> have been started are never stopped.
> As a result or (side effect) the context MBean may remain registered if the 
> startup failure occurred after its initial registration. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13094) Context MBean not unregistered on startup failure

2019-01-22 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748503#comment-16748503
 ] 

Claus Ibsen commented on CAMEL-13094:
-

Yeah we should do like the old behaviour and stop on startup failure and throw 
the original exception

> Context MBean not unregistered on startup failure
> -
>
> Key: CAMEL-13094
> URL: https://issues.apache.org/jira/browse/CAMEL-13094
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 3.0.0
>Reporter: Thomas Diesler
>Priority: Major
> Fix For: 3.0.0
>
>
> In Camel-2.23.x a failure to start the context would call 
> ServiceSupport.doStop(). This is no longer the case. Instead, a 
> CamelContextStartupFailureEvent is thrown and services that might previously 
> have been started are never stopped.
> As a result or (side effect) the context MBean may remain registered if the 
> startup failure occurred after its initial registration. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13094) Context MBean not unregistered on startup failure

2019-01-21 Thread Thomas Diesler (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748455#comment-16748455
 ] 

Thomas Diesler commented on CAMEL-13094:


https://github.com/apache/camel/blob/camel-2.23.x/camel-core/src/main/java/org/apache/camel/support/ServiceSupport.java#L83

vs.

https://github.com/apache/camel/blob/master/camel-api/src/main/java/org/apache/camel/support/ServiceSupport.java#L90

> Context MBean not unregistered on startup failure
> -
>
> Key: CAMEL-13094
> URL: https://issues.apache.org/jira/browse/CAMEL-13094
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.23.0
>Reporter: Thomas Diesler
>Priority: Major
> Fix For: 3.0.0
>
>
> In Camel-2.23.x a failure to start the context would call 
> ServiceSupport.doStop(). This is no longer the case. Instead, a 
> CamelContextStartupFailureEvent is thrown and services that might previously 
> have been started are never stopped.
> As a result or (side effect) the context MBean may remain registered if the 
> startup failure occurred after its initial registration. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13094) Context MBean not unregistered on startup failure

2019-01-21 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748451#comment-16748451
 ] 

Claus Ibsen commented on CAMEL-13094:
-

I dont recall any startup changes like that. Do you have any reproducable 
project / unit test etc?
The only change is in camel-blueprint, and I would assume you are not talking 
about OSGi but eap/widlfly

> Context MBean not unregistered on startup failure
> -
>
> Key: CAMEL-13094
> URL: https://issues.apache.org/jira/browse/CAMEL-13094
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Reporter: Thomas Diesler
>Priority: Major
> Fix For: 3.0.0
>
>
> In Camel-2.23.x a failure to start the context would call 
> ServiceSupport.doStop(). This is no longer the case. Instead, a 
> CamelContextStartupFailureEvent is thrown and services that might previously 
> has been started are never stopped.
> As a result or (side effect) the context MBean may remain registered if the 
> startup failure occurred after its initial registration. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)