[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988760#comment-16988760 ] Claus Ibsen commented on CAMEL-14242: - And yeah it would be nice to use testcontainers to bootstrap rabbitmq for integration testing. I created a ticket: https://issues.apache.org/jira/browse/CAMEL-14260 > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Assignee: Claus Ibsen >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988741#comment-16988741 ] Claus Ibsen commented on CAMEL-14242: - Yeah it should honour the existing args on the endpoint > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988727#comment-16988727 ] Omar Al-Safi commented on CAMEL-14242: -- I don't think is going to work. The issue is, when the endpointdsl constructs the params map, it will assign {{arg.queue.x-max-priority}} to {{args}} of the endpoint which is expected when using the property binding [here|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java#L244]. However, then at this [check|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java#L252], we don't check if it was assigned to the endpoint and we end up with overwriting an empty {{localArgs}} that overrides what being set at the endpoint. > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988718#comment-16988718 ] Claus Ibsen commented on CAMEL-14242: - Also it may be its when you use Map instance, you can try with .args("arg.queue.x-max-priority=10") > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988709#comment-16988709 ] Claus Ibsen commented on CAMEL-14242: - It should be .args(Collections.singletonMap("arg.queue.x-max-priority", "10")); > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988174#comment-16988174 ] michael elbaz commented on CAMEL-14242: --- [~omarsmak] i made some modifications it's appear to be work but not sure at all about side effect, it still not clear for me what's relation between options and query parameters. I also detected some weird test see org.apache.camel.component.rabbitmq.RabbitMQConsumerIntTest.sentMessageIsReceivedWithHeadersRouting() *// Don't know what it suppose to do but nothing is filtered i get the 3 headers so this test is wrong* {code:java} @Test public void sentMessageIsReceivedWithHeadersRouting() throws InterruptedException, IOException, TimeoutException { //should only be one message that makes it through because only //one has the correct header set to.expectedMessageCount(1); Channel channel = connection().createChannel(); channel.basicPublish(HEADERS_EXCHANGE, "", propertiesWithHeader("foo", "bar"), MSG.getBytes()); channel.basicPublish(HEADERS_EXCHANGE, "", null, MSG.getBytes()); channel.basicPublish(HEADERS_EXCHANGE, "", propertiesWithHeader("foo", "bra"), MSG.getBytes()); to.assertIsSatisfied(); } {code} > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988099#comment-16988099 ] michael elbaz commented on CAMEL-14242: --- I'm currently working on this the first weird i see when i running unit tests is that [this one|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java#L252] is called 3 time every tests by main thread > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987924#comment-16987924 ] Omar Al-Safi commented on CAMEL-14242: -- Cool. A comment from you that you are working on it is enough. Good luck! > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987918#comment-16987918 ] michael elbaz commented on CAMEL-14242: --- Ok thanks for this precision you can assign me this ticket if you want i'll try to fix this as you're proposed > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987912#comment-16987912 ] Omar Al-Safi commented on CAMEL-14242: -- Query parameters appear in the URI string. Options, that you set in the component level using the APIs. Endpointdsl uses options (API) to set args. Camel normally will parse the URI into {{Map}} of params that will be passed into the component, you can add a breakpoint [here|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java#L151] and you will see what happens to param. Try it on both, endpointdsl and running the route using the URI string > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible when using endpointdsl
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987789#comment-16987789 ] michael elbaz commented on CAMEL-14242: --- [~omarsmak] Yeah i'll do but still not sure about what i explain my understanding: *Options* must be set using components object only *Query parameters* Using dsl or string Args is in Options section (in the documentation) so i guess we can't set args using dsl maybe i'm wrong ? Options and query parameters i'm are still not sure about what the difference thanks for your answer > camel-rabbitmq - Binding parameters with x- is not possible when using > endpointdsl > -- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987747#comment-16987747 ] Omar Al-Safi commented on CAMEL-14242: -- Yes, it seems there is a bug in regards to endpointdsl and RabbitMQComponent and I verified it. To give you a context, when you do something like this: {code} rabbitmq("foo") .queue("foo") .advanced() .args(Collections.singletonMap("queue.x-max-priority", "10")); {code} The endpointdsl will bootstrap a URI route and parameters. However, these parameters that being bootstrapped by the endpointdsl, is taking this shape: {code} "queue.x-max-priority" -> "10" {code} Meanwhile, the [component expects parameters|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java#L256] with prefix appended {{arg.}}, e.g in this form: {code} "arg.queue.x-max-priority" -> "10" {code} The fix is fairly simple, you just need to check if why args are not assigned [here|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java#L252]. However, if you wish, you are encouraged to send a PR to fix this since you spent the time to test it and report. Let me know if you are willing to jump on this one to fix. > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Assignee: Omar Al-Safi >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987713#comment-16987713 ] michael elbaz commented on CAMEL-14242: --- [~omarsmak] I don't sure about closing this now is right > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Assignee: Omar Al-Safi >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987705#comment-16987705 ] michael elbaz commented on CAMEL-14242: --- The only way i found what is your opinion about is not ideal for me {code:java} private Endpoint rabbitMq() throws Exception { RabbitMQComponent rabbitMQComponent = getContext().getComponent("rabbitmq", RabbitMQComponent.class); rabbitMQComponent.setArgs(Collections.singletonMap("queue.x-max-priority", "10")); return rabbitMQComponent.createEndpoint(rabbitmq("foo").queue("foo").getUri()); } {code} I don't understand why the args is accessible from the dsl in my previous example if it is no taken into account > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Assignee: Omar Al-Safi >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987703#comment-16987703 ] michael elbaz commented on CAMEL-14242: --- I'll upgrade the documentation when i'll sure about the right way > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Assignee: Omar Al-Safi >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987699#comment-16987699 ] michael elbaz commented on CAMEL-14242: --- No it doesn't that why i'm asking here {code:java} private AdvancedRabbitMQEndpointBuilder rabbitMq() { return rabbitmq(rabbitMqConfiguration.rabbitMqQueueName(RABBIT_MQ_INPUT_QUEUE_NAME)) .queue(rabbitMqConfiguration.rabbitMqQueueName(RABBIT_MQ_INPUT_QUEUE_NAME)) .advanced() .args(Collections.singletonMap("queue.x-max-priority", "10")); } {code} > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Assignee: Omar Al-Safi >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987669#comment-16987669 ] Omar Al-Safi commented on CAMEL-14242: -- You are encouraged to help out on fixing the docs, click on 'Edit this Page` here: https://camel.apache.org/components/latest/rabbitmq-component.html and you will be redirected to github where you can amend your modifications. I think it should work, you just need to omit the prefix {{arg.}}, e.g: {{rabbitmq("abbitmq:foo").args("queue.x-max-priority", "10")}}. > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987657#comment-16987657 ] michael elbaz commented on CAMEL-14242: --- A directly i'm trying this now > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987650#comment-16987650 ] Omar Al-Safi commented on CAMEL-14242: -- Sorry I meant in the URI as query parameter e.g: {{rabbitmq:foo?queue=foo&arg.queue.x-max-priority=10}} > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987648#comment-16987648 ] michael elbaz commented on CAMEL-14242: --- Ok guys after investigate the tests its appear to achieve the same as before the only way now is by configuring component like this: {code:java} private Endpoint rabbitMq() throws Exception { RabbitMQComponent rabbitMQComponent = getContext().getComponent("rabbitmq", RabbitMQComponent.class); rabbitMQComponent.setArgs(Collections.singletonMap("queue.x-max-priority", "10")); return rabbitMQComponent.createEndpoint("rabbitmq:foo?queue=foo"); } {code} So is working this way but the doc should be updated i think (i personally prefer the oldest way because we was free to add any option directly using query parameters and simple map and now like it was the case with x-max-priority we have to code every options in the component source code). Thanks for your help > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987574#comment-16987574 ] michael elbaz commented on CAMEL-14242: --- What did mean by adding in the route ? > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987337#comment-16987337 ] Omar Al-Safi commented on CAMEL-14242: -- Honestly I *don't think* this is a bug, this feature was deprecated in 2.x and I guess you were aware of it and yet you didn't raise your concerns back then as Andrea mentioned in the chat. However, I do agree with you that docs are bit misleading in this regards and wasn't clear on the alternatives. Second, did you try what I suggested in the chat? To add this in the route {{arg.queue.x-max-priority=x}} (this is different from what I suggested earlier as I wasn't really aware)? As I understood from the code, this used to work as alternative to {{queueArgsConfigurer}}. Third, we read your comments that you delete in JIRA as email notification, again this is an open source project, which means we treat each other with respect and of course constructive criticism is always welcome, hence I again as I mentioned before we would appreciate the same from you. > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987318#comment-16987318 ] Jan Bednar commented on CAMEL-14242: For integration tests you need to start local instance of rabbitmq, there is docker image ready for this, see readme ( https://github.com/apache/camel/blob/master/components/camel-rabbitmq/readme.txt ). While looking into this, you might be interested in [RabbitMQDeclareSupport#formatSpecialQueueArguments|https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQDeclareSupport.java#L76] which handles the conversion of x-max-priority from String to Integer and debug, why the conversion is not happening in your case. > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987198#comment-16987198 ] michael elbaz commented on CAMEL-14242: --- I'm just asking for better understanding the process that all i all the time recommend and advise my client using camel is for me the best integration Framework > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987173#comment-16987173 ] Andrea Cosentino commented on CAMEL-14242: -- Anyone with committer power can merge pull requests. We are very careful each time and it seems to me you're criticizing this project a bit too much. Enough is enough. > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987041#comment-16987041 ] michael elbaz commented on CAMEL-14242: --- Ok i'll try to check this one (I would like to now who is responsible for accepting code how the process is working ? because i think we have to be very careful about not introducing regression camel handle very critical part of companies IT department) > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987056#comment-16987056 ] michael elbaz commented on CAMEL-14242: --- Using maven or ide i get a lots of exceptions when i trying to run tests for example: {code:java} Caused by: org.apache.camel.RuntimeCamelException: com.rabbitmq.client.AuthenticationFailureException: ACCESS_REFUSED - Login was refused {code} > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987034#comment-16987034 ] Claus Ibsen commented on CAMEL-14242: - Why not help, sorry there is no free lunch. If you need priority help, then get in touch with commercial vendors. but in general its mostly "when people get time to work on" and if they fancy rabbitmq, eg i dont really use it, so i am not jumping on it asap, as opposed to kafka, jms, activemq, and others etc. And btw thanks for reporting and testing. > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987028#comment-16987028 ] michael elbaz commented on CAMEL-14242: --- Ok so i use the native client is more reliable i think (this component was working before wrong PR validation) thanks for your help > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Minor > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986992#comment-16986992 ] Claus Ibsen commented on CAMEL-14242: - Nobody is taking care of this at this moment. Its open source and community is very much welcome to help. See https://camel.apache.org/manual/latest/contributing.html > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Major > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14242) camel-rabbitmq - Binding parameters with x- is not possible
[ https://issues.apache.org/jira/browse/CAMEL-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986932#comment-16986932 ] michael elbaz commented on CAMEL-14242: --- [~cib...@e-ma.net] i not agree is not an improvement is bug and is not only about x arguments, please guys is someone take care about this one ? > camel-rabbitmq - Binding parameters with x- is not possible > --- > > Key: CAMEL-14242 > URL: https://issues.apache.org/jira/browse/CAMEL-14242 > Project: Camel > Issue Type: Improvement > Components: camel-rabbitmq >Affects Versions: 3.0.0 >Reporter: michael elbaz >Priority: Major > > I can' use some rabbitMq parameter eg: *x-max-priority* please provide an > working exemple. > It was before possible doing that using deprecated parameter > *&queueArgsConfigurer=#rabbitMqQueueArgsConfigurer* > {code:java} > @Bean("rabbitMqQueueArgsConfigurer") > public ArgsConfigurer rabbitMqQueueArgsConfigurer() { > return map -> map.put("x-max-priority", 10); > } > {code} > See this one: > [https://stackoverflow.com/a/44651087/4271976|https://stackoverflow.com/a/44651087/4271976] -- This message was sent by Atlassian Jira (v8.3.4#803005)