[jira] [Commented] (CAMEL-8000) Add global notion of CamelContextRegistry
[ https://issues.apache.org/jira/browse/CAMEL-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225942#comment-14225942 ] ASF GitHub Bot commented on CAMEL-8000: --- Github user tdiesler closed the pull request at: https://github.com/apache/camel/pull/322 Add global notion of CamelContextRegistry - Key: CAMEL-8000 URL: https://issues.apache.org/jira/browse/CAMEL-8000 Project: Camel Issue Type: Improvement Affects Versions: 2.14.0 Reporter: Thomas Diesler Assignee: Claus Ibsen There are a number of issues with the Container API that make it unusable in WildFly # Concept of unsynchronised singleton # Call to 3rd party code with partially constructed objects # Unsynchronised access to a shared resource Currently there are at least two components that compete for the Container singleton. The Camel Subsystem and Insight Camel. I suspect that the Container API cannot be fixed in a compatible way. Instead the notion of a CamelContextRegistry that fixes the issues with Container may need to get added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8000) Add global notion of CamelContextRegistry
[ https://issues.apache.org/jira/browse/CAMEL-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214676#comment-14214676 ] Thomas Diesler commented on CAMEL-8000: --- The clear() shadows an issue with insufficiently defined context lifecycle. AFAICS, a CamelContext is owned by the client that creates it. The client therefore also controls the (softly defined) identity and the sharing. The context ends life when the client does no longer hold a reference to it. A call to CamelContext.stop() is optional. We are now trying to introduce an entity that has a lifecycle that outlives individual context and (although it does not own them) holds references to them. To model this properly, we would probably want to have something like a CamelRuntime - similar to Framework and Bundle in OSGi. The runtime is the owner of all contexts, it provides a view of all registered contexts, it can be queried and possibly own other constructs that are applicable to multiple contexts (i.e. defaults for newly created contexts). This would be a larger change to camel and probably requires a lot more thought. CamelContextRegistry.clear() is still wrong, but it is also wrong to assume that a context gets an non-optional call to CamelContext.stop() which ends its life. The registry probably needs to hold weak references, to avoid hogging of stale contexts. Add global notion of CamelContextRegistry - Key: CAMEL-8000 URL: https://issues.apache.org/jira/browse/CAMEL-8000 Project: Camel Issue Type: Improvement Affects Versions: 2.14.0 Reporter: Thomas Diesler Assignee: Claus Ibsen Fix For: 2.15.0 There are a number of issues with the Container API that make it unusable in WildFly # Concept of unsynchronised singleton # Call to 3rd party code with partially constructed objects # Unsynchronised access to a shared resource Currently there are at least two components that compete for the Container singleton. The Camel Subsystem and Insight Camel. I suspect that the Container API cannot be fixed in a compatible way. Instead the notion of a CamelContextRegistry that fixes the issues with Container may need to get added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8000) Add global notion of CamelContextRegistry
[ https://issues.apache.org/jira/browse/CAMEL-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204805#comment-14204805 ] Thomas Diesler commented on CAMEL-8000: --- Pull request sent: https://github.com/apache/camel/pull/322 Add global notion of CamelContextRegistry - Key: CAMEL-8000 URL: https://issues.apache.org/jira/browse/CAMEL-8000 Project: Camel Issue Type: Improvement Affects Versions: 2.14.0 Reporter: Thomas Diesler Assignee: Claus Ibsen Fix For: 2.15.0 There are a number of issues with the Container API that make it unusable in WildFly # Concept of unsynchronised singleton # Call to 3rd party code with partially constructed objects # Unsynchronised access to a shared resource Currently there are at least two components that compete for the Container singleton. The Camel Subsystem and Insight Camel. I suspect that the Container API cannot be fixed in a compatible way. Instead the notion of a CamelContextRegistry that fixes the issues with Container may need to get added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8000) Add global notion of CamelContextRegistry
[ https://issues.apache.org/jira/browse/CAMEL-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201850#comment-14201850 ] ASF GitHub Bot commented on CAMEL-8000: --- GitHub user tdiesler opened a pull request: https://github.com/apache/camel/pull/322 [CAMEL-8000] Add global notion of CamelContextRegistry You can merge this pull request into a Git repository by running: $ git pull https://github.com/tdiesler/camel bug8000 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 commit 6f428a8390910786de64abd4771604a213171842 Author: Thomas Diesler thomas.dies...@jboss.com Date: 2014-11-07T09:48:15Z [CAMEL-8000] Add global notion of CamelContextRegistry Add global notion of CamelContextRegistry - Key: CAMEL-8000 URL: https://issues.apache.org/jira/browse/CAMEL-8000 Project: Camel Issue Type: Bug Affects Versions: 2.14.0 Reporter: Thomas Diesler Fix For: 2.15.0 There are a number of issues with the Container API that make it unusable in WildFly # Concept of unsynchronised singleton # Call to 3rd party code with partially constructed objects # Unsynchronised access to a shared resource Currently there are at least two components that compete for the Container singleton. The Camel Subsystem and Insight Camel. I suspect that the Container API cannot be fixed in a compatible way. Instead the notion of a CamelContextRegistry that fixes the issues with Container may need to get added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8000) Add global notion of CamelContextRegistry
[ https://issues.apache.org/jira/browse/CAMEL-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201854#comment-14201854 ] Thomas Diesler commented on CAMEL-8000: --- Pull request sent: https://github.com/apache/camel/pull/322 Add global notion of CamelContextRegistry - Key: CAMEL-8000 URL: https://issues.apache.org/jira/browse/CAMEL-8000 Project: Camel Issue Type: Bug Affects Versions: 2.14.0 Reporter: Thomas Diesler Fix For: 2.15.0 There are a number of issues with the Container API that make it unusable in WildFly # Concept of unsynchronised singleton # Call to 3rd party code with partially constructed objects # Unsynchronised access to a shared resource Currently there are at least two components that compete for the Container singleton. The Camel Subsystem and Insight Camel. I suspect that the Container API cannot be fixed in a compatible way. Instead the notion of a CamelContextRegistry that fixes the issues with Container may need to get added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8000) Add global notion of CamelContextRegistry
[ https://issues.apache.org/jira/browse/CAMEL-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202538#comment-14202538 ] Thomas Diesler commented on CAMEL-8000: --- merci Add global notion of CamelContextRegistry - Key: CAMEL-8000 URL: https://issues.apache.org/jira/browse/CAMEL-8000 Project: Camel Issue Type: Improvement Affects Versions: 2.14.0 Reporter: Thomas Diesler Assignee: Claus Ibsen Fix For: 2.15.0 There are a number of issues with the Container API that make it unusable in WildFly # Concept of unsynchronised singleton # Call to 3rd party code with partially constructed objects # Unsynchronised access to a shared resource Currently there are at least two components that compete for the Container singleton. The Camel Subsystem and Insight Camel. I suspect that the Container API cannot be fixed in a compatible way. Instead the notion of a CamelContextRegistry that fixes the issues with Container may need to get added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
