[GitHub] [carbondata] QiangCai commented on pull request #3813: [CARBONDATA-3876] Update cli test case

2020-06-28 Thread GitBox
QiangCai commented on pull request #3813: URL: https://github.com/apache/carbondata/pull/3813#issuecomment-650867384 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3814: [CARBONDATA-3878] Get last modified time from 'tablestatus' file entry instead of segment file to reduce file operation 'getLastModifiedTime'

2020-06-28 Thread GitBox
asfgit closed pull request #3814: URL: https://github.com/apache/carbondata/pull/3814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (CARBONDATA-3878) Should get the last modified time from 'tablestatus' file instead of segment file to reduce file operation 'getLastModifiedTime'

2020-06-28 Thread David Cai (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Cai reassigned CARBONDATA-3878: - Assignee: David Cai > Should get the last modified time from 'tablestatus' file

[jira] [Resolved] (CARBONDATA-3878) Should get the last modified time from 'tablestatus' file instead of segment file to reduce file operation 'getLastModifiedTime'

2020-06-28 Thread David Cai (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Cai resolved CARBONDATA-3878. --- Resolution: Fixed > Should get the last modified time from 'tablestatus' file instead

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446609417 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -63,13 +68,101 @@ object CarbonStore { }

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446609223 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -63,13 +68,101 @@ object CarbonStore { }

[GitHub] [carbondata] akashrn5 opened a new pull request #3812: [wip]fix global sort compaction issue

2020-06-28 Thread GitBox
akashrn5 opened a new pull request #3812: URL: https://github.com/apache/carbondata/pull/3812 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446609866 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowSegmentsCommand.scala ## @@ -17,34 +17,40

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446609807 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -63,13 +68,101 @@ object CarbonStore { }

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446607939 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowSegmentsAsSelectCommand.scala ## @@ -35,7

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446608882 ## File path: docs/segment-management-on-carbondata.md ## @@ -32,7 +32,7 @@ concept which helps to maintain consistency of data and easy transaction

[GitHub] [carbondata] jackylk commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
jackylk commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446608764 ## File path: docs/segment-management-on-carbondata.md ## @@ -32,7 +32,7 @@ concept which helps to maintain consistency of data and easy transaction

[GitHub] [carbondata] QiangCai commented on pull request #3801: adding comments with issue numbers.

2020-06-28 Thread GitBox
QiangCai commented on pull request #3801: URL: https://github.com/apache/carbondata/pull/3801#issuecomment-650709366 If it can help us to understand the code, we can add the issue number into the code in a few cases, else if no need to do. But this PR is not the above case, it added all

[GitHub] [carbondata] niuge01 commented on pull request #3814: [CARBONDATA-3878] Get last modified time from 'tablestatus' file entry instead of segment file to reduce file operation 'getLastModifiedT

2020-06-28 Thread GitBox
niuge01 commented on pull request #3814: URL: https://github.com/apache/carbondata/pull/3814#issuecomment-650745072 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] marchpure closed pull request #3794: [WIP] refresh segment index cache performance issue

2020-06-28 Thread GitBox
marchpure closed pull request #3794: URL: https://github.com/apache/carbondata/pull/3794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3813: [CARBONDATA-3876] Update cli test case

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3813: URL: https://github.com/apache/carbondata/pull/3813#issuecomment-650759599 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1508/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3798: [CARBONDATA-3875] Support show segments with stage

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#issuecomment-650760914 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1509/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3798: [CARBONDATA-3875] Support show segments with stage

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#issuecomment-650761126 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3237/

[GitHub] [carbondata] marchpure commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments with stage

2020-06-28 Thread GitBox
marchpure commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446657621 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -63,13 +68,101 @@ object CarbonStore { }

[GitHub] [carbondata] marchpure commented on a change in pull request #3798: [CARBONDATA-3875] Support show segments with stage

2020-06-28 Thread GitBox
marchpure commented on a change in pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#discussion_r446657569 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowSegmentsCommand.scala ## @@ -17,34

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3814: [CARBONDATA-3878] Get last modified time from 'tablestatus' file entry instead of segment file to reduce file operation 'getLastMod

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3814: URL: https://github.com/apache/carbondata/pull/3814#issuecomment-650770839 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3239/

[GitHub] [carbondata] QiangCai opened a new pull request #3814: [CARBONDATA-3878] Get last modified time from 'tablestatus' file entry instead of segment file to reduce file operation 'getLastModified

2020-06-28 Thread GitBox
QiangCai opened a new pull request #3814: URL: https://github.com/apache/carbondata/pull/3814 ### Why is this PR needed? After the table has too many segments, file operation 'getLastModifiedTime' on all segment files will take a long time. ### What changes were proposed in

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-650755888 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3238/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-650756474 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1510/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3813: [CARBONDATA-3876] Update cli test case

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3813: URL: https://github.com/apache/carbondata/pull/3813#issuecomment-650759563 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3236/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3814: [CARBONDATA-3878] Get last modified time from 'tablestatus' file entry instead of segment file to reduce file operation 'getLastMod

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3814: URL: https://github.com/apache/carbondata/pull/3814#issuecomment-650770324 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1511/

[jira] [Updated] (CARBONDATA-3865) Implement delete and update feature in carbondata SDK.

2020-06-28 Thread Karanpreet Singh (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karanpreet Singh updated CARBONDATA-3865: - Attachment: Implement delete and update feature in carbondata SDK_V2.pdf >

[jira] [Created] (CARBONDATA-3877) Reduce read tablestatus overhead during inserting into partition table

2020-06-28 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-3877: --- Summary: Reduce read tablestatus overhead during inserting into partition table Key: CARBONDATA-3877 URL: https://issues.apache.org/jira/browse/CARBONDATA-3877

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#issuecomment-650730601 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3235/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3798: [CARBONDATA-3875] Support show segments include stage

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#issuecomment-650731827 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1507/

[jira] [Created] (CARBONDATA-3876) Update cli test case

2020-06-28 Thread Manhua Jiang (Jira)
Manhua Jiang created CARBONDATA-3876: Summary: Update cli test case Key: CARBONDATA-3876 URL: https://issues.apache.org/jira/browse/CARBONDATA-3876 Project: CarbonData Issue Type:

[GitHub] [carbondata] kevinjmh opened a new pull request #3813: [CARBONDATA-3876] Update cli test case

2020-06-28 Thread GitBox
kevinjmh opened a new pull request #3813: URL: https://github.com/apache/carbondata/pull/3813 ### Why is this PR needed? The test case wants to validate non-sorted column's min max range. To make the result fixed, set all columns to be sort columns ### What changes were

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3812: [wip]fix global sort compaction issue

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-650722692 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1505/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3812: [wip]fix global sort compaction issue

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-650723297 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3233/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-650724384 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3234/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-650724764 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1506/

[jira] [Created] (CARBONDATA-3878) Should get the last modified time from 'tablestatus' file instead of segment file to reduce file operation 'getLastModifiedTime'

2020-06-28 Thread David Cai (Jira)
David Cai created CARBONDATA-3878: - Summary: Should get the last modified time from 'tablestatus' file instead of segment file to reduce file operation 'getLastModifiedTime' Key: CARBONDATA-3878 URL:

[GitHub] [carbondata] jackylk commented on pull request #3798: [CARBONDATA-3875] Support show segments with stage

2020-06-28 Thread GitBox
jackylk commented on pull request #3798: URL: https://github.com/apache/carbondata/pull/3798#issuecomment-650778971 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3798: [CARBONDATA-3875] Support show segments with stage

2020-06-28 Thread GitBox
asfgit closed pull request #3798: URL: https://github.com/apache/carbondata/pull/3798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-650794297 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3240/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-28 Thread GitBox
CarbonDataQA1 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-650794400 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1512/