[GitHub] [carbondata] QiangCai commented on a change in pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
QiangCai commented on a change in pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#discussion_r446839075 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeInMemoryIntermediateDataMerger.java ## @@

[jira] [Closed] (CARBONDATA-3877) Reduce read tablestatus overhead during inserting into partition table

2020-06-29 Thread Xingjun Hao (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingjun Hao closed CARBONDATA-3877. --- Resolution: Fixed > Reduce read tablestatus overhead during inserting into partition

[GitHub] [carbondata] QiangCai commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
QiangCai commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651010686 how about to change RowResultMergerProcessor? This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
kevinjmh commented on a change in pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#discussion_r446854580 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeInMemoryIntermediateDataMerger.java ## @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3810: [WIP] Fix missing Table status lock in some SI flows

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3810: URL: https://github.com/apache/carbondata/pull/3810#issuecomment-651041002 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1517/

[GitHub] [carbondata] asfgit closed pull request #3813: [CARBONDATA-3876] Update cli test case

2020-06-29 Thread GitBox
asfgit closed pull request #3813: URL: https://github.com/apache/carbondata/pull/3813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kevinjmh commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
kevinjmh commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651002898 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai edited a comment on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
QiangCai edited a comment on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651010686 can you change RowResultMergerProcessor? This is an automated message from the Apache Git Service.

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #1380: [CARBONDATA-1485] Timestamp no dictionary bug

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #1380: URL: https://github.com/apache/carbondata/pull/1380#issuecomment-651065141 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3253/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3815: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3815: URL: https://github.com/apache/carbondata/pull/3815#issuecomment-651139374 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3254/

[GitHub] [carbondata] QiangCai commented on a change in pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
QiangCai commented on a change in pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#discussion_r446910728 ## File path: processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java ## @@ -126,7 +125,7 @@ public boolean

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3815: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3815: URL: https://github.com/apache/carbondata/pull/3815#issuecomment-651123569 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1519/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3815: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3815: URL: https://github.com/apache/carbondata/pull/3815#issuecomment-651126279 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3249/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651144733 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3251/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3810: [WIP] Fix missing Table status lock in some SI flows

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3810: URL: https://github.com/apache/carbondata/pull/3810#issuecomment-651042182 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3245/

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
kevinjmh commented on a change in pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#discussion_r446924645 ## File path: processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java ## @@ -126,7 +125,7 @@ public boolean

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651078587 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1518/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-651137417 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1520/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-651147884 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3256/

[GitHub] [carbondata] nihal0107 opened a new pull request #3815: support carbon SDK to load data from different files

2020-06-29 Thread GitBox
nihal0107 opened a new pull request #3815: URL: https://github.com/apache/carbondata/pull/3815 ### Why is this PR needed? TO support carbon SDK to load data from different files. ### What changes were proposed in this PR? Now user can load a single file or all files under

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-651142751 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3252/

[GitHub] [carbondata] marchpure commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-29 Thread GitBox
marchpure commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-651146016 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651162149 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1521/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-651227739 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1522/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3815: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3815: URL: https://github.com/apache/carbondata/pull/3815#issuecomment-651186407 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3259/

[GitHub] [carbondata] marchpure opened a new pull request #3816: [CARBONDATA-3879] Filtering Segmets Optimazation

2020-06-29 Thread GitBox
marchpure opened a new pull request #3816: URL: https://github.com/apache/carbondata/pull/3816 ### Why is this PR needed? During filter segments flow, there are a lot of LIST.CONTAINS, which has heavy time overhead when there are tens of thousands segments. For example, if there

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3815: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3815: URL: https://github.com/apache/carbondata/pull/3815#issuecomment-651223370 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1523/

[jira] [Created] (CARBONDATA-3879) Filtering Segmets Optimazation

2020-06-29 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-3879: --- Summary: Filtering Segmets Optimazation Key: CARBONDATA-3879 URL: https://issues.apache.org/jira/browse/CARBONDATA-3879 Project: CarbonData Issue

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651160152 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3257/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-651225029 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3258/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651264615 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3261/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-651267813 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1526/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-651273377 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3265/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-651266518 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3262/

[GitHub] [carbondata] ShreelekhyaG opened a new pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-06-29 Thread GitBox
ShreelekhyaG opened a new pull request #3817: URL: https://github.com/apache/carbondata/pull/3817 …y BUCKET_NUMBER and BUCKET_COLUMNS ### Why is this PR needed? Bucket table creation fails with an exception for empty BUCKET_NUMBER and BUCKET_COLUMNS ### What changes

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-651275203 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1529/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651265133 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1525/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-651270444 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1528/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-651270919 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3264/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#issuecomment-651318156 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1527/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#issuecomment-651318828 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3263/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651350898 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
QiangCai commented on pull request #3804: URL: https://github.com/apache/carbondata/pull/3804#issuecomment-651450852 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on a change in pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
QiangCai commented on a change in pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#discussion_r447373586 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ## @@ -232,47 +233,40 @@ private List

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651530149 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3268/

[GitHub] [carbondata] asfgit closed pull request #3804: [CARBONDATA-3871] Optimize performance when getting row from heap

2020-06-29 Thread GitBox
asfgit closed pull request #3804: URL: https://github.com/apache/carbondata/pull/3804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] niuge01 commented on pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-29 Thread GitBox
niuge01 commented on pull request #3800: URL: https://github.com/apache/carbondata/pull/3800#issuecomment-651481639 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651538060 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1533/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651538493 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3269/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.m

2020-06-29 Thread GitBox
ajantha-bhat commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r447427801 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -302,6 +318,61 @@ private void

[GitHub] [carbondata] asfgit closed pull request #3800: [CARBONDATA-3877] Reduce read tablestatus overhead during inserting into partition table

2020-06-29 Thread GitBox
asfgit closed pull request #3800: URL: https://github.com/apache/carbondata/pull/3800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.m

2020-06-29 Thread GitBox
ajantha-bhat commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r447425474 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -282,10 +296,12 @@ private void

[GitHub] [carbondata] niuge01 commented on a change in pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
niuge01 commented on a change in pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#discussion_r447366192 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ## @@ -232,47 +233,40 @@ private List

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3816: [CARBONDATA-3879] Filtering Segments Optimazation

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3816: URL: https://github.com/apache/carbondata/pull/3816#issuecomment-651530514 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1532/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.m

2020-06-29 Thread GitBox
ajantha-bhat commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r447426104 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableLoadingTestCase.scala

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-651374421 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3267/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-651375743 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1531/