[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r460033679 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala ## @@ -170,11

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-663487527 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3495/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r460033679 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala ## @@ -170,11

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r460034270 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -82,6 +81,33 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r460034871 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ## @@ -70,12

[GitHub] [carbondata] ajantha-bhat commented on pull request #3854: [CARBONDATA-3920]Fix compaction failure issue for SI table and metadata mismatch in concurrency

2020-07-24 Thread GitBox
ajantha-bhat commented on pull request #3854: URL: https://github.com/apache/carbondata/pull/3854#issuecomment-663515404 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-663488436 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1753/

[GitHub] [carbondata] asfgit closed pull request #3854: [CARBONDATA-3920]Fix compaction failure issue for SI table and metadata mismatch in concurrency

2020-07-24 Thread GitBox
asfgit closed pull request #3854: URL: https://github.com/apache/carbondata/pull/3854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (CARBONDATA-3920) compaction failure issue for SI table and metadata mismatch in concurrency

2020-07-24 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3920. -- Fix Version/s: 2.1.0 Resolution: Fixed > compaction failure issue for SI

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r460035762 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala ## @@ -677,6 +677,8 @@ object

[GitHub] [carbondata] akashrn5 commented on pull request #3859: [CARBONDATA-3921] SI load fails with 'unable to get filestatus error' in concurrent scenario

2020-07-24 Thread GitBox
akashrn5 commented on pull request #3859: URL: https://github.com/apache/carbondata/pull/3859#issuecomment-663572678 @akkio-97 please resolve conflicts This is an automated message from the Apache Git Service. To respond to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-663581874 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3497/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-663586046 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1755/

[GitHub] [carbondata] akashrn5 commented on pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-24 Thread GitBox
akashrn5 commented on pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#issuecomment-663573168 @Karan980 please refer other PRs and update the PR description in a similar way. This is an automated

[GitHub] [carbondata] MarvinLitt commented on a change in pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-24 Thread GitBox
MarvinLitt commented on a change in pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#discussion_r460346175 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala ## @@ -69,6 +69,12 @@ class DistributedIndexJob

[GitHub] [carbondata] MarvinLitt commented on a change in pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-24 Thread GitBox
MarvinLitt commented on a change in pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#discussion_r460346175 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala ## @@ -69,6 +69,12 @@ class DistributedIndexJob

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460357773 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -189,16 +196,14 @@ public CarbonTable

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460357847 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -260,7 +265,50 @@ public boolean

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460359465 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -260,7 +265,50 @@ public boolean

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460358760 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -260,7 +265,50 @@ public boolean

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460359351 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -260,7 +265,50 @@ public boolean

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460359320 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -260,7 +265,50 @@ public boolean

[GitHub] [carbondata] MarvinLitt commented on a change in pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-24 Thread GitBox
MarvinLitt commented on a change in pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#discussion_r460346871 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java ## @@ -485,4 +486,30 @@ public boolean

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r460358199 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -260,7 +265,50 @@ public boolean

[GitHub] [carbondata] MarvinLitt commented on a change in pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-24 Thread GitBox
MarvinLitt commented on a change in pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#discussion_r460346573 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala ## @@ -316,4 +324,17 @@ object IndexServer

[GitHub] [carbondata] xubo245 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
xubo245 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-663800968 Please rebase it This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Karan980 commented on pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-24 Thread GitBox
Karan980 commented on pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#issuecomment-663601554 @akashrn5 Done This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-663400074 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3491/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-663399635 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1749/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3860: [CARBONDATA-3889] Cleanup duplicated code in carbondata-core module

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3860: URL: https://github.com/apache/carbondata/pull/3860#issuecomment-663408615 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1752/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3860: [CARBONDATA-3889] Cleanup duplicated code in carbondata-core module

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3860: URL: https://github.com/apache/carbondata/pull/3860#issuecomment-663409005 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3494/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3859: [CARBONDATA-3921] SI load fails with 'unable to get filestatus error' in concurrent scenario

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3859: URL: https://github.com/apache/carbondata/pull/3859#issuecomment-663363478 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3490/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3859: [CARBONDATA-3921] SI load fails with 'unable to get filestatus error' in concurrent scenario

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3859: URL: https://github.com/apache/carbondata/pull/3859#issuecomment-663364506 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1748/

[GitHub] [carbondata] akashrn5 opened a new pull request #3862: [wip]test issue

2020-07-24 Thread GitBox
akashrn5 opened a new pull request #3862: URL: https://github.com/apache/carbondata/pull/3862 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-663370743 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1750/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-663371057 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3492/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-663378402 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3493/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-663378119 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1751/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3852: [CARBONDATA-3912] Fixed concurrent locking issue for clean files after load

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3852: URL: https://github.com/apache/carbondata/pull/3852#issuecomment-663385884 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3489/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3852: [CARBONDATA-3912] Fixed concurrent locking issue for clean files after load

2020-07-24 Thread GitBox
CarbonDataQA1 commented on pull request #3852: URL: https://github.com/apache/carbondata/pull/3852#issuecomment-663386619 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1747/

[GitHub] [carbondata] QiangCai commented on pull request #3849: [CARBONDATA-3913] Table level dateformat, timestampformat support

2020-07-24 Thread GitBox
QiangCai commented on pull request #3849: URL: https://github.com/apache/carbondata/pull/3849#issuecomment-663387021 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3849: [CARBONDATA-3913] Table level dateformat, timestampformat support

2020-07-24 Thread GitBox
asfgit closed pull request #3849: URL: https://github.com/apache/carbondata/pull/3849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go