[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: Repair SI Command

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-665651226 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3871: [WIP] Fix multiple issues

2020-07-29 Thread GitBox
ajantha-bhat opened a new pull request #3871: URL: https://github.com/apache/carbondata/pull/3871 ### Why is this PR needed? Auto compaction/minor compaction was happening multiple times for same segments. Executor (for merge index and merge data files) segmentfile write

[GitHub] [carbondata] QiangCai opened a new pull request #3872: [CARBONDATA-3889] Move java files into the java source directory

2020-07-29 Thread GitBox
QiangCai opened a new pull request #3872: URL: https://github.com/apache/carbondata/pull/3872 ### Why is this PR needed? There are java files under the scala source directory ### What changes were proposed in this PR? 1. Move java files into the java source directory

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3865: [CARBONDATA-3928] Handled the Strings which length is greater than 32000 as a bad record.

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3865: URL: https://github.com/apache/carbondata/pull/3865#issuecomment-665611488 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-29 Thread GitBox
ajantha-bhat commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462270452 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoCarbonVectorizedRecordReader.java ## @@ -176,8 +191,16 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-665593991 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3873: Repair SI Command

2020-07-29 Thread GitBox
vikramahuja1001 opened a new pull request #3873: URL: https://github.com/apache/carbondata/pull/3873 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3871: [WIP] Fix multiple issues

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-665517022 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3873: [WIP] Repair SI Command

2020-07-29 Thread GitBox
vikramahuja1001 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-665784554 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-29 Thread GitBox
ajantha-bhat commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r461597459 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/FillVector.java ## @@ -0,0 +1,345 @@ +/* + * Licensed to the

[GitHub] [carbondata] asfgit closed pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-29 Thread GitBox
asfgit closed pull request #3857: URL: https://github.com/apache/carbondata/pull/3857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] asfgit closed pull request #3860: [CARBONDATA-3889] Cleanup duplicated code in carbondata-core module

2020-07-29 Thread GitBox
asfgit closed pull request #3860: URL: https://github.com/apache/carbondata/pull/3860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] QiangCai opened a new pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-29 Thread GitBox
QiangCai opened a new pull request #3867: URL: https://github.com/apache/carbondata/pull/3867 ### Why is this PR needed? There are many typos in carbondata-spark module. ### What changes were proposed in this PR? Cleanup code typo in carbondata-spark module ###

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-664852730 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akkio-97 opened a new pull request #3869: Exception added for index creation on long string columns

2020-07-29 Thread GitBox
akkio-97 opened a new pull request #3869: URL: https://github.com/apache/carbondata/pull/3869 ### Why is this PR needed? Index creation for long string columns are not yet supported. ### What changes were proposed in this PR? Exceptions are thrown if user tries to create

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-29 Thread GitBox
VenuReddy2103 commented on a change in pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#discussion_r461385726 ## File path: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java ## @@ -116,7 +117,10 @@ private static

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-29 Thread GitBox
kevinjmh commented on a change in pull request #3867: URL: https://github.com/apache/carbondata/pull/3867#discussion_r462058720 ## File path: integration/spark/src/main/scala/org/apache/carbondata/view/MVRefresher.scala ## @@ -68,19 +68,19 @@ object MVRefresher { //

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-29 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r461343500 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -112,6 +238,23 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3869: Exception added for index creation on long string columns

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3869: URL: https://github.com/apache/carbondata/pull/3869#issuecomment-665263897 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (CARBONDATA-3914) We are getting the below error when executing select query on a carbon table when no data is returned from hive beeline.

2020-07-29 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3914. - Fix Version/s: 2.1.0 Resolution: Fixed > We are getting the below

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-664820504 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#issuecomment-664827883 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akkio-97 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-07-29 Thread GitBox
akkio-97 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-665281574 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-29 Thread GitBox
VenuReddy2103 commented on pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#issuecomment-665140464 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [carbondata] niuge01 commented on pull request #3864: [HOTFIX] Show Segment with stage returns empty

2020-07-29 Thread GitBox
niuge01 commented on pull request #3864: URL: https://github.com/apache/carbondata/pull/3864#issuecomment-664720572 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-665065271 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-29 Thread GitBox
Indhumathi27 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-664772987 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai opened a new pull request #3870: [CARBONDATA-3930] Fix DataLoadingException in MVExample

2020-07-29 Thread GitBox
QiangCai opened a new pull request #3870: URL: https://github.com/apache/carbondata/pull/3870 ### Why is this PR needed? MVExample is throwing DataLoadingException because the path of the input file is wrong. ### What changes were proposed in this PR? 1. Correct the path

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-665015972 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3864: [HOTFIX] Show Segment with stage returns empty

2020-07-29 Thread GitBox
asfgit closed pull request #3864: URL: https://github.com/apache/carbondata/pull/3864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-29 Thread GitBox
Indhumathi27 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r461655861 ## File path: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java ## @@ -98,6 +98,14 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3867: URL: https://github.com/apache/carbondata/pull/3867#issuecomment-665157764 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-29 Thread GitBox
VenuReddy2103 commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r461692563 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/command/SICreationCommand.scala ## @@ -210,6 +210,14 @@

[GitHub] [carbondata] ajantha-bhat commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-29 Thread GitBox
ajantha-bhat commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-665473589 @akkio-97 : Also change description to presto supporting array columns reading This is an automated

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3870: [CARBONDATA-3930] Fix DataLoadingException in MVExample

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3870: URL: https://github.com/apache/carbondata/pull/3870#issuecomment-665433865 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akkio-97 opened a new pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-07-29 Thread GitBox
akkio-97 opened a new pull request #3866: URL: https://github.com/apache/carbondata/pull/3866 ### Why is this PR needed? Data load fails because the spark-shell code uses carbonSessions instead of carbonExtensions. ### What changes were proposed in this PR? Have made use

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-665169330 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-29 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r461474532 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ## @@ -823,6 +834,30 @@ public void write(Object object)

[GitHub] [carbondata] Karan980 commented on pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-29 Thread GitBox
Karan980 commented on pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#issuecomment-664850764 @VenuReddy2103 Done This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai opened a new pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-29 Thread GitBox
QiangCai opened a new pull request #3868: URL: https://github.com/apache/carbondata/pull/3868 ### Why is this PR needed? 1. Redundant 'if' statement 2. Array access many times in for loop 3. Repeated switch branch 4. Use StringBuffer ### What changes were proposed in

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-29 Thread GitBox
kevinjmh commented on a change in pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#discussion_r461986247 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java ## @@ -283,8 +283,8 @@ public BigDecimal

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#issuecomment-665182981 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akkio-97 closed pull request #3859: [CARBONDATA-3921] SI load fails with 'unable to get filestatus error' in concurrent scenario

2020-07-29 Thread GitBox
akkio-97 closed pull request #3859: URL: https://github.com/apache/carbondata/pull/3859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3865: [CARBONDATA-3928] Handled the Strings which length is greater than 32000 as a bad record.

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3865: URL: https://github.com/apache/carbondata/pull/3865#issuecomment-665003765 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3787: [WIP][CARBONDATA-3923] support global sort for SI

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3787: URL: https://github.com/apache/carbondata/pull/3787#issuecomment-665125549 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-664592745 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akashrn5 commented on pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

2020-07-29 Thread GitBox
akashrn5 commented on pull request #3857: URL: https://github.com/apache/carbondata/pull/3857#issuecomment-664777049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3856: URL: https://github.com/apache/carbondata/pull/3856#issuecomment-665195269 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (CARBONDATA-3931) Secondary index with index column as DateType gives wrong results

2020-07-29 Thread Indhumathi Muthumurugesh (Jira)
Indhumathi Muthumurugesh created CARBONDATA-3931: Summary: Secondary index with index column as DateType gives wrong results Key: CARBONDATA-3931 URL:

[GitHub] [carbondata] Indhumathi27 opened a new pull request #3874: [CARBONDATA-3931]Fix Secondary index with index column as DateType giving wrong results

2020-07-29 Thread GitBox
Indhumathi27 opened a new pull request #3874: URL: https://github.com/apache/carbondata/pull/3874 ### Why is this PR needed? On data load to SI with date type, dictionary values is loaded from factToIndexDictColumnMapping instead of getting from wrapper. ### What changes were

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3869: Exception added for index creation on long string columns

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3869: URL: https://github.com/apache/carbondata/pull/3869#issuecomment-665577522 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3872: [CARBONDATA-3889] Move java files into the java source directory

2020-07-29 Thread GitBox
CarbonDataQA1 commented on pull request #3872: URL: https://github.com/apache/carbondata/pull/3872#issuecomment-665604813 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-29 Thread GitBox
ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r462128423 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/command/SICreationCommand.scala ## @@ -210,6 +210,14 @@