[GitHub] [carbondata] Kejian-Li commented on pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
Kejian-Li commented on pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#issuecomment-706813764 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] marchpure commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-11 Thread GitBox
marchpure commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-706815843 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai commented on pull request #3972: [WIP]Launch same number of task as select query for insert into select and ctas cases when target table is of no_sort

2020-10-11 Thread GitBox
QiangCai commented on pull request #3972: URL: https://github.com/apache/carbondata/pull/3972#issuecomment-706830943 How about load data of no_sort? This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] ajantha-bhat commented on pull request #3948: [WIP] Analyze random 11 testcase failure in CI

2020-10-11 Thread GitBox
ajantha-bhat commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706829982 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Indhumathi27 commented on pull request #3966: [CARBONDATA-4023] Create MV failed on table with geospatial index using carbonsession.

2020-10-11 Thread GitBox
Indhumathi27 commented on pull request #3966: URL: https://github.com/apache/carbondata/pull/3966#issuecomment-706852014 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3950: URL: https://github.com/apache/carbondata/pull/3950#issuecomment-706851626 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2614/

[GitHub] [carbondata] kunal642 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example

2020-10-11 Thread GitBox
kunal642 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-706868808 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be copied to after

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-706777285 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] marchpure commented on a change in pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
marchpure commented on a change in pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#discussion_r503031223 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/StageInputCollector.java ## @@ -65,8 +65,15 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#issuecomment-706849697 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2611/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-11 Thread GitBox
akashrn5 commented on a change in pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#discussion_r503037126 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -267,9 +266,8 @@ object

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-11 Thread GitBox
akashrn5 commented on a change in pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#discussion_r503037126 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -267,9 +266,8 @@ object

[jira] [Created] (CARBONDATA-4028) Fail to unlock during update

2020-10-11 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4028: --- Summary: Fail to unlock during update Key: CARBONDATA-4028 URL: https://issues.apache.org/jira/browse/CARBONDATA-4028 Project: CarbonData Issue Type:

[GitHub] [carbondata] ajantha-bhat commented on pull request #3948: [WIP] Analyze random 11 testcase failure in CI

2020-10-11 Thread GitBox
ajantha-bhat commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706862593 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (CARBONDATA-4027) Fix the wrong modifiedtime of loading files in insert stage

2020-10-11 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4027: --- Summary: Fix the wrong modifiedtime of loading files in insert stage Key: CARBONDATA-4027 URL: https://issues.apache.org/jira/browse/CARBONDATA-4027 Project:

[GitHub] [carbondata] Indhumathi27 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.

2020-10-11 Thread GitBox
Indhumathi27 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-706845951 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#issuecomment-706847834 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4361/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3950: URL: https://github.com/apache/carbondata/pull/3950#issuecomment-706854702 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4364/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [WIP] Analyze random 11 testcase failure in CI

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706858431 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4362/

[GitHub] [carbondata] marchpure opened a new pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-11 Thread GitBox
marchpure opened a new pull request #3978: URL: https://github.com/apache/carbondata/pull/3978 ### Why is this PR needed? 1. In the update flow, we unpresist dataset before unlocking. unlock will fail once the dataset unpresist is interrupted. 2. cleanStaleDeltaFiles will hold

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#issuecomment-706873519 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4363/

[GitHub] [carbondata] ajantha-bhat commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-11 Thread GitBox
ajantha-bhat commented on pull request #3924: URL: https://github.com/apache/carbondata/pull/3924#issuecomment-706872243 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai commented on a change in pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
QiangCai commented on a change in pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#discussion_r503000562 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala ## @@ -123,6 +123,9 @@ object IndexServer extends

[GitHub] [carbondata] marchpure opened a new pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-11 Thread GitBox
marchpure opened a new pull request #3977: URL: https://github.com/apache/carbondata/pull/3977 …rt stage ### Why is this PR needed? In the insertstage flow, there is a empty file with suffix '.loading' to mark the stage in the status of 'in processing'. We update the

[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
Kejian-Li commented on a change in pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#discussion_r503000913 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/StageInputCollector.java ## @@ -65,8 +65,15 @@

[GitHub] [carbondata] QiangCai commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-11 Thread GitBox
QiangCai commented on a change in pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#discussion_r503018114 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -267,9 +266,8 @@ object

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-706845337 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4360/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [WIP] Analyze random 11 testcase failure in CI

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706860685 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2612/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-11 Thread GitBox
akashrn5 commented on a change in pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#discussion_r503036710 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -267,9 +266,8 @@ object

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#issuecomment-706875962 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2613/

[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
Kejian-Li commented on a change in pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#discussion_r503000913 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/StageInputCollector.java ## @@ -65,8 +65,15 @@

[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
Kejian-Li commented on a change in pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#discussion_r503000769 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/StageInputCollector.java ## @@ -65,8 +65,15 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-706844880 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2610/

[GitHub] [carbondata] Indhumathi27 closed pull request #3971: [WIP] Do not clean stale data

2020-10-11 Thread GitBox
Indhumathi27 closed pull request #3971: URL: https://github.com/apache/carbondata/pull/3971 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3939: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3939: URL: https://github.com/apache/carbondata/pull/3939#issuecomment-706764153 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4355/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3972: [WIP]Launch same number of task as select query for insert into select and ctas cases when target table is of no_sort

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3972: URL: https://github.com/apache/carbondata/pull/3972#issuecomment-706765787 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2604/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3972: [WIP]Launch same number of task as select query for insert into select and ctas cases when target table is of no_sort

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3972: URL: https://github.com/apache/carbondata/pull/3972#issuecomment-706765963 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4354/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#issuecomment-706766379 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2606/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#issuecomment-706767341 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4356/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3939: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3939: URL: https://github.com/apache/carbondata/pull/3939#issuecomment-706767318 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2605/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3972: [WIP]Launch same number of task as select query for insert into select and ctas cases when target table is of no_sort

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3972: URL: https://github.com/apache/carbondata/pull/3972#issuecomment-706705055 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2603/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3972: [WIP]Launch same number of task as select query for insert into select and ctas cases when target table is of no_sort

2020-10-11 Thread GitBox
CarbonDataQA1 commented on pull request #3972: URL: https://github.com/apache/carbondata/pull/3972#issuecomment-706705226 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4353/

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3972: [WIP]Launch same number of task as select query for insert into select and ctas cases when target table is of no_sort

2020-10-11 Thread GitBox
VenuReddy2103 commented on pull request #3972: URL: https://github.com/apache/carbondata/pull/3972#issuecomment-706748561 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] marchpure commented on pull request #3939: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-10-11 Thread GitBox
marchpure commented on pull request #3939: URL: https://github.com/apache/carbondata/pull/3939#issuecomment-706748773 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (CARBONDATA-4026) Thread leakage while Loading

2020-10-11 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4026: --- Summary: Thread leakage while Loading Key: CARBONDATA-4026 URL: https://issues.apache.org/jira/browse/CARBONDATA-4026 Project: CarbonData Issue Type:

[GitHub] [carbondata] marchpure opened a new pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-11 Thread GitBox
marchpure opened a new pull request #3976: URL: https://github.com/apache/carbondata/pull/3976 ### Why is this PR needed? A few code of Inserting/Loading/InsertStage/IndexServer won't shutdown executorservice. leads to thread leakage which will degrade the performance of the

[jira] [Closed] (CARBONDATA-3850) Presto read support for Array datatype

2020-10-11 Thread Akshay (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akshay closed CARBONDATA-3850. -- Resolution: Fixed > Presto read support for Array datatype >

[jira] [Updated] (CARBONDATA-3830) Presto read support for complex columns

2020-10-11 Thread Akshay (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akshay updated CARBONDATA-3830: --- Attachment: (was: Presto Read Support.pdf) > Presto read support for complex columns >

[jira] [Updated] (CARBONDATA-3830) Presto read support for complex columns

2020-10-11 Thread Akshay (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akshay updated CARBONDATA-3830: --- Attachment: Presto Read Support.pdf > Presto read support for complex columns >