[GitHub] [carbondata] marchpure commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox
marchpure commented on pull request #3998: URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716341256 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3998: URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716397293 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2930/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3998: URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716339510 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3998: URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716392135 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4687/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3999: URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716396690 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2931/

[GitHub] [carbondata] marchpure commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
marchpure commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716394909 > @marchpure please update the PR description for MergeIndex changes also I have updated the PR description for MergeIndex changes

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3999: URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716394910 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4688/

[GitHub] [carbondata] marchpure commented on a change in pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
marchpure commented on a change in pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#discussion_r511786746 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/events/MergeIndexEventListener.scala ## @@ -43,11 +43,6 @@ class

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3912: [CARBONDATA-3977] Global sort partitions should be determined dynamically

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3912: URL: https://github.com/apache/carbondata/pull/3912#issuecomment-716994984 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2939/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [CARBONDATA-4044] Fix dirty data in indexfile while IUD with stale data in segment folder

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3999: URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716961859 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4694/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [CARBONDATA-4044] Fix dirty data in indexfile while IUD with stale data in segment folder

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3999: URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716962034 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2937/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-716969729 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4695/

[GitHub] [carbondata] asfgit closed pull request #3875: [CARBONDATA-3934]Support write transactional table with presto.

2020-10-26 Thread GitBox
asfgit closed pull request #3875: URL: https://github.com/apache/carbondata/pull/3875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kunal642 commented on pull request #3970: [CARBONDATA-4007] Fix multiple issues in SDK

2020-10-26 Thread GitBox
kunal642 commented on pull request #3970: URL: https://github.com/apache/carbondata/pull/3970#issuecomment-717002495 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] ajantha-bhat commented on pull request #3994: [CARBONDATA-4040] Fix data mismatch incase of compaction failure and retry success

2020-10-26 Thread GitBox
ajantha-bhat commented on pull request #3994: URL: https://github.com/apache/carbondata/pull/3994#issuecomment-716998184 > Hi, Ajantha. I have fixed this in #3999 , please have a check. @marchpure: I think your PR is not handling all the scenarios, so update scenario and test case

[GitHub] [carbondata] ajantha-bhat commented on pull request #3875: [CARBONDATA-3934]Support write transactional table with presto.

2020-10-26 Thread GitBox
ajantha-bhat commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-716996636 LGTM can be an alpha feature until we support the create table. (because until spark dependency is removed for write, it won't help much for production

[jira] [Resolved] (CARBONDATA-3934) Support insert into command for transactional support

2020-10-26 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3934. -- Fix Version/s: 2.1.0 Resolution: Fixed > Support insert into command for

[GitHub] [carbondata] ajantha-bhat commented on pull request #3916: [CARBONDATA-3935]Support partition table transactional write in presto

2020-10-26 Thread GitBox
ajantha-bhat commented on pull request #3916: URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717003123 @akashrn5 : please rebase as presto write PR is merged This is an automated message from the Apache Git

[GitHub] [carbondata] kunal642 commented on pull request #3996: [DOC] Adjust document for partition table

2020-10-26 Thread GitBox
kunal642 commented on pull request #3996: URL: https://github.com/apache/carbondata/pull/3996#issuecomment-717002812 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (CARBONDATA-4045) Add TPCDS TestCase

2020-10-26 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4045: --- Summary: Add TPCDS TestCase Key: CARBONDATA-4045 URL: https://issues.apache.org/jira/browse/CARBONDATA-4045 Project: CarbonData Issue Type: Test

[jira] [Created] (CARBONDATA-4044) Fix dirty data in indexfile while IUD with stale data in segment folder

2020-10-26 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4044: --- Summary: Fix dirty data in indexfile while IUD with stale data in segment folder Key: CARBONDATA-4044 URL: https://issues.apache.org/jira/browse/CARBONDATA-4044

[GitHub] [carbondata] marchpure commented on pull request #3994: [CARBONDATA-4040] Fix data mismatch incase of compaction failure and retry success

2020-10-26 Thread GitBox
marchpure commented on pull request #3994: URL: https://github.com/apache/carbondata/pull/3994#issuecomment-716933491 Hi, Ajantha. I have fixed this in #3999 , please have a check. This is an automated message from the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-716970186 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2938/

[GitHub] [carbondata] akashrn5 commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox
akashrn5 commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716977104 @marchpure please correct the PR title and please give detailed explanation of the issue and the fix in the PR description.

[GitHub] [carbondata] marchpure commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox
marchpure commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716981130 > @marchpure please correct the PR title and please give detailed explanation of the issue and the fix in the PR description. Yes. I have modified the PR desc as

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3912: [CARBONDATA-3977] Global sort partitions should be determined dynamically

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3912: URL: https://github.com/apache/carbondata/pull/3912#issuecomment-716994724 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4696/

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3875: [CARBONDATA-3934]Support write transactional table with presto.

2020-10-26 Thread GitBox
ajantha-bhat edited a comment on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-716996636 LGTM can be an alpha feature until we support the create table. (because until spark dependency is removed for write, it won't help much for production

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716466945 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4691/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716460174 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2934/

[GitHub] [carbondata] marchpure commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox
marchpure commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716406534 > please do rebase I have do rebase according to your suggestion This is an automated message from

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3999: URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716451904 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2932/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3997: URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716455767 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2933/

[GitHub] [carbondata] marchpure commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox
marchpure commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716406302 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3999: URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716449317 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4689/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3997: URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716454832 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4690/

[GitHub] [carbondata] Indhumathi27 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
Indhumathi27 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716504631 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716555787 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4692/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716556388 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2935/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3997: URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716562736 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4693/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox
CarbonDataQA1 commented on pull request #3997: URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716563917 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2936/

[GitHub] [carbondata] Indhumathi27 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
Indhumathi27 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716593613 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] asfgit closed pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox
asfgit closed pull request #3977: URL: https://github.com/apache/carbondata/pull/3977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (CARBONDATA-4027) Fix the wrong modifiedtime of loading files in insert stage

2020-10-26 Thread Indhumathi Muthu Murugesh (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Indhumathi Muthu Murugesh resolved CARBONDATA-4027. --- Fix Version/s: 2.1.0 Resolution: Fixed > Fix the