[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-763757918 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3562/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-763714150 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3561/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-763710397 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5321/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-763751165 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5322/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764355741 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3563/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764441692 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3566/

[GitHub] [carbondata] kunal642 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2021-01-20 Thread GitBox
kunal642 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-764338208 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2021-01-20 Thread GitBox
asfgit closed pull request #4018: URL: https://github.com/apache/carbondata/pull/4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764410335 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5325/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764431030 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5324/

[GitHub] [carbondata] Indhumathi27 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
Indhumathi27 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764288658 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
akkio-97 commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r561606064 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -325,4 +326,22 @@

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
akkio-97 commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r561605603 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java ## @@ -328,9 +328,29 @@ public BigDecimal

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
akkio-97 commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r561605668 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/SparkStoreCreatorForPresto.scala ## @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764411437 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3565/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764358350 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5323/

[jira] [Resolved] (CARBONDATA-4055) Empty segment created and unnecessary entry to table status in update

2021-01-20 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-4055. -- Fix Version/s: 2.1.1 Resolution: Fixed > Empty segment created and

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764434170 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3564/

[GitHub] [carbondata] Karan980 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-20 Thread GitBox
Karan980 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764436367 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764440517 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5326/

[GitHub] [carbondata] Karan980 commented on a change in pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-20 Thread GitBox
Karan980 commented on a change in pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#discussion_r561607408 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala ## @@ -294,6 +297,49 @@

[GitHub] [carbondata] kunal642 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-20 Thread GitBox
kunal642 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764380634 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Indhumathi27 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-20 Thread GitBox
Indhumathi27 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764447779 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4064: URL: https://github.com/apache/carbondata/pull/4064#issuecomment-763452360 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5319/

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #4075: [CARBONDATA-4105] Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread GitBox
ajantha-bhat edited a comment on pull request #4075: URL: https://github.com/apache/carbondata/pull/4075#issuecomment-763503555 @Karan980 : Here in a spark cluster JVM itself you are running SDK read and write. Hence this problem. Ideally, when you run SDK in the cluster it will span up

[GitHub] [carbondata] ajantha-bhat commented on pull request #4075: [CARBONDATA-4105] Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread GitBox
ajantha-bhat commented on pull request #4075: URL: https://github.com/apache/carbondata/pull/4075#issuecomment-763503555 @Karan980 : Here in a spark clsuter jvm itself you are running sdk read and write. Hence this problem. Ideally when you run SDK in cluster it will span up it's own

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-763434524 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3558/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-763434195 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5318/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4064: URL: https://github.com/apache/carbondata/pull/4064#issuecomment-763458823 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3559/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4075: [CARBONDATA-4105] Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread GitBox
ajantha-bhat commented on a change in pull request #4075: URL: https://github.com/apache/carbondata/pull/4075#discussion_r560817709 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/TableBlockIndexUniqueIdentifier.java ## @@ -45,7 +45,8 @@ public

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4075: [CARBONDATA-4105] Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread GitBox
ajantha-bhat commented on a change in pull request #4075: URL: https://github.com/apache/carbondata/pull/4075#discussion_r560817709 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/TableBlockIndexUniqueIdentifier.java ## @@ -45,7 +45,8 @@ public

[jira] [Commented] (CARBONDATA-4105) Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268547#comment-17268547 ] Ajantha Bhat commented on CARBONDATA-4105: -- Here in a spark cluster JVM itself you are

[GitHub] [carbondata] Karan980 closed pull request #4075: [CARBONDATA-4105] Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread GitBox
Karan980 closed pull request #4075: URL: https://github.com/apache/carbondata/pull/4075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] Karan980 commented on pull request #4075: [CARBONDATA-4105] Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread GitBox
Karan980 commented on pull request #4075: URL: https://github.com/apache/carbondata/pull/4075#issuecomment-763560080 ok, closing this issue as cache will not be shared if both are different JVM processes. This is an

[jira] [Closed] (CARBONDATA-4105) Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-20 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat closed CARBONDATA-4105. Resolution: Not A Bug > Select * query fails after a SDK written segment is added by

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-763603712 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3560/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-20 Thread GitBox
CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-763604307 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5320/