[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567657351 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/mergedata/CarbonDataFileMergeTestCaseOnSI.scala ## @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770666065 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5387/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770666940 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3627/

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567670649 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/mergedata/CarbonDataFileMergeTestCaseOnSI.scala ## @@

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567670208 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/TestQueryWithColumnMetCacheAndCacheLevelProperty.scala

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567671338 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestCarbonInternalMetastore.scala ## @@

[GitHub] [carbondata] Karan980 commented on a change in pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
Karan980 commented on a change in pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#discussion_r567678484 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala ## @@ -678,9 +678,11 @@ object

[GitHub] [carbondata] Karan980 commented on a change in pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
Karan980 commented on a change in pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#discussion_r567678752 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -580,34 +581,39 @@ object

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770768986 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3629/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#issuecomment-770777837 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3631/

[GitHub] [carbondata] Karan980 commented on a change in pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
Karan980 commented on a change in pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#discussion_r567760931 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala ## @@ -678,9 +678,14 @@ object

[GitHub] [carbondata] nihal0107 closed pull request #4085: [CARBONDATA-4114] Handled empty result for select query result with load command

2021-02-01 Thread GitBox
nihal0107 closed pull request #4085: URL: https://github.com/apache/carbondata/pull/4085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] nihal0107 commented on pull request #4085: [CARBONDATA-4114] Handled empty result for select query result with load command

2021-02-01 Thread GitBox
nihal0107 commented on pull request #4085: URL: https://github.com/apache/carbondata/pull/4085#issuecomment-770814402 Getting handled as part of #4084 This is an automated message from the Apache Git Service. To respond to

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
ShreelekhyaG commented on a change in pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#discussion_r567812890 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexInputFormat.java ## @@ -159,6 +162,19 @@ public void

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770854884 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5394/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770859314 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3634/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770844763 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3632/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770849879 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5393/

[GitHub] [carbondata] nihal0107 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770853160 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
Indhumathi27 commented on a change in pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#discussion_r567844159 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/load/CarbonInternalLoaderUtil.java ## @@ -51,9 +51,10 @@

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
Indhumathi27 commented on a change in pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#discussion_r567844159 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/load/CarbonInternalLoaderUtil.java ## @@ -51,9 +51,10 @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#issuecomment-770909939 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5395/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#issuecomment-770848486 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5392/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#issuecomment-770851951 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3633/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770910752 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5396/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770940187 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5397/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770914272 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3636/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
ShreelekhyaG commented on a change in pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#discussion_r567903474 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/load/CarbonInternalLoaderUtil.java ## @@ -51,9 +51,10 @@

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
ShreelekhyaG commented on a change in pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#discussion_r567904349 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java ## @@ -221,7 +221,7 @@ public void

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770943664 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3637/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#issuecomment-771004121 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3638/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#issuecomment-770913921 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3635/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4080: [CARBONDATA-4111] Filter query having invalid results after add segment to table having SI with Indexserver

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4080: URL: https://github.com/apache/carbondata/pull/4080#issuecomment-770996367 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5398/

[GitHub] [carbondata] Karan980 commented on a change in pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
Karan980 commented on a change in pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#discussion_r567678357 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -580,34 +581,39 @@ object

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
Indhumathi27 commented on a change in pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#discussion_r567695612 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala ## @@ -678,9 +678,14 @@ object

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567759675 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestCarbonInternalMetastore.scala ## @@

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567759908 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/DropTableTest.scala ## @@ -88,4 +90,16 @@

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567674967 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestCreateIndexWithLoadAndCompaction.scala

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770739979 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3628/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-770762628 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5389/

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r567675597 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondaryIndex.scala ## @@ -577,6

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-770739204 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5388/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4083: URL: https://github.com/apache/carbondata/pull/4083#issuecomment-770771606 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5391/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-771436357 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5401/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-771437007 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3641/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-771389326 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5400/

[GitHub] [carbondata] kunal642 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

2021-02-01 Thread GitBox
kunal642 commented on pull request #4084: URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771412881 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] nihal0107 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
nihal0107 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-771385539 If we enable the property `ENABLE_AUTO_LOAD_MERGE` then which segment id are we planning to show, the segment generated after compaction or before compaction? Better to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-771318129 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5399/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-771387700 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3640/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

2021-02-01 Thread GitBox
CarbonDataQA2 commented on pull request #4086: URL: https://github.com/apache/carbondata/pull/4086#issuecomment-771321901 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3639/

[GitHub] [carbondata] nihal0107 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-771354445 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] nihal0107 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-02-01 Thread GitBox
nihal0107 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-771393400 retest this please This is an automated message from the Apache Git Service. To respond to the message,