[GitHub] carbondata pull request #1575: [CARBONDATA-1698]Adding support for table lev...

2017-11-27 Thread Xaprice
GitHub user Xaprice opened a pull request: https://github.com/apache/carbondata/pull/1575 [CARBONDATA-1698]Adding support for table level compaction configuration Adding support for table level compaction configuration You can merge this pull request into a Git repository

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-11-30 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [x] Any interfaces changed? **no** - [x] Any backward

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-11-30 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 @jackylk User can create table by SQL below: ``` CREATE TABLE tableWithCompactionOptions( intField INT, stringField STRING ) STORED BY 'carbondata

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-11-30 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 retest this please ---

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-12-04 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 fix code style problem, retest this please ---

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-12-05 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 retest this please ---

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-12-15 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 Hi @chenliang613 , can you please take a look? ---

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-12-15 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 retest this please ---

[GitHub] carbondata pull request #:

2017-11-21 Thread Xaprice
Github user Xaprice commented on the pull request: https://github.com/apache/carbondata/commit/8511ffa1572d15c4dc7141c8833bdee799cbf15f#commitcomment-25769606 [CARBONDATA-1792]add example for data management ---

[GitHub] carbondata pull request #1547: [CARBONDATA-1792]add example of data manageme...

2017-11-21 Thread Xaprice
GitHub user Xaprice opened a pull request: https://github.com/apache/carbondata/pull/1547 [CARBONDATA-1792]add example of data management for Spark2.X [CARBONDATA-1792]add example of data management for Spark2.X You can merge this pull request into a Git repository by running

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-12-04 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 retest this please ---

[GitHub] carbondata pull request #1575: [CARBONDATA-1698]Adding support for table lev...

2017-12-04 Thread Xaprice
Github user Xaprice commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1575#discussion_r154612395 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -863,6 +863,16 @@ public static final

[GitHub] carbondata issue #1812: [CARBONDATA-2033]Support user specified segments in ...

2018-04-27 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 @manishgupta88, I've submitted some changes, have a look please. ---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]Support user specified segments in ...

2018-04-27 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 I've raised a sub-task for custom compaction for child tables/datamaps: https://issues.apache.org/jira/browse/CARBONDATA-2412 ---

[GitHub] carbondata pull request #1812: [CARBONDATA-2033]support user specified segme...

2018-01-16 Thread Xaprice
GitHub user Xaprice opened a pull request: https://github.com/apache/carbondata/pull/1812 [CARBONDATA-2033]support user specified segments in major compation Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily

[GitHub] carbondata issue #1812: [CARBONDATA-2033]support user specified segments in ...

2018-01-16 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 Hi @chenliang613 , can you please take a look? ---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]support user specified segments in ...

2018-02-01 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 @ravipesala Compacting adjacent segments is certainly the best practice in most cases. But is it not flexible enough to take it as a mandatory rule? ---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]support user specified segments in ...

2018-02-01 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 @chenliang613 For question 1: I thought minor compaction are mainly used in auto-merging scenario. But after reconsidering this feature, maybe it's better to support both major and minor

[GitHub] carbondata issue #1575: [CARBONDATA-1698]Adding support for table level comp...

2017-12-20 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1575 retest this please ---

[GitHub] carbondata pull request #1575: [CARBONDATA-1698]Adding support for table lev...

2017-12-20 Thread Xaprice
Github user Xaprice commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1575#discussion_r158186274 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -205,7 +205,8 @@ object

[GitHub] carbondata pull request #2620: [CARBONDATA-2839] Add custom compaction examp...

2018-08-09 Thread Xaprice
Github user Xaprice commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2620#discussion_r208840858 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CustomCompactionExample.scala --- @@ -0,0 +1,69 @@ +package

[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example

2018-08-09 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 @xuchuanyin, ‘CUSTOM COMPACTION’ is a new compaction type in addition to MAJOR and MINOR COMPACTION. When doing custom compaction, user can directly specify segment ids to be merged. ---

[GitHub] carbondata pull request #2620: [CARBONDATA-2839] Add custom compaction examp...

2018-08-08 Thread Xaprice
GitHub user Xaprice opened a pull request: https://github.com/apache/carbondata/pull/2620 [CARBONDATA-2839] Add custom compaction example Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ x ] Any interfaces

[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example

2018-08-10 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 retest this please ---

[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example

2018-08-10 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 retest this please ---

[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example

2018-08-10 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 @chenliang613, please take a look. ---

[GitHub] carbondata pull request #2136: [CARBONDATA-2307] Fix OOM issue when using Da...

2018-04-03 Thread Xaprice
GitHub user Xaprice opened a pull request: https://github.com/apache/carbondata/pull/2136 [CARBONDATA-2307] Fix OOM issue when using DataFrame.coalesce Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [x] Any

[GitHub] carbondata pull request #2136: [CARBONDATA-2307] Fix OOM issue when using Da...

2018-04-08 Thread Xaprice
Github user Xaprice commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2136#discussion_r179941484 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -402,7 +402,7 @@ class CarbonScanRDD

[GitHub] carbondata issue #2136: [CARBONDATA-2307] Fix OOM issue when using DataFrame...

2018-04-10 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2136 retest this please ---

[GitHub] carbondata issue #2136: [CARBONDATA-2307] Fix OOM issue when using DataFrame...

2018-04-10 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2136 hi, @manishgupta88 , please take a look? ---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]Support user specified segments in ...

2018-04-23 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 retest this please ---

[GitHub] carbondata issue #2136: [CARBONDATA-2307] Fix OOM issue when using DataFrame...

2018-04-04 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2136 retest this please ---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]Support user specified segments in ...

2018-03-01 Thread Xaprice
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/1812 retest this please ---