[GitHub] incubator-carbondata pull request #823: [CARBONDATA-964] Undate FAQs docment

2017-04-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/823#discussion_r112704501 --- Diff: docs/faq.md --- @@ -74,4 +75,57 @@ The property carbon.lock.type configuration specifies the type of lock to be acq

[GitHub] incubator-carbondata pull request #823: [CARBONDATA-964] Undate FAQs docment

2017-04-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/823#discussion_r112704239 --- Diff: docs/faq.md --- @@ -74,4 +75,57 @@ The property carbon.lock.type configuration specifies the type of lock to be acq

[GitHub] carbondata issue #1207: [CARBONDATA-1252]Updated load section of configurati...

2017-07-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1207 @sgururajshetty please review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #1193: [CARBONDATA-1327] Add carbon sort column examples

2017-07-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1193 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1134: [CARBONDATA-1262] Remove unnecessary LoadConfigurati...

2017-07-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1134 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1218: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-01 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1218#discussion_r130558828 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -510,9 +511,16 @@ * LOAD_STATUS

[GitHub] carbondata pull request #1226: [CARBONDATA-1205] Use Spark 2.1 as default fr...

2017-08-02 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1226 [CARBONDATA-1205] Use Spark 2.1 as default from 1.2.0 onwards From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom

[GitHub] carbondata issue #1192: [CARBONDATA-940] alter table add/split partition for...

2017-08-02 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1192 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-02 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1214 @cenyuhai you mean: use the listener, it is able to sync up table's meta info between spark and hive: first i create one table with name "table1" in spark-shell se

[GitHub] carbondata issue #1218: [CARBONDATA-1347] Implemented Columnar Reading Of Da...

2017-08-02 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1218 @anubhav100 i tested the performance again , the latest commit "9e67c38f9e2c26a888d1fc1b95c5c23dc6f5839f" is slower than "014e972faad4c51a16473fd965be7428b4bcc55a

[GitHub] carbondata pull request #1226: [CARBONDATA-1205] Use Spark 2.1 as default co...

2017-08-03 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1226#discussion_r131087095 --- Diff: pom.xml --- @@ -401,6 +398,9 @@ spark-2.1 + +true

[GitHub] carbondata issue #1226: [CARBONDATA-1205] Use Spark 2.1 as default compilati...

2017-08-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1226 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1226: [CARBONDATA-1205] Use Spark 2.1 as default compilati...

2017-08-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1226 apache2.1 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1229: [CARBONDATA-1358] Fixed test fails in master branch

2017-08-04 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1229 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1232: Fix compile issues

2017-08-04 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1232 Fix compile issues Fix compile issues with "mvn clean package" You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133377209 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java --- @@ -0,0 +1,103 @@ +package

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133376989 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/BooleanStreamReader.java --- @@ -0,0 +1,31 @@ +package

[GitHub] carbondata issue #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-15 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1258 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1260: [CARBONDATA-1382] Add more test cases for bucket fea...

2017-08-15 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1260 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133370557 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java --- @@ -183,7 +183,7 @@ public String getString

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133372855 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/constants/CarbonCommonConstants.java --- @@ -0,0 +1,1319

[GitHub] carbondata issue #1257: [CARBONDATA-1347] Implemented Columnar Reading Of Da...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1257 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133375796 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/AggregatedMemoryContext.java --- @@ -0,0 +1,62

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133375914 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/LocalMemoryContext.java --- @@ -0,0 +1,40

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133375740 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/AbstractAggregatedMemoryContext.java --- @@ -0,0 +1,37

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133377510 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java --- @@ -0,0 +1,103 @@ +package

[GitHub] carbondata pull request #1260: [CARBONDATA-1382] Add more test cases for buc...

2017-08-15 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1260 [CARBONDATA-1382] Add more test cases for bucket feature 1.Add more test cases for bucket feature 2.Optimize some test cases's data load method. You can merge this pull request

[GitHub] carbondata issue #1255: [CARBONDATA-1375] clean hive pom

2017-08-15 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1255 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1236 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1236 @anubhav100 i prefer to using steven-qin's pull request, because steven-qin fix it earlier. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] carbondata issue #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1258 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1251: [CARBONDATA-1372]Fix link error in CarbonData docume...

2017-08-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1251 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1251: [CARBONDATA-1372]Fix link error in CarbonData docume...

2017-08-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1251 i tested it , the link is working fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-17 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1231 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1231 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1142 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1162#discussion_r126872536 --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] added example for update an...

2017-07-11 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r126856684 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,183

[GitHub] carbondata issue #1159: [CARBONDATA-1274] added example for update and delet...

2017-07-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 @mayunSaicmotor Please change PR title to : Adds example for update and delete with Spark 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1162#discussion_r126872523 --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed

[GitHub] carbondata issue #1156: [CARBONDATA-1279] Push down for some select queries ...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1156 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1159: [CARBONDATA-1274] Adds example for update and delete...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1170: [CARBONDATA-1219] Documentation - not supported high...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1170 @sgururajshetty please review it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #791: [CARBONDATA-920] Updated useful-tips-on-carbondata.md

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/791 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1154: [CARBONDATA-1285] resolved compilation error in hive...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1154 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-10 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1142 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126273765 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -111,58 +108,46 @@ private void initialize

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126274038 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java --- @@ -0,0 +1,288

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126273657 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -444,9 +444,14 @@ protected Expression

[GitHub] carbondata pull request #1150: [CARBONDATA-1280] Solve HiveExample dependenc...

2017-07-08 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1150 [CARBONDATA-1280] Solve HiveExample dependency issues and fix spark 1.6 CI Solve HiveExample dependency issues and fix spark 1.6 CI You can merge this pull request into a Git repository

[GitHub] carbondata pull request #1151: fix doc

2017-07-08 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1151 fix doc fix doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/carbondata patch-3 Alternatively you can review

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127114360 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127112225 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127112410 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127111519 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata issue #1154: [CARBONDATA-1285] resolved compilation error in hive...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1154 @anubhav100 i cam compile successfully on current master. so this pr is for fixing compilation issues or HiveExample issues ? --- If your project is set up for it, you can reply

[GitHub] carbondata issue #1140: [CARBONDATA-1219] Remove high.cardinality.row.count....

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1140 please solve the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #1159: [CARBONDATA-1274] Adds example for update and delete...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 @mayunSaicmotor In the future, to avoid conflict , please assign JIRA to yourself if you plan to work on this PR. @anubhav100 my side is very appreciating your effort, thanks for your

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1142 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

2017-07-11 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1162 [CARBONDATA-1295] Optimize test cases,merge three QueryTest class into one Optimize test cases,merge three QueryTest class into one, and update related code. You can merge this pull

[GitHub] carbondata issue #994: [CARBONDATA-933]Added Compare Test For BenchMarking O...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/994 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1154: [CARBONDATA-1285] resolved compilation error ...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1154#discussion_r127138413 --- Diff: integration/hive/pom.xml --- @@ -94,6 +94,21 @@ +org.apache.hive

[GitHub] carbondata issue #912: [CARBONDATA-1048] Updated Hive Guide

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/912 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1154: [CARBONDATA-1285] resolved compilation error in hive...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1154 I tested it , got the below log msg : 2017-07-13 14:45:59 WARN ShellBasedUnixGroupsMapping:86 - got exception trying to get groups for user anonymous org.apache.hadoop.util.Shell

[GitHub] carbondata issue #1156: [CARBONDATA-1279] Push down for queries like "%xxx" ...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1156 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1159: [CARBONDATA-1274] Adds example for update and delete...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1184: [CARBONDATA-1314] Fix scalatest issues

2017-07-18 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1184 [CARBONDATA-1314] Fix scalatest issues Fix scalatest issues, as below : Error:(238, 16) can't expand macros compiled by previous versions of Scala assert(false) You can

[GitHub] carbondata issue #1175: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1175 @xuchuanyin please squash all commits to one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1177: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-18 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1177 @xuchuanyin Thanks for your very good PR. A couple comments: 1. How to enable this feature(how to use), please consider updating the related document accordingly 2. Please

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-18 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128147381 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1308,6 +1308,18 @@ public static

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128556528 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/UnsafeSortDataRows.java --- @@ -345,9 +350,12 @@ public

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128558208 --- Diff: integration/spark-common-test/src/test/resources/multi_dir/data.csv --- @@ -0,0 +1,10 @@ +1,name1 +2,name2 --- End diff

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128555999 --- Diff: docs/useful-tips-on-carbondata.md --- @@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the configurations impacting

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128560327 --- Diff: integration/spark-common-test/src/test/scala/org/apache/spark/util/SparkUtil4Test.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed

[GitHub] carbondata pull request #1186: [CARBONDATA-1310]Merge test code for AddColum...

2017-07-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1186#discussion_r128705965 --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AddColumnTestCases.scala --- @@ -42,91 +43,263

[GitHub] carbondata issue #1186: [CARBONDATA-1310]Merge test code for AddColumnTestCa...

2017-07-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1186 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1183: [CARBONDATA-1312] fix list partition compare issue

2017-07-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1183 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1173: [CARBONDATA-1209] add partitionId in show partition ...

2017-07-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1186: [CARBONDATA-1310]Merge test code for AddColumnTestCa...

2017-07-22 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1186 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1192: [CARBONDATA-940] alter table add/split partition for...

2017-07-23 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1192 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1198: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1198 LGTM, very good PR! Thanks for your good contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1181: [CARBONDATA-1313] Remove unnecessary measure statist...

2017-07-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1181 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1134: [CARBONDATA-1262] Remove unnecessary LoadConf...

2017-07-27 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1134#discussion_r129874324 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -465,6 +463,29 @@ public static

[GitHub] carbondata issue #1145: [CARBONDATA-1287] remove unnecessary MDK generation

2017-07-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1145 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1200: [Documentation] Fixed the syntax issue in Delete by ...

2017-07-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1200 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1197: [CARBONDATA-1238] Decouple the datatype convert from...

2017-07-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1197 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1193: [CARBONDATA-1327] Add carbon sort column exam...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1193#discussion_r129511350 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSortColumnsExample.scala --- @@ -0,0 +1,126

[GitHub] carbondata pull request #1190: [CARBONDATA-1323] Presto Optimization for Int...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1190#discussion_r129528008 --- Diff: integration/presto/pom.xml --- @@ -228,6 +228,33 @@ true

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r129514137 --- Diff: conf/carbon.properties.template --- @@ -42,6 +42,9 @@ carbon.enableXXHash=true #carbon.max.level.cache.size=-1 #enable prefetch

[GitHub] carbondata issue #1196: Rebase datamap onto master

2017-07-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1196 please change the PR name to : Rebase datamap branch onto master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] carbondata pull request #1197: [CARBONDATA-1238] Decouple the datatype conve...

2017-07-26 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1197 [CARBONDATA-1238] Decouple the datatype convert from Spark code in core module Decouple the datatype convert from Spark code in core module. You can merge this pull request into a Git

[GitHub] carbondata pull request #1193: [CARBONDATA-1327] Add carbon sort column exam...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1193#discussion_r129508099 --- Diff: docs/ddl-operation-on-carbondata.md --- @@ -101,6 +101,14 @@ The following DDL operations are supported in CarbonData

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r129513477 --- Diff: integration/spark-common-test/src/test/resources/partition_data.csv --- @@ -0,0 +1,27 @@ +id,vin,logdate,phonenumber,country,area

[GitHub] carbondata pull request #1193: [CARBONDATA-1327] Add carbon sort column exam...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1193#discussion_r129509969 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSortColumnsExample.scala --- @@ -0,0 +1,126

[GitHub] carbondata issue #1110: [CARBONDATA-1238] Decouple the datatype convert in c...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1110 raise a new PR #1197 , close the old one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #1110: [CARBONDATA-1238] Decouple the datatype conve...

2017-07-26 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/carbondata/pull/1110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1195: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1195 @xuchuanyin everything looks ok, please do rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1198: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1198 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1197: [CARBONDATA-1238] Decouple the datatype conve...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1197#discussion_r129736254 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/util/SparkDataTypeConverterImp.java --- @@ -0,0 +1,49

  1   2   3   4   5   6   7   8   >