Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/830
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1212#discussion_r130220711
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -253,13 +253,13 @@ abstract class
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1210
To avoid passing big object to executor, now CarbonScanRDD will serialize
TableInfo into serializedTableInfo and send to executor. The tableInfo val in
the constructor is only used in driver
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1210
To avoid passing big object to executor, now CarbonScanRDD will serialize
TableInfo into serializedTableInfo and send to executor. The tableInfo val in
the constructor is only used in driver
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1211
[CARBONDATA-1339] CarbonTableInputFormat should use serialized TableInfo
When setting TableInfo, CarbonTableInputFormat should use serialized
TableInfo. Otherwise it will fail because
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1210#discussion_r130222714
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -254,7 +254,7 @@ class CarbonScanRDD
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1197
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1227
Overwrite
When user issued insert overwrite command, it should delete the file
immediately to avoid stale folders.
This PR implements this behavior.
You can merge this pull request
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131057207
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -107,6 +107,7 @@
// comma separated list of input
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131058061
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/spliter/CarbonDataSpliterUtil.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131057020
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonPartitionExample.scala
---
@@ -101,17 +126,40 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131057576
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -321,6 +321,84 @@ private AbsoluteTableIdentifier
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131058295
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -184,6 +189,161 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131058343
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -184,6 +189,161 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131059448
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -184,6 +189,161 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131059447
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -345,6 +365,65 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131059444
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -345,6 +365,65 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1219#discussion_r131060005
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -234,3 +233,8 @@ scenarios. After the completion of POC, some of the
configurations impacting
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1224
yes, you can do that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1224
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131059761
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -184,6 +189,161 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131056387
--- Diff: conf/carbon.properties.template ---
@@ -42,6 +42,9 @@ carbon.enableXXHash=true
#carbon.max.level.cache.size=-1
#enable prefetch
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131097020
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -907,25 +906,20 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131153192
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java
---
@@ -312,18 +313,28 @@ public static
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131153070
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -713,16 +714,20 @@ object CommonUtil
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131152011
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -87,6 +87,10 @@ else if
(path.startsWith
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1224
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1134
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1248
[CARBONDATA-1371] Support creating decoder based on encoding metadata in
carbondata file
When creating decoder for column page, it should base on metadata in the
DataChunk2 in carbondata
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1245#discussion_r132364666
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1714,6 +1714,45 @@ public static boolean isValidSortOption(String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1245#discussion_r132364955
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1304,6 +1304,18 @@
*/
public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1240#discussion_r133606402
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/RLECodec.java
---
@@ -0,0 +1,417 @@
+/*
+ * Licensed
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1262
[BUGFIX] Fix ZERO_BYTE_ARRAY constant not found in codegen
CarbonCommonConstant.ZERO_BYTE_ARRAY is used in codegen, it should not be
deleted. This PR add it back
You can merge this pull
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1249
[WIP] Use ColumnPage in reader for measure column
Refactor to use ColumnPage in reader for measure column, delete
MeasureColumnDataChunk class
You can merge this pull request into a Git
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1172
[CARBONDATA-1307] Fix bug for TableInfo serialization problem in cluster
mode
TableInfo serialization has problem when there are scala list in
ColumnSchema, this PR fixed this issue
You can
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1149
LGTM
Test case need to be solved in another PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1160
[WIP] change command to update schema and data separately
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126598615
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -208,17 +215,14 @@ public static void setSegmentsToAccess
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1099
LTGM. Test case failure is because of CI issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126597920
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -18,10 +18,14 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126598004
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java
---
@@ -206,4 +202,68 @@ public void setStorePath(String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126597983
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java
---
@@ -206,4 +202,68 @@ public void setStorePath(String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126598180
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -19,7 +19,14 @@
import java.io.File;
import
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126603318
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/WritableUtil.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126603309
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchema.java
---
@@ -198,4 +201,28 @@ public PartitionInfo
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126603356
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java
---
@@ -206,4 +202,68 @@ public void setStorePath(String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126603344
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java
---
@@ -206,4 +202,68 @@ public void setStorePath(String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126598388
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -101,51 +109,50 @@
private static final String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1146#discussion_r126598933
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
---
@@ -421,4 +418,67 @@ public boolean
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1157
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1157
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1133
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126616780
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -15,9 +15,25 @@
* limitations
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1117
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126616762
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java ---
@@ -29,26 +32,50 @@
*/
public class
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1144
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1146
[WIP] Change Query related RDD to use TableInfo
Currently query related RDD is using CarbonTable which is read from file
system, which introduces unnecessary file read. We can pass
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1168#discussion_r127108842
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -738,27 +739,26 @@ private[sql] case
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1168
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1171
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1181
[CARBONDATA-1313] Remove unnecessary measure statistics
Decimal count and unique value is not used, so removing them in measure
statistics
You can merge this pull request into a Git
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1139
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1145
[WIP] remove unnecessary MDK generation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata mdk
Alternatively
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1099#discussion_r126420383
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/DataMapStoreManager.java
---
@@ -69,32 +72,54 @@ public TableDataMap getDataMap
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1099#discussion_r126424329
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/DataMapFactory.java ---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126428076
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -84,19 +112,28 @@
measurePage = new
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126427558
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -84,19 +112,28 @@
measurePage = new
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126428058
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodedMeasurePage.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126427005
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
@@ -64,15 +63,6 @@ public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126426968
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -15,9 +15,25 @@
* limitations
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1176
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1189#discussion_r128481387
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1264,6 +1264,14 @@
public static
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1189#discussion_r128486494
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -485,8 +487,8 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1189#discussion_r128487079
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -617,4 +621,75 @@ object CommonUtil
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1189#discussion_r128496772
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/util/CleanFiles.scala ---
@@ -29,12 +29,12 @@ import org.apache.carbondata.api.CarbonStore
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1191#discussion_r128890954
--- Diff:
core/src/main/java/org/apache/carbondata/core/mutate/DeleteDeltaBlockletDetails.java
---
@@ -69,9 +69,11 @@ public Integer getPageId
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1194
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1136#discussion_r128918118
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DictDimensionIndexCodec.java
---
@@ -0,0 +1,70
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1136#discussion_r128918164
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java ---
@@ -25,197 +25,142 @@
public class TableSpec
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1196
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1168
@kunal642 can you please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1203
Thanks for working on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1203
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1196
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1197#discussion_r129597130
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/util/SparkDataTypeConverterImp.java
---
@@ -0,0 +1,49
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1197#discussion_r129596893
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -768,29 +818,6 @@ public QueryModel getQueryModel(InputSplit
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r128276064
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java ---
@@ -32,23 +39,37 @@
/**
* maxValue
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1121
[CARBONDATA-1215][BUGFIX] Fix unsafe column page for decimal query
For decimal loading is using variable length column page, in unsafe column
page implementation, there is a bug that the page
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1122#discussion_r125026813
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -691,6 +691,14 @@ abstract class
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1120
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1134
Remove unnecessary LoadConfiguration creation
Currently for every load, `LoadConfiguration` is created twice. This PR
removes one unnecessary creation.
You can merge this pull request
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1064
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1117#discussion_r125271988
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java
---
@@ -99,6 +99,14 @@ public void putBytes(int
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1122
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 3163 matches
Mail list logo
