[GitHub] incubator-carbondata issue #830: [CARBONDATA-969] Don't persist rdd because ...

2017-04-21 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/incubator-carbondata/pull/830 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1212: [CARBONDATA-1340]support tables with only mea...

2017-07-29 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1212#discussion_r130220711 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -253,13 +253,13 @@ abstract class

[GitHub] carbondata issue #1210: [CARBONDATA-1338] deserialized tableInfo at executor...

2017-07-29 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1210 To avoid passing big object to executor, now CarbonScanRDD will serialize TableInfo into serializedTableInfo and send to executor. The tableInfo val in the constructor is only used in driver

[GitHub] carbondata issue #1210: [CARBONDATA-1338] deserialized tableInfo at executor...

2017-07-29 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1210 To avoid passing big object to executor, now CarbonScanRDD will serialize TableInfo into serializedTableInfo and send to executor. The tableInfo val in the constructor is only used in driver

[GitHub] carbondata pull request #1211: [CARBONDATA-1339] CarbonTableInputFormat shou...

2017-07-29 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1211 [CARBONDATA-1339] CarbonTableInputFormat should use serialized TableInfo When setting TableInfo, CarbonTableInputFormat should use serialized TableInfo. Otherwise it will fail because

[GitHub] carbondata pull request #1210: [CARBONDATA-1338] deserialized tableInfo at e...

2017-07-29 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1210#discussion_r130222714 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -254,7 +254,7 @@ class CarbonScanRDD

[GitHub] carbondata issue #1197: [CARBONDATA-1238] Decouple the datatype convert from...

2017-07-28 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1197 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1227: Overwrite

2017-08-03 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1227 Overwrite When user issued insert overwrite command, it should delete the file immediately to avoid stale folders. This PR implements this behavior. You can merge this pull request

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131057207 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -107,6 +107,7 @@ // comma separated list of input

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131058061 --- Diff: processing/src/main/java/org/apache/carbondata/processing/spliter/CarbonDataSpliterUtil.java --- @@ -0,0 +1,40 @@ +/* + * Licensed

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131057020 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonPartitionExample.scala --- @@ -101,17 +126,40 @@ object

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131057576 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -321,6 +321,84 @@ private AbsoluteTableIdentifier

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131058295 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -184,6 +189,161 @@ case class

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131058343 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -184,6 +189,161 @@ case class

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131059448 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -184,6 +189,161 @@ case class

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131059447 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -345,6 +365,65 @@ object

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131059444 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -345,6 +365,65 @@ object

[GitHub] carbondata pull request #1219: [CARBONDATA-1117]updated configuration-parame...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1219#discussion_r131060005 --- Diff: docs/useful-tips-on-carbondata.md --- @@ -234,3 +233,8 @@ scenarios. After the completion of POC, some of the configurations impacting

[GitHub] carbondata issue #1224: [CARBONDATA-1354]Remove the useless restriction of '...

2017-08-02 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1224 yes, you can do that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1224: [CARBONDATA-1354]Remove the useless restriction of '...

2017-08-02 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1224 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131059761 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -184,6 +189,161 @@ case class

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1192#discussion_r131056387 --- Diff: conf/carbon.properties.template --- @@ -42,6 +42,9 @@ carbon.enableXXHash=true #carbon.max.level.cache.size=-1 #enable prefetch

[GitHub] carbondata pull request #1227: [CARBONDATA-1356] Delete stale folder in inse...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1227#discussion_r131097020 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -907,25 +906,20 @@ object

[GitHub] carbondata pull request #1227: [CARBONDATA-1356] Delete stale folder in inse...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1227#discussion_r131153192 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java --- @@ -312,18 +313,28 @@ public static

[GitHub] carbondata pull request #1227: [CARBONDATA-1356] Delete stale folder in inse...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1227#discussion_r131153070 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -713,16 +714,20 @@ object CommonUtil

[GitHub] carbondata pull request #1227: [CARBONDATA-1356] Delete stale folder in inse...

2017-08-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1227#discussion_r131152011 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java --- @@ -87,6 +87,10 @@ else if (path.startsWith

[GitHub] carbondata issue #1224: [CARBONDATA-1354]Remove the useless restriction of '...

2017-08-03 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1224 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1134: [CARBONDATA-1262] Remove unnecessary LoadConfigurati...

2017-08-03 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1134 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata pull request #1248: [CARBONDATA-1371] Support creating decoder ba...

2017-08-09 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1248 [CARBONDATA-1371] Support creating decoder based on encoding metadata in carbondata file When creating decoder for column page, it should base on metadata in the DataChunk2 in carbondata

[GitHub] carbondata pull request #1245: [CARBONDATA-1366]add an option 'carbon.global...

2017-08-09 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1245#discussion_r132364666 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -1714,6 +1714,45 @@ public static boolean isValidSortOption(String

[GitHub] carbondata pull request #1245: [CARBONDATA-1366]add an option 'carbon.global...

2017-08-09 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1245#discussion_r132364955 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1304,6 +1304,18 @@ */ public

[GitHub] carbondata pull request #1240: [CARBONDATA-1365] add RLE codec implementatio...

2017-08-16 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1240#discussion_r133606402 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/RLECodec.java --- @@ -0,0 +1,417 @@ +/* + * Licensed

[GitHub] carbondata pull request #1249: [WIP] Use ColumnPage in reader for measure co...

2017-08-16 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1262: [BUGFIX] Fix ZERO_BYTE_ARRAY constant not fou...

2017-08-16 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1262 [BUGFIX] Fix ZERO_BYTE_ARRAY constant not found in codegen CarbonCommonConstant.ZERO_BYTE_ARRAY is used in codegen, it should not be deleted. This PR add it back You can merge this pull

[GitHub] carbondata pull request #1249: [WIP] Use ColumnPage in reader for measure co...

2017-08-10 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1249 [WIP] Use ColumnPage in reader for measure column Refactor to use ColumnPage in reader for measure column, delete MeasureColumnDataChunk class You can merge this pull request into a Git

[GitHub] carbondata pull request #1172: [CARBONDATA-1307] Fix bug for TableInfo seria...

2017-07-14 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1172 [CARBONDATA-1307] Fix bug for TableInfo serialization problem in cluster mode TableInfo serialization has problem when there are scala list in ColumnSchema, this PR fixed this issue You can

[GitHub] carbondata issue #1149: [CARBONDATA-1284]Implement hive based schema storage...

2017-07-11 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1149 LGTM Test case need to be solved in another PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #1160: [WIP] change command to update schema and dat...

2017-07-11 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1160 [WIP] change command to update schema and data separately You can merge this pull request into a Git repository by running: $ git pull https://github.com/jackylk/incubator-carbondata

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-11 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126598615 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -208,17 +215,14 @@ public static void setSegmentsToAccess

[GitHub] carbondata issue #1099: [CARBONDATA-1232] Datamap implementation for Blockle...

2017-07-10 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1099 LTGM. Test case failure is because of CI issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126597920 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -18,10 +18,14 @@ package

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126598004 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -206,4 +202,68 @@ public void setStorePath(String

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126597983 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -206,4 +202,68 @@ public void setStorePath(String

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126598180 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -19,7 +19,14 @@ import java.io.File; import

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126603318 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/WritableUtil.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126603309 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchema.java --- @@ -198,4 +201,28 @@ public PartitionInfo

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126603356 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -206,4 +202,68 @@ public void setStorePath(String

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126603344 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -206,4 +202,68 @@ public void setStorePath(String

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126598388 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -101,51 +109,50 @@ private static final String

[GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1146#discussion_r126598933 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java --- @@ -421,4 +418,67 @@ public boolean

[GitHub] carbondata issue #1157: [CARBONDATA-1289] remove unused method

2017-07-10 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1157 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1157: remove unused method

2017-07-10 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1157 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1133: [CARBONDATA-1261] Load data sql add 'header' option

2017-07-11 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1133 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126616780 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java --- @@ -15,9 +15,25 @@ * limitations

[GitHub] carbondata issue #1117: [CARBONDATA-757] Big decimal optimization

2017-07-11 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1117 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126616762 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java --- @@ -29,26 +32,50 @@ */ public class

[GitHub] carbondata issue #1144: [CARBONDATA-1273] String datatype will be no diction...

2017-07-11 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1144 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1146: [WIP] Change Query related RDD to use TableIn...

2017-07-08 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1146 [WIP] Change Query related RDD to use TableInfo Currently query related RDD is using CarbonTable which is read from file system, which introduces unnecessary file read. We can pass

[GitHub] carbondata pull request #1160: [CARBONDATA-1301] change command to update sc...

2017-07-12 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1168: [CARBONDATA-1229] restrict drop when loading ...

2017-07-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1168#discussion_r127108842 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -738,27 +739,26 @@ private[sql] case

[GitHub] carbondata issue #1168: [CARBONDATA-1229] restrict drop when loading is in p...

2017-07-12 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1168 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1171: [CARBONDATA-1306] Fixed carbondata crash after using...

2017-07-13 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1171 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1181: [CARBONDATA-1313] Remove unnecessary measure ...

2017-07-18 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1181 [CARBONDATA-1313] Remove unnecessary measure statistics Decimal count and unique value is not used, so removing them in measure statistics You can merge this pull request into a Git

[GitHub] carbondata issue #1139: [CARBONDATA-1267] Add short_int case branch in delta...

2017-07-10 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1139 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1145: [WIP] remove unnecessary MDK generation

2017-07-07 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1145 [WIP] remove unnecessary MDK generation You can merge this pull request into a Git repository by running: $ git pull https://github.com/jackylk/incubator-carbondata mdk Alternatively

[GitHub] carbondata pull request #1099: [CARBONDATA-1232] Datamap implementation for ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1099#discussion_r126420383 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/DataMapStoreManager.java --- @@ -69,32 +72,54 @@ public TableDataMap getDataMap

[GitHub] carbondata pull request #1099: [CARBONDATA-1232] Datamap implementation for ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1099#discussion_r126424329 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/DataMapFactory.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126428076 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -84,19 +112,28 @@ measurePage = new

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126427558 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -84,19 +112,28 @@ measurePage = new

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126428058 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodedMeasurePage.java --- @@ -0,0 +1,88 @@ +/* + * Licensed

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126427005 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java --- @@ -64,15 +63,6 @@ public

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r126426968 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java --- @@ -15,9 +15,25 @@ * limitations

[GitHub] carbondata issue #1176: [CARBONDATA-1311] Added carbon storelocation to spar...

2017-07-18 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1176 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1189: [CARBONDATA-1322] Insert overwrite support an...

2017-07-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1189#discussion_r128481387 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1264,6 +1264,14 @@ public static

[GitHub] carbondata pull request #1189: [CARBONDATA-1322] Insert overwrite support an...

2017-07-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1189#discussion_r128486494 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -485,8 +487,8 @@ case class

[GitHub] carbondata pull request #1189: [CARBONDATA-1322] Insert overwrite support an...

2017-07-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1189#discussion_r128487079 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -617,4 +621,75 @@ object CommonUtil

[GitHub] carbondata pull request #1189: [CARBONDATA-1322] Insert overwrite support an...

2017-07-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1189#discussion_r128496772 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CleanFiles.scala --- @@ -29,12 +29,12 @@ import org.apache.carbondata.api.CarbonStore

[GitHub] carbondata pull request #1172: [CARBONDATA-1307] Fix bug for TableInfo seria...

2017-07-16 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1191: [CARBONDATA-1326] Fixed high priority findbug...

2017-07-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1191#discussion_r128890954 --- Diff: core/src/main/java/org/apache/carbondata/core/mutate/DeleteDeltaBlockletDetails.java --- @@ -69,9 +69,11 @@ public Integer getPageId

[GitHub] carbondata issue #1194: Rebase metadata onto master

2017-07-25 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1194 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1136: [CARBONDATA-1268] Support encoding strategy f...

2017-07-23 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1136#discussion_r128918118 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DictDimensionIndexCodec.java --- @@ -0,0 +1,70

[GitHub] carbondata pull request #1136: [CARBONDATA-1268] Support encoding strategy f...

2017-07-23 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1136#discussion_r128918164 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java --- @@ -25,197 +25,142 @@ public class TableSpec

[GitHub] carbondata issue #1196: Rebase datamap branch onto master

2017-07-27 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1196 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1168: [CARBONDATA-1229] restrict drop when loading is in p...

2017-07-27 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1168 @kunal642 can you please rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-27 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1136: [CARBONDATA-1268] Support encoding strategy f...

2017-07-27 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata issue #1203: Rebase encoding_override branch onto master

2017-07-28 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1203 Thanks for working on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1203: Rebase encoding_override branch onto master

2017-07-28 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1203 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1196: Rebase datamap onto master

2017-07-26 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1196 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata pull request #1197: [CARBONDATA-1238] Decouple the datatype conve...

2017-07-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1197#discussion_r129597130 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/util/SparkDataTypeConverterImp.java --- @@ -0,0 +1,49

[GitHub] carbondata pull request #1197: [CARBONDATA-1238] Decouple the datatype conve...

2017-07-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1197#discussion_r129596893 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -768,29 +818,6 @@ public QueryModel getQueryModel(InputSplit

[GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...

2017-07-19 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1102#discussion_r128276064 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java --- @@ -32,23 +39,37 @@ /** * maxValue

[GitHub] carbondata pull request #1121: [CARBONDATA-1215][BUGFIX] Fix unsafe column p...

2017-06-30 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1121 [CARBONDATA-1215][BUGFIX] Fix unsafe column page for decimal query For decimal loading is using variable length column page, in unsafe column page implementation, there is a bug that the page

[GitHub] carbondata pull request #1122: [CARBONDATA-1253] Sort_columns should not sup...

2017-06-30 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1122#discussion_r125026813 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -691,6 +691,14 @@ abstract class

[GitHub] carbondata issue #1120: [CARBONDATA-1251] Add test cases for IUD feature

2017-06-30 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1120 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1134: Remove unnecessary LoadConfiguration creation

2017-07-04 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1134 Remove unnecessary LoadConfiguration creation Currently for every load, `LoadConfiguration` is created twice. This PR removes one unnecessary creation. You can merge this pull request

[GitHub] carbondata issue #1064: [CARBONDATA-1173] Stream ingestion - write path fram...

2017-07-04 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1064 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1117: [CARBONDATA-757] Big decimal optimization

2017-07-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1117#discussion_r125271988 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java --- @@ -99,6 +99,14 @@ public void putBytes(int

[GitHub] carbondata issue #1122: [CARBONDATA-1253] Sort_columns should not support fl...

2017-07-03 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1122 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   3   4   5   6   7   8   9   10   >