[GitHub] [carbondata] QiangCai commented on a change in pull request #3433: [CARBONDATA-3570] Change task number to jobid+taskid for FileFormat

2019-11-09 Thread GitBox 
QiangCai commented on a change in pull request #3433: [CARBONDATA-3570] Change 
task number to jobid+taskid for FileFormat
URL: https://github.com/apache/carbondata/pull/3433#discussion_r344434713
 
 

 ##
 File path: 
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
 ##
 @@ -154,8 +154,11 @@ class SparkCarbonFileFormat extends FileFormat
   path
 }
 context.getConfiguration.set("carbon.outputformat.writepath", 
updatedPath)
+// "jobid"+"x"+"taskid", task retry should have same task number
 context.getConfiguration.set("carbon.outputformat.taskno",
-  UUID.randomUUID().toString.replace("-", ""))
+  context.getTaskAttemptID.getJobID.getJtIdentifier +
+  context.getTaskAttemptID.getJobID.getId
+  + 'x' + context.getTaskAttemptID.getTaskID.getId)
 
 Review comment:
   old file name already use "-", "_"  to separate each parts. 
   taskNo is a single part, no need to use "-", "_"  to separate it. 
   So we use 'x' to contact  jobId and taskId to a single part of file name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] QiangCai commented on a change in pull request #3433: [CARBONDATA-3570] Change task number to jobid+taskid for FileFormat

2019-11-09 Thread GitBox 
QiangCai commented on a change in pull request #3433: [CARBONDATA-3570] Change 
task number to jobid+taskid for FileFormat
URL: https://github.com/apache/carbondata/pull/3433#discussion_r344434713
 
 

 ##
 File path: 
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
 ##
 @@ -154,8 +154,11 @@ class SparkCarbonFileFormat extends FileFormat
   path
 }
 context.getConfiguration.set("carbon.outputformat.writepath", 
updatedPath)
+// "jobid"+"x"+"taskid", task retry should have same task number
 context.getConfiguration.set("carbon.outputformat.taskno",
-  UUID.randomUUID().toString.replace("-", ""))
+  context.getTaskAttemptID.getJobID.getJtIdentifier +
+  context.getTaskAttemptID.getJobID.getId
+  + 'x' + context.getTaskAttemptID.getTaskID.getId)
 
 Review comment:
   old file name already use "-", "\_"  to separate each parts. 
   taskNo is a single part, no need to use "-", "\_"  to separate it. 
   So we use 'x' to contact  jobId and taskId to a single part of file name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services