[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3767: [CARBONDATA-3791] update pycarbon document

2020-05-14 Thread GitBox


ajantha-bhat commented on a change in pull request #3767:
URL: https://github.com/apache/carbondata/pull/3767#discussion_r424971480



##
File path: python/setup.py
##
@@ -44,7 +44,6 @@
 'six>=1.5.0',
 'torchvision>=0.2.1',
 'tensorflow>=1.4.0',
-'jnius>=1.1.0',

Review comment:
   ok. I reverted.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3767: [CARBONDATA-3791] update pycarbon document

2020-05-14 Thread GitBox


ajantha-bhat commented on a change in pull request #3767:
URL: https://github.com/apache/carbondata/pull/3767#discussion_r424949095



##
File path: python/setup.py
##
@@ -44,7 +44,6 @@
 'six>=1.5.0',
 'torchvision>=0.2.1',
 'tensorflow>=1.4.0',
-'jnius>=1.1.0',

Review comment:
   pyjnius doesn't work in windows ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3767: [CARBONDATA-3791] update pycarbon document

2020-05-14 Thread GitBox


ajantha-bhat commented on a change in pull request #3767:
URL: https://github.com/apache/carbondata/pull/3767#discussion_r424948739



##
File path: python/README.md
##
@@ -6,7 +6,7 @@ PyCarbon provides python API for integrating CarbonData with AI 
framework like
 
 $ git clone https://github.com/apache/carbondata.git
 
-$ cd python/pycarbon

Review comment:
   done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org