[GitHub] [carbondata] akashrn5 commented on a change in pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-07 Thread GitBox 


akashrn5 commented on a change in pull request #3808:
URL: https://github.com/apache/carbondata/pull/3808#discussion_r450658081



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala
##
@@ -121,10 +124,20 @@ object Compactor {
   segmentIdToLoadStartTimeMapping(validSegments.head),
   SegmentStatus.SUCCESS,
   carbonLoadModelForMergeDataFiles.getFactTimeStamp, 
rebuiltSegments.toList.asJava)
-
+siCompactionIndexList ::= indexCarbonTable
   } catch {
 case ex: Exception =>
   LOGGER.error(s"Compaction failed for SI table 
${secondaryIndex.indexName}", ex)
+  // If any compaction is failed then make all SI disabled which are 
success.
+  // They will be enabled in next load
+  siCompactionIndexList.foreach { indexCarbonTable =>
+sparkSession.sql(
+  s"""
+ | ALTER TABLE 
${carbonLoadModel.getDatabaseName}.${indexCarbonTable.getTableName}
+ | SET
+ | SERDEPROPERTIES ('isSITableEnabled' = 'false')

Review comment:
   move this line above





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-06 Thread GitBox 


akashrn5 commented on a change in pull request #3808:
URL: https://github.com/apache/carbondata/pull/3808#discussion_r450360202



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala
##
@@ -121,10 +124,20 @@ object Compactor {
   segmentIdToLoadStartTimeMapping(validSegments.head),
   SegmentStatus.SUCCESS,
   carbonLoadModelForMergeDataFiles.getFactTimeStamp, 
rebuiltSegments.toList.asJava)
-
+siCompactionIndexList ::= indexCarbonTable
   } catch {
 case ex: Exception =>
   LOGGER.error(s"Compaction failed for SI table 
${secondaryIndex.indexName}", ex)
+  // If any compaction is failed then make all SI disabled which are 
success.
+  // They will be enabled in next load
+  siCompactionIndexList.foreach { indexCarbonTable =>
+sparkSession.sql(
+  s"""ALTER TABLE ${

Review comment:
   format is not right, please correct it





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-01 Thread GitBox 


akashrn5 commented on a change in pull request #3808:
URL: https://github.com/apache/carbondata/pull/3808#discussion_r448761040



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala
##
@@ -121,10 +124,17 @@ object Compactor {
   segmentIdToLoadStartTimeMapping(validSegments.head),
   SegmentStatus.SUCCESS,
   carbonLoadModelForMergeDataFiles.getFactTimeStamp, 
rebuiltSegments.toList.asJava)
-
+siCompactionIndexList ::= indexCarbonTable
   } catch {
 case ex: Exception =>
   LOGGER.error(s"Compaction failed for SI table 
${secondaryIndex.indexName}", ex)
+  siCompactionIndexList.foreach { indexCarbonTable =>
+sparkSession.sql(
+  s"""ALTER TABLE ${carbonLoadModel.getDatabaseName}.${

Review comment:
   please correct the format for sparksession.sql(""), please check the 
other files where we do alter set for SI, can follow the same

##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
##
@@ -455,7 +455,7 @@ public boolean createNewLockFile() throws IOException {
 try {
   listStatus = fileSystem.listStatus(path);
 } catch (IOException e) {
-  LOGGER.error("Exception occured: " + e.getMessage(), e);

Review comment:
   revert this change if not rerquired

##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala
##
@@ -121,10 +124,17 @@ object Compactor {
   segmentIdToLoadStartTimeMapping(validSegments.head),
   SegmentStatus.SUCCESS,
   carbonLoadModelForMergeDataFiles.getFactTimeStamp, 
rebuiltSegments.toList.asJava)
-
+siCompactionIndexList ::= indexCarbonTable
   } catch {
 case ex: Exception =>
   LOGGER.error(s"Compaction failed for SI table 
${secondaryIndex.indexName}", ex)
+  siCompactionIndexList.foreach { indexCarbonTable =>

Review comment:
   please add a comment here, what you are doing in which scenario





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org