[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r496323043 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495732016 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ## @@ -169,7 +169,8 @@ case

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495732160 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLHelper.scala ## @@ -230,14 +231,22 @@ object DDLHelper {

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495731759 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495730277 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala ## @@ -1135,11 +1135,7 @@ object

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495730277 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala ## @@ -1135,11 +1135,7 @@ object

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-27 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495669154 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala ## @@ -366,7 +366,7 @@