[GitHub] carbondata issue #1245: [CARBONDATA-1366]Change rdd storage level to 'MEMORY...

2017-08-09 Thread zzcclp
Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/1245
  
@jackylk @watermen @xuchuanyin thanks for your suggestion, I have added 
option 'carbon.global.sort.rdd.storage.level', please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] carbondata issue #1245: [CARBONDATA-1366]Change rdd storage level to 'MEMORY...

2017-08-08 Thread watermen
Github user watermen commented on the issue:

https://github.com/apache/carbondata/pull/1245
  
@jackylk Agreed with @xuchuanyin, Spark’s storage levels are meant to 
provide different trade-offs between memory usage and CPU efficiency. So 
different environment correspond to different storage level. So here we'd 
better make a conf named 'storage_level', and the default value of it is 
MEMORY_ONLY(the same to default value in spark). We can get more info about 
storage level in spark 
website.(http://spark.apache.org/docs/latest/rdd-programming-guide.html#rdd-persistence)
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] carbondata issue #1245: [CARBONDATA-1366]Change rdd storage level to 'MEMORY...

2017-08-08 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/1245
  
Would it be better to make a configuration (or read configuration from 
spark) for this?cc @jackylk 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] carbondata issue #1245: [CARBONDATA-1366]Change rdd storage level to 'MEMORY...

2017-08-08 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1245
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---