Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2628
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8490/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/420/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/251/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8488/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/418/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/248/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@jackylk As a result of our discussion, I'll remove the support for
customize compressor in this PR
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/411/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8481/
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2628
LGTM. spark 2.3 CI has problem currently, we are fixing it
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/242/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8479/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/409/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/240/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@ravipesala @jackylk
I add an optional 'compressor_name' aside the 'compression_codec'. During
processing, I use the compressor_name and set compression_codec to a deprecated
value.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8472/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/402/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/233/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@ravipesala yeah, that's what I'm doing now. please check the commit:
https://github.com/apache/carbondata/pull/2628/commits/d21fd869d442f535e4704dc06d9edc2f01984cb0
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8470/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin yes, we cannot get rid of enum. But add another optional field
in `ChunkCompressionMeta` to take interface name. Just ignore the enum and read
only interface name.
@jackylk
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/400/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@ravipesala fine, I'll rework on this.
The bad news is that the Enum 'CompressionCodec' in thrift is 'required',
so even we do use it, we cannot get rid of it.
The good news is that
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/231/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8465/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@ravipesala As for the implementation, is **duplicate the info and add
another description for it by the side of current enum** OK? Or do you have
another suggestion to implement this?
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/395/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin I feel it is very necessary to save compressor name in thrift
instead of enum. It will not be a good idea to change thrift for every
compression support and also it limits the
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/226/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@ravipesala It's OK to add support column compressor in table properties.
But as for another proposal "It is better to save compressor interface name
in thrift instead of enum"
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin Please provide table property also for compressor name while
creating table
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin It is better to save compressor interface name in thrift
instead of enum. We should not change thrift for each type of compressor. We
can't let user/developer to give compressor
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/277/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8347/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/109/
---
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8342/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/272/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/104/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/26/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8328/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8324/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/254/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
fix conflicts
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
I raised another PR #2689 to replace this PR
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/206/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8277/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/204/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8275/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/194/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8265/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/180/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8251/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8171/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/100/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8165/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6476/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/94/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/88/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8159/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/76/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8147/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6460/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/38/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8101/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/35/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8097/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/29/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8090/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6425/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/19/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8077/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6416/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6748/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8024/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6371/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@QiangCai Fixed.
We will get and validate the compressor before loading and will use that
compressor during that loading procedure.
Tests are added to verify this: during data
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2628
At the begin of loading, it should specify a compressor name, and use this
value during the whole loading step.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
@jackylk
We do not have the environment to test this now.
The decompression speed of Zstd will be worse than Snappy based on Zstd's
official document. But still we do not know how
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin It is very promissing in term of compression, great!
Have you also tested for decompression speed? It will be great if it also
improves decompression speed.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6635/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6634/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7910/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6265/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
SDV Build Fail , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/6264/
---
98 matches
Mail list logo
