[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2706 please take care about the loading performance compared with previous nio.buffer implementation. ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2706 LGTM ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-19 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2706 LGTM I am merging this PR. @ajantha-bhat Please start another discussion in the forum to support big column data up to 2GB for complex, varchar and string columns. And also make the page

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2706 @ravipesala : PR is ready please review ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8586/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/516/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/339/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2706 retest this please ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/337/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/511/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8581/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/334/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2706 @xuchuanyin This 2MB limit causing many issues in varchar and complex columns. We cannot let user to configure this internal limits. We should have a growable stream. Besides, we better

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2706 @ravipesala : PR is ready. Please check. ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/488/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8558/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/312/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/309/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/484/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8554/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/308/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8553/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/483/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/307/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-11 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2706 @ajantha-bhat Hi, I think the main problem may be that you set the 'rowbuffer' as static which should not be shared among different data loadings. Besides, the judgement for

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8476/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/406/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2706 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/237/ ---

[GitHub] carbondata issue #2706: [CARBONDATA-2927] multiple issue fixes for varchar c...

2018-09-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2706 @kumarvishal09 @ravipesala : please do in-depth review for this PR. impact is more. ---