[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-15 Thread xuchuanyin 
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
LGTM


---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-14 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9659/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-14 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1611/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1401/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1601/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9649/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1391/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9644/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1596/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1386/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1385/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9610/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1562/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1352/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread zzcclp 
Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
@jackylk it now looks good to me, you added database and table name in the 
latest commit , right?


---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9608/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1560/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1350/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1348/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9606/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1558/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-09 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1347/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1549/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9597/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread jackylk 
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
@zzcclp currently, it will show
```

+---++--+--+
|   col_name|   
data_type| comment  |

+---++--+--+
| l_partkey | int   
 | null |
| l_suppkey | string
 | null |
| l_linenumber  | int   
 | null |
| l_quantity| double
 | null |
| l_extendedprice   | double
 | null |
| l_discount| double
 | null |
| l_tax | double
 | null |
| l_returnflag  | string
 | null |
| l_linestatus  | string
 | null |
| l_shipdate| date  
 | null |
| l_commitdate  | date  
 | null |
| l_receiptdate | date  
 | null |
| l_shipinstruct| string
 | null |
| l_shipmode| string
 | null |
| l_comment | string
 | null |
| l_orderkey| int   
 | null |
|   |   
 |  |
| ## Table Basic Information|   
 |  |
| Path  | 
/Users/jacky/code/spark-2.2.1-bin-hadoop2.7/carbonstore/tpchcarbon_base/lineitem_hash_no_sort
  |  |
| External  | true  
 |  |
| Transactional | true  
 |  |
| Flat Folder   | false 
 |  |
| Streaming | false 
 |  |
| Table Block Size  | 128 MB
 |  |
| Table Blocklet Size   | 64 MB 
 |  |
| Comment   |   
 |  |
| Bad Record Path   |   
 |  |
| Min Input Per Node| 0.0B  
 |  |
|   |   
 |  |
| ## Index Information  |   
 |

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1338/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread jackylk 
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
@zzcclp 
1. I think we can show the table path
2. The current DESC already has the logic to show partition info, this part 
is not changed
3. DICTIONARY_INCLUDE is added in encoding section
4. Since the DESC syntax includes database name and table name, so I think 
it is not required to show them again.
5. yes, INVERTED_INDEX is added in #2886 
6. It is not done, and in this PR the most important table property is 
shown, it will show default value is user did not specify the property when 
creating table.

Will fix according to these comments and push again


---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread zzcclp 
Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Hi @jackylk :
  I have some questions shown below:
  1. How to show external info if it's an external table?
  2. It need to show the partition info if it has partition columns;
  3. missing property: DICTIONARY_INCLUDE;
  4. doesn't it show database and table name?
  5. will remove NO_INVERTED_INDEX ? right? 
  6. doesn't it show default value for each properties? and as our 
discussion, we need to save the default value to schema info even user doesn't 
set the value, is this done?



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1544/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9592/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1333/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1542/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9590/



---

[GitHub] carbondata issue #2908: [CARBONDATA-3087] Improve DESC FORMATTED output

2018-11-08 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2908
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1331/



---