Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1237#discussion_r131462552
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -106,23 +106,13 @@ public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1237#discussion_r131462351
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -644,10 +556,9 @@ private void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1237#discussion_r131462140
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -471,124 +450,57 @@ public void
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1237
Clean up CarbonFactDataHandlerColumnar
Clean up CarbonFactDataHandlerColumnar and Writer to prepare for DataMap
write logic
You can merge this pull request into a Git repository by running:
