Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1418
---
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150442899
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -839,14 +841,56 @@ object
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150442280
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala
---
@@ -48,7 +48,8 @@ case class
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150442218
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
@@ -93,6
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150442055
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -399,16 +396,31 @@ class
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150248692
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDropTableCommand.scala
---
@@ -80,10 +88,21 @@
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150248529
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonCreateTableCommand.scala
---
@@ -37,11 +37,13 @@
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150173260
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -90,8 +90,9 @@ public LocalFileLock(String
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150172471
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/HdfsFileLock.java ---
@@ -47,26 +44,12 @@
private static String
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150171431
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1377,6 +1377,10 @@
public
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150171389
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1377,6 +1377,10 @@
public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r150004203
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -399,16 +396,31 @@ class CarbonFileMetastore
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149998981
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
@@ -93,6 +96,22
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149997215
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDropTableCommand.scala
---
@@ -43,24 +44,31 @@ case class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149997376
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDropTableCommand.scala
---
@@ -80,10 +88,21 @@ case class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149996665
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonCreateTableCommand.scala
---
@@ -37,11 +37,13 @@ case
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149994202
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonCatalystOperators.scala
---
@@ -70,6 +71,14 @@ object GetDB {
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149993636
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -839,14 +841,56 @@ object CommonUtil {
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149982091
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -167,7 +167,7 @@ class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149981553
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -167,7 +167,7 @@ class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149979665
--- Diff:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoAllDataTypeTest.scala
---
@@ -31,7 +31,7 @@ class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149979447
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -271,14 +271,20 @@ private CarbonTable
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149977104
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -885,4 +882,24 @@ public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149971910
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -90,8 +90,9 @@ public LocalFileLock(String lockFileLocation,
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149971236
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/HdfsFileLock.java ---
@@ -47,26 +44,12 @@
private static String tmpPath;
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149966152
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1377,6 +1377,10 @@
public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1418#discussion_r149966044
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1377,6 +1377,10 @@
public static
27 matches
Mail list logo
