[GitHub] carbondata pull request #1959: [CARBONDATA-2148][CARBONDATA-2147] Add new Ro...

2018-02-27 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1959


---

[GitHub] carbondata pull request #1959: [CARBONDATA-2148][CARBONDATA-2147] Add new Ro...

2018-02-26 Thread zzcclp 
Github user zzcclp commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1959#discussion_r170832185
  
--- Diff: 
streaming/src/main/java/org/apache/carbondata/streaming/parser/CarbonStreamParser.java
 ---
@@ -27,9 +28,10 @@
 
   String CARBON_STREAM_PARSER = "carbon.stream.parser";
 
-  String CARBON_STREAM_PARSER_DEFAULT = 
"org.apache.carbondata.streaming.parser.CSVStreamParserImp";
+  String CARBON_STREAM_PARSER_DEFAULT =
+  "org.apache.carbondata.streaming.parser.RowStreamParserImp";
--- End diff --

OK


---

[GitHub] carbondata pull request #1959: [CARBONDATA-2148][CARBONDATA-2147] Add new Ro...

2018-02-26 Thread jackylk 
Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1959#discussion_r170799400
  
--- Diff: 
streaming/src/main/java/org/apache/carbondata/streaming/parser/CarbonStreamParser.java
 ---
@@ -27,9 +28,10 @@
 
   String CARBON_STREAM_PARSER = "carbon.stream.parser";
 
-  String CARBON_STREAM_PARSER_DEFAULT = 
"org.apache.carbondata.streaming.parser.CSVStreamParserImp";
+  String CARBON_STREAM_PARSER_DEFAULT =
+  "org.apache.carbondata.streaming.parser.RowStreamParserImp";
--- End diff --

I think it is better not to modify the default value of 
CARBON_STREAM_PARSER_DEFAULT, if user want to use 
org.apache.carbondata.streaming.parser.RowStreamParserImp, user can use it by 
setting `carbon.stream.parser` in the option when loading


---

[GitHub] carbondata pull request #1959: [CARBONDATA-2148][CARBONDATA-2147] Add new Ro...

2018-02-10 Thread zzcclp 
Github user zzcclp commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1959#discussion_r167423204
  
--- Diff: 
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
 ---
@@ -775,6 +776,8 @@ class TestStreamingTableOperation extends QueryTest 
with BeforeAndAfterAll {
 .option("bad_records_action", badRecordAction)
 .option("dbName", tableIdentifier.database.get)
 .option("tableName", tableIdentifier.table)
+.option(CarbonStreamParser.CARBON_STREAM_PARSER,
+  "org.apache.carbondata.streaming.parser.CSVStreamParserImp")
--- End diff --

After PR#1962 is merged, I will modify it , otherwise there is error when 
write complex type data.


---

[GitHub] carbondata pull request #1959: [CARBONDATA-2148][CARBONDATA-2147] Add new Ro...

2018-02-10 Thread zzcclp 
Github user zzcclp commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1959#discussion_r167420058
  
--- Diff: 
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
 ---
@@ -775,6 +776,8 @@ class TestStreamingTableOperation extends QueryTest 
with BeforeAndAfterAll {
 .option("bad_records_action", badRecordAction)
 .option("dbName", tableIdentifier.database.get)
 .option("tableName", tableIdentifier.table)
+.option(CarbonStreamParser.CARBON_STREAM_PARSER,
+  "org.apache.carbondata.streaming.parser.CSVStreamParserImp")
--- End diff --

OK, I will modify it later.


---

[GitHub] carbondata pull request #1959: [CARBONDATA-2148][CARBONDATA-2147] Add new Ro...

2018-02-10 Thread QiangCai 
Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1959#discussion_r167416315
  
--- Diff: 
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
 ---
@@ -775,6 +776,8 @@ class TestStreamingTableOperation extends QueryTest 
with BeforeAndAfterAll {
 .option("bad_records_action", badRecordAction)
 .option("dbName", tableIdentifier.database.get)
 .option("tableName", tableIdentifier.table)
+.option(CarbonStreamParser.CARBON_STREAM_PARSER,
+  "org.apache.carbondata.streaming.parser.CSVStreamParserImp")
--- End diff --

Better to use default parser, 
Can you modify it, like CarbonStructuredStreamingExample.scala


---