[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1991


---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[rahulforallp]

Github user rahulforallp commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1991#discussion_r171489212
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] 
locations) {
   }
 }
   }
+
   /**
+   *
* This method will form the local data folder store location
*
-   * @param databaseName
-   * @param tableName
+   * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+   * @param isCompactionFlow
+   * @param isAltPartitionFlow
* @return
*/
-  public static String[] getLocalDataFolderLocation(String databaseName, 
String tableName,
+  public static String[] getLocalDataFolderLocation(CarbonTable 
carbonTable, String tableName,
--- End diff --

 in case of Pre aggregate table, table name can be of child even though 
carbonTable object is for main table.


---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[QiangCai]

Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1991#discussion_r171487297
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] 
locations) {
   }
 }
   }
+
   /**
+   *
* This method will form the local data folder store location
*
-   * @param databaseName
-   * @param tableName
+   * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+   * @param isCompactionFlow
+   * @param isAltPartitionFlow
* @return
*/
-  public static String[] getLocalDataFolderLocation(String databaseName, 
String tableName,
+  public static String[] getLocalDataFolderLocation(CarbonTable 
carbonTable, String tableName,
--- End diff --

not require tableName


---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[rahulforallp]

Github user rahulforallp commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1991#discussion_r170417245
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] 
locations) {
   }
 }
   }
+
   /**
+   *
* This method will form the local data folder store location
*
-   * @param databaseName
-   * @param tableName
+   * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+   * @param isCompactionFlow
+   * @param isAltPartitionFlow
* @return
*/
-  public static String[] getLocalDataFolderLocation(String databaseName, 
String tableName,
+  public static String[] getLocalDataFolderLocation(CarbonTable 
carbonTable,
--- End diff --

done


---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1991#discussion_r170412687
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] 
locations) {
   }
 }
   }
+
   /**
+   *
* This method will form the local data folder store location
*
-   * @param databaseName
-   * @param tableName
+   * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+   * @param isCompactionFlow
+   * @param isAltPartitionFlow
* @return
*/
-  public static String[] getLocalDataFolderLocation(String databaseName, 
String tableName,
+  public static String[] getLocalDataFolderLocation(CarbonTable 
carbonTable,
--- End diff --

Dont remove parameter tableName, you can remove databaseName, as in case of 
Pre aggregate table, table name can be of child even though carbonTable object 
is for main table


---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[rahulforallp]

GitHub user rahulforallp opened a pull request:

https://github.com/apache/carbondata/pull/1991

[CARBONDATA-2196]carbontable should be taken from loadmodel

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rahulforallp/incubator-carbondata 
CARBONDATA-2196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1991


commit 72c7feace3a93b4cecde6beb9f17e983ea6912cb
Author: rahulforallp 
Date:   2018-02-22T12:59:57Z

carbontable should be taken from loadmodel




---